From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: project.el: git submodules? Date: Thu, 14 May 2020 23:13:48 +0300 Message-ID: <21e149fc-dba5-47f0-ea7f-60a16ea32819@yandex.ru> References: <875zd1ni5i.fsf@md5i.com> <55769244-c84c-dff0-4427-9ff688f81af5@yandex.ru> <87v9l0nar5.fsf@md5i.com> <95a8c285-125f-afda-b1bc-d1c0452e5c31@yandex.ru> <1bc2052e-b26b-1f3d-f78c-a22112861f27@yandex.ru> <7b247aac-28bd-94c1-2546-524edde9b781@yandex.ru> <42510ba9-1235-7180-af36-2d9de24835b4@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="22268"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 Cc: Michael Welsh Duggan , Gary Oberbrunner , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 14 22:14:26 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jZKFN-0005gL-KO for ged-emacs-devel@m.gmane-mx.org; Thu, 14 May 2020 22:14:25 +0200 Original-Received: from localhost ([::1]:55612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZKFM-00070k-Jy for ged-emacs-devel@m.gmane-mx.org; Thu, 14 May 2020 16:14:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZKEs-0006Ze-Cx for emacs-devel@gnu.org; Thu, 14 May 2020 16:13:54 -0400 Original-Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:51791) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZKEq-0002gg-UK for emacs-devel@gnu.org; Thu, 14 May 2020 16:13:54 -0400 Original-Received: by mail-wm1-x330.google.com with SMTP id f134so19946071wmf.1 for ; Thu, 14 May 2020 13:13:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=E1VQh2ZexqERA4aqK/Tx2CAGnIIvNn0pjtr1Y6qSuic=; b=iv9wcKWny6u4OHGLkgMP3kThO5gawa9rDJP/KGqXRYe/a62lQT4I6Crgl/W+pZe/BQ h2YNzj+PzLz33DY7sq18gRe5ZfJ/hK6/TV1xrIz3zh4nQL1hzxDP4kFSZvZMj0kNdg4Y F5916IVgDbRuxoHR0iHxUlfc/QFf/j5IjhPzAMac5uNFJUSNtI8XW4dlhL5QIFCTlccg x92zT1IM8ZioP0afEddCUnVcsgioqqVCRTE48uzYrXg//LkRFLvqrjT7B+4lT7mZABVL ErT8HrT5Nsq54DFK3Vwyu4bH/QLe1h1EJF4NydajYw5Wq6AT6cn/4DTMZtnFnmYdOMOn Kp4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=E1VQh2ZexqERA4aqK/Tx2CAGnIIvNn0pjtr1Y6qSuic=; b=RmdjokULpDgY4rxIYuxFm7yp1FcyUj9pQdtD7muHWO5sJgvVw/O4GALGaBWx3VqcM2 XsJ+qUK7nN4mGjx3PDc87w6Q9h7IHAV7IQvVfqKpoZ0gzikw2itmBmoWBcLMW3mi9+NL NdkDO3IbscjkhMkmF69OwXTlw+WUcnjaktNjtZ4TszKFaIt+g72KlgclG2aFtXnS6uzF xOOBQdtyXLPxHMmGDmzmtzW/L9UpDEzMlQKNnn1/AyRQvRlOu3Wt6je1ICbVaVexnugV P70Hh1opFJhnMrZiir2G+RFrUkMCj8McOoXbf9w3RAyxbtOK86LlPdkP4tEC/Uge6YKu xMAQ== X-Gm-Message-State: AOAM530nslmdO22U05rY2t9LH2Opk5l0FgKAnVs5mcRFVbH0zKBU7w0n pfE1iuD3fzmv4kIYlZK8rPEXVn4M X-Google-Smtp-Source: ABdhPJxOI0EBZR0CAzXF+y0bZ58vDdCEj9L8U4ggK6xP4oFD/Xv/3017SexxJFzkn/DKiiXz+hw17g== X-Received: by 2002:a1c:3281:: with SMTP id y123mr102760wmy.30.1589487231123; Thu, 14 May 2020 13:13:51 -0700 (PDT) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id w15sm202701wmi.35.2020.05.14.13.13.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 May 2020 13:13:50 -0700 (PDT) In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=raaahh@gmail.com; helo=mail-wm1-x330.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:250288 Archived-At: On 14.05.2020 23:01, Stefan Monnier wrote: > + (or > + (let ((default-directory parent)) > + (vc-root-dir)) > + root))))) > > I'm not familiar enough with this code to understand what it does: which > part tests "is it a submodule"? The removed part. > Or alternatively, which part compares > the location of the two repositories? The part quoted above. If the parent directory of the root of the current Git worktree belongs to a VC worktree (vc-root-dir returns non-nil), use that worktree's root. Otherwise, use the root of the current repo.