From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#64531: [PATCH v2] Add new command vc-dir-copy-filename-as-kill Date: Sun, 20 Aug 2023 02:33:59 +0300 Message-ID: <21b04273-e7e5-cbe5-cd95-9484a89a4b64@yandex.ru> References: <87bkgmq1ra.fsf@ya.ru> <83jzvadabq.fsf@gnu.org> <87bkfhy7fr.fsf_-_@ya.ru> <83a5un1mn3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7968"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: 64531@debbugs.gnu.org To: Eli Zaretskii , Ivan Sokolov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 20 01:35:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXVTX-0001th-2Y for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Aug 2023 01:35:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXVTC-0003p0-QS; Sat, 19 Aug 2023 19:35:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXVTA-0003oY-Ki for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 19:35:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXVTA-00081x-Cj for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 19:35:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXVTB-0006MA-K2 for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 19:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Aug 2023 23:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64531 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64531-submit@debbugs.gnu.org id=B64531.169248805624371 (code B ref 64531); Sat, 19 Aug 2023 23:35:01 +0000 Original-Received: (at 64531) by debbugs.gnu.org; 19 Aug 2023 23:34:16 +0000 Original-Received: from localhost ([127.0.0.1]:52451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXVSS-0006Kz-Ax for submit@debbugs.gnu.org; Sat, 19 Aug 2023 19:34:16 -0400 Original-Received: from forward102c.mail.yandex.net ([2a02:6b8:c03:500:1:45:d181:d102]:46304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXVSQ-0006Km-Iv for 64531@debbugs.gnu.org; Sat, 19 Aug 2023 19:34:15 -0400 Original-Received: from mail-nwsmtp-smtp-production-main-81.myt.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-81.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:530c:0:640:7b0d:0]) by forward102c.mail.yandex.net (Yandex) with ESMTP id A720860014; Sun, 20 Aug 2023 02:34:06 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-81.myt.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id 4YtrXPPDeGk0-z7cdEueC; Sun, 20 Aug 2023 02:34:05 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1692488046; bh=HjztpwqWjDfPiCpqRlVFxkMPyeI0d/UbjQMpt5TFZU0=; h=In-Reply-To:From:Subject:Message-ID:Cc:References:Date:To; b=hjolQarVmfGCyiVqx38cj25ATE70BCr6GPN9DFaxz6AqPSy08sV91ZEQ8/kWO2vOa Bk0gHvPl3SVJYNdEnq8bzeyThqU4AO+NqkuCIdAqPnffMdxdMgdPkbJwoPGvCmbxrk SUsObQEKNtHgXModwCsD5fYqohgh+jry2rp6Oymc= Authentication-Results: mail-nwsmtp-smtp-production-main-81.myt.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailauth.nyi.internal (Postfix) with ESMTP id CD51227C0054; Sat, 19 Aug 2023 19:34:03 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 19 Aug 2023 19:34:03 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudduiedgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegughhuthhovheshigrnhguvgigrdhruheqnecuggftrfgrth htvghrnheptdffgeegkeelteevtdekleethfeftdduvdegkedtkedujefhfedtveeftdff udevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hguhhtohhvodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqddufeeffeelleeh hedvqddvleegjeejjeejiedqughguhhtohhvpeephigrnhguvgigrdhruhesfhgrshhtmh grihhlrdgtohhm X-ME-Proxy: Feedback-ID: ib1d9465d:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 19 Aug 2023 19:34:01 -0400 (EDT) Content-Language: en-US In-Reply-To: <83a5un1mn3.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267926 Archived-At: Hi Eli, On 19/08/2023 11:06, Eli Zaretskii wrote: > Dmitry, is this good to go in? I'm good with the binding and the general functionality. The difference from dired-copy-filename-as-kill in handing of the prefix argument looks unfortunate (as a principle), but I'd rather leave it for you to judge. Perhaps changing the latter command's interface would be a better choice; I'm not sure why it works that way. Implementation difference: instead of going through (format "%S"), this one uses shell-quote-argument. Is that good enough for Windows systems? And one more difference which we might want to see fixed: (When there's a single file, no quoting is done.) It seems like, at least, in some usage scenarios users would prefer to have copied filename not quoted. E.g. for subsequent use with find-file or... something similar. I don't really use this command all that much, so maybe I'm mistaken here, though.