From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#8523: 24.0.50; `dired-mark-if': wrong message if unmarking or unflagging Date: Tue, 19 Apr 2011 12:46:26 -0700 Message-ID: <21D6E4BD07BC4102A952CF14DB19B461@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1303243662 22416 80.91.229.12 (19 Apr 2011 20:07:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 19 Apr 2011 20:07:42 +0000 (UTC) To: 8523@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 19 22:07:38 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QCHCw-0007La-R8 for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Apr 2011 22:07:35 +0200 Original-Received: from localhost ([::1]:45965 helo=lists2.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCHCw-0001O2-9c for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Apr 2011 16:07:34 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:48566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCHCs-0001Nw-Rx for bug-gnu-emacs@gnu.org; Tue, 19 Apr 2011 16:07:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QCHCr-0006da-W0 for bug-gnu-emacs@gnu.org; Tue, 19 Apr 2011 16:07:30 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44216) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCHCr-0006dQ-Qc for bug-gnu-emacs@gnu.org; Tue, 19 Apr 2011 16:07:29 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QCGt3-0003As-Pw; Tue, 19 Apr 2011 15:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Apr 2011 19:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.130324240912180 (code B ref -1); Tue, 19 Apr 2011 19:47:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Apr 2011 19:46:49 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QCGsq-0003AP-9x for submit@debbugs.gnu.org; Tue, 19 Apr 2011 15:46:48 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QCGso-0003AE-BI for submit@debbugs.gnu.org; Tue, 19 Apr 2011 15:46:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QCGsh-00036q-1v for submit@debbugs.gnu.org; Tue, 19 Apr 2011 15:46:41 -0400 Original-Received: from lists.gnu.org ([140.186.70.17]:59435) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCGsg-00036g-W8 for submit@debbugs.gnu.org; Tue, 19 Apr 2011 15:46:39 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:46434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCGsg-0006dY-3o for bug-gnu-emacs@gnu.org; Tue, 19 Apr 2011 15:46:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QCGsf-00036I-4w for bug-gnu-emacs@gnu.org; Tue, 19 Apr 2011 15:46:38 -0400 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]:41521) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCGse-00035v-W4 for bug-gnu-emacs@gnu.org; Tue, 19 Apr 2011 15:46:37 -0400 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id p3JJkVrc023696 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Apr 2011 19:46:33 GMT Original-Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p3JJkUcG027798 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 19 Apr 2011 19:46:31 GMT Original-Received: from abhmt021.oracle.com (abhmt021.oracle.com [141.146.116.30]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p3JJkPLW030449 for ; Tue, 19 Apr 2011 14:46:25 -0500 Original-Received: from dradamslap1 (/10.159.44.151) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 19 Apr 2011 12:46:25 -0700 X-Mailer: Microsoft Office Outlook 11 Thread-Index: Acv+yng+DutpFbmQRxyrCAn8QOG5jQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6090 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 19 Apr 2011 15:47:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45875 Archived-At: `dired-mark-if' is used for marking, flagging (for deletion), and unflagging. The particular behavior depends on the value of `dired-marker-char'. The final message reflects this variation correctly, by testing `dired-marker-char'. But the initial message does not. It always says "Marking ...". That's strictly true, since marking with a space char amounts to unmarking. Still, the message could be more user-friendly. Here's a fix. Change the code: (if ,msg "Marking %ss..." ,msg) to this: (when ,msg (message "%s %ss%s..." ,(cond ((eq ?\040 dired-marker-char) "Unmarking") ((eq dired-del-marker dired-marker-char) "Flagging") (t "Marking")) ,msg ,(if (eq dired-del-marker dired-marker-char) " for deletion" ""))) In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2011-04-18 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.5) --no-opt --cflags -Ic:/imagesupport/include'