From: "Drew Adams" <drew.adams@oracle.com>
To: 8523@debbugs.gnu.org
Subject: bug#8523: 24.0.50; `dired-mark-if': wrong message if unmarking or unflagging
Date: Tue, 19 Apr 2011 12:46:26 -0700 [thread overview]
Message-ID: <21D6E4BD07BC4102A952CF14DB19B461@us.oracle.com> (raw)
`dired-mark-if' is used for marking, flagging (for deletion), and
unflagging. The particular behavior depends on the value of
`dired-marker-char'.
The final message reflects this variation correctly, by testing
`dired-marker-char'. But the initial message does not. It always says
"Marking <blah blah>...". That's strictly true, since marking with a
space char amounts to unmarking. Still, the message could be more
user-friendly.
Here's a fix. Change the code: (if ,msg "Marking %ss..." ,msg)
to this:
(when ,msg
(message "%s %ss%s..."
,(cond ((eq ?\040 dired-marker-char) "Unmarking")
((eq dired-del-marker dired-marker-char)
"Flagging")
(t "Marking"))
,msg
,(if (eq dired-del-marker dired-marker-char)
" for deletion"
"")))
In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
of 2011-04-18 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt --cflags
-Ic:/imagesupport/include'
next reply other threads:[~2011-04-19 19:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 19:46 Drew Adams [this message]
2011-07-02 13:29 ` bug#8523: 24.0.50; `dired-mark-if': wrong message if unmarking or unflagging Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21D6E4BD07BC4102A952CF14DB19B461@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=8523@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.