bug#21133: Fwd: [Bug 555622] app-editors/emacs-vcs-25.0.50_pre20150630 : ftcrfont.c:109:5: error: ‘ftfont_driver’ undeclared (first use in this function)

bug#21133: Fwd: [Bug 555622] app-editors/emacs-vcs-25.0.50_pre20150630 : ftcrfont.c:109:5: error: ‘ftfont_driver’ undeclared (first use in this function)

[Toralf Förster]

Hello,

there's a bug originated in  Gentoos bugzilla:


https://bugs.gentoo.org/show_bug.cgi?id=555622


Ulrich Müller <ulm@gentoo.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jan.h.d@swipnet.se

--- Comment #2 from Ulrich Müller <ulm@gentoo.org> ---
I can reproduce the problem with your USE flag settings. Both the 20150331 and
20150430 snapshots (the latter in my local overlay only) still compile fine,
whereas the 20150531 snapshot fails. Emacs from git master (as of today) also
fails with your USE flags.

Git bisecting shows that the breakage originates from the cairo branch:

   dddcc0e78452f2186c132823a33a174d2596ba33 is the first bad commit
   commit dddcc0e78452f2186c132823a33a174d2596ba33
   Author: Jan D <jan.h.d@swipnet.se>
   Date:   Wed Feb 11 16:14:35 2015 +0100

       Add cairo drawing.


Can you please report the bug upstream? There is little we could do here at the
distro level.

-- 
You are receiving this mail because:
You reported the bug.

bug#21133: Fwd: [Bug 555622] app-editors/emacs-vcs-25.0.50_pre20150630 : ftcrfont.c:109:5: error: ‘ftfont_driver’ undeclared (first use in this function)

[Glenn Morris]

Toralf Förster wrote:

> https://bugs.gentoo.org/show_bug.cgi?id=555622

If I may summarise:

./configure --with-cairo --without-xft

fails with undefined reference to ftfont_driver in ftcrfont.c.

Perhaps this is simply not a sensible set of configure options to use.

I would also suggest that Gentoo stop enabling --with-cairo,
and that the --with-cairo option perhaps be labelled experimental.

bug#21133: Fwd: [Bug 555622] app-editors/emacs-vcs-25.0.50_pre20150630 : ftcrfont.c:109:5: error: ‘ftfont_driver’ undeclared (first use in this function)

[YAMAMOTO Mitsuharu]

On Sun, 26 Jul 2015 03:35:33 +0900,
Glenn Morris wrote:
> 
> Toralf Förster wrote:
> 
> > https://bugs.gentoo.org/show_bug.cgi?id=555622
> 
> If I may summarise:
> 
> ./configure --with-cairo --without-xft
> 
> fails with undefined reference to ftfont_driver in ftcrfont.c.
> 
> Perhaps this is simply not a sensible set of configure options to use.
> 
> I would also suggest that Gentoo stop enabling --with-cairo,
> and that the --with-cairo option perhaps be labelled experimental.

Dependency on libXft for the cairo build was removed on master by the
commit 5f4e8e2e088.  Closing the bug.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

bug#21133: Fwd: [Bug 555622] app-editors/emacs-vcs-25.0.50_pre20150630 : ftcrfont.c:109:5: error: ‘ftfont_driver’ undeclared (first use in this function)

[Ulrich Mueller]

> If I may summarise:

> ./configure --with-cairo --without-xft

> fails with undefined reference to ftfont_driver in ftcrfont.c.

> Perhaps this is simply not a sensible set of configure options to
> use.

Maybe configure should take care of this, and enable cairo only under
the condition that xft is enabled too?

There is a similar problem with --with-cairo --without-png, by the
way. When linking temacs:
image.o:(.data+0x90): undefined reference to `png_load'

> I would also suggest that Gentoo stop enabling --with-cairo,
> and that the --with-cairo option perhaps be labelled experimental.

In fact, our whole app-editors/emacs-vcs package is experimental.
We usually reveal any upstream configure options as USE flags.
(After all, this is not an experimental branch, but git master.)

Of course, I can mask the cairo flag in addition, if you think that's
appropriate.

bug#21133: Fwd: [Bug 555622] app-editors/emacs-vcs-25.0.50_pre20150630 : ftcrfont.c:109:5: error: ‘ftfont_driver’ undeclared (first use in this function)

[Eli Zaretskii]

> Date: Sun, 26 Jul 2015 14:14:06 +0200
> From: Ulrich Mueller <ulm@gentoo.org>
> Cc: Toralf Förster <toralf.foerster@gmx.de>
> 
> There is a similar problem with --with-cairo --without-png, by the
> way. When linking temacs:
> image.o:(.data+0x90): undefined reference to `png_load'

The culprit seems to be this condition around line 5645 of image.c:

  #if defined HAVE_PNG && !defined HAVE_NS

It should say this instead, I think:

  #if (defined HAVE_PNG && !defined HAVE_NS) || defined USE_CAIRO

But I cannot test that.

bug#21133: Fwd: [Bug 555622] app-editors/emacs-vcs-25.0.50_pre20150630 : ftcrfont.c:109:5: error: ‘ftfont_driver’ undeclared (first use in this function)

[Ulrich Mueller]

>>>>> On Sun, 26 Jul 2015, Eli Zaretskii wrote:

>> There is a similar problem with --with-cairo --without-png, by the
>> way. When linking temacs:
>> image.o:(.data+0x90): undefined reference to `png_load'

> The culprit seems to be this condition around line 5645 of image.c:

>   #if defined HAVE_PNG && !defined HAVE_NS

> It should say this instead, I think:

>   #if (defined HAVE_PNG && !defined HAVE_NS) || defined USE_CAIRO

This change makes it compile for me.

bug#21133: Fwd: [Bug 555622] app-editors/emacs-vcs-25.0.50_pre20150630 : ftcrfont.c:109:5: error: ‘ftfont_driver’ undeclared (first use in this function)

[Eli Zaretskii]

> Date: Mon, 27 Jul 2015 07:35:07 +0200
> Cc: 21133@debbugs.gnu.org, toralf.foerster@gmx.de
> From: Ulrich Mueller <ulm@gentoo.org>
> 
> >>>>> On Sun, 26 Jul 2015, Eli Zaretskii wrote:
> 
> >> There is a similar problem with --with-cairo --without-png, by the
> >> way. When linking temacs:
> >> image.o:(.data+0x90): undefined reference to `png_load'
> 
> > The culprit seems to be this condition around line 5645 of image.c:
> 
> >   #if defined HAVE_PNG && !defined HAVE_NS
> 
> > It should say this instead, I think:
> 
> >   #if (defined HAVE_PNG && !defined HAVE_NS) || defined USE_CAIRO
> 
> This change makes it compile for me.

Thanks, I pushed it.