Org-mode version 6.30trans (release_6.30d.19.g1db9); Last character in file not folded correctly

Org-mode version 6.30trans (release_6.30d.19.g1db9); Last character in file not folded correctly

[Andreas Burtzlaff]

The last character in a file is not folded correctly,e.g:

<begin example>

* fold this heading

The following X is the *last character* in the file: X<end example>


yields:


* fold this heading...X



Emacs  : GNU Emacs 23.1.1 (x86_64-pc-linux-gnu, GTK+ Version 2.14.7)
 of 2009-08-21 on fluxx
Package: Org-mode version 6.30trans (release_6.30d.19.g1db9)

Re: Org-mode version 6.30trans (release_6.30d.19.g1db9); Last character in file not folded correctly

[Giovanni Ridolfi]

--- Lun 7/9/09, Andreas Burtzlaff <andy13@gmx.net> ha scritto:
> The last character in a file is not folded correctly,e.g:
> 
[...] 
> * fold this heading...X
> 
> Emacs  : GNU Emacs 23.1.1 (x86_64-pc-linux-gnu, GTK+
> Version 2.14.7)
>  of 2009-08-21 on fluxx
> Package: Org-mode version 6.30trans
> (release_6.30d.19.g1db9)

I can reproduce it also with 
Org-mode  6.30e

Giovanni

Re: Org-mode version 6.30trans (release_6.30d.19.g1db9); Last character in file not folded correctly

[David Maus]

According to Carsten this misbehaviour is not Orgmode's fault, but
Outline-Mode's

http://www.mail-archive.com/emacs-orgmode@gnu.org/msg16542.html

and should be reported as a bug in Emacs23 (what I do use, too).

*But*: I didn't file a bugreport for Emacs because I cannot reproduce
this misbehavior outside Orgmode. It's indeed (hide-subtree) that
causes the last char beneath a headline be displayed after the
three-dots-thingy but (hide-subtree) behaves fine when used in 'pure'
outline-mode.

So, I decided not to dig into the issue to make file a bugreport as I
can live with it and am quite occupied at the moment.

Regards,

  -- David

-- 
OpenPGP... 0x316F4BE4670716FD
Jabber.... dmjena@jabber.org
Email..... maus.david@gmail.com
ICQ....... 241051416

Re: [PATCH] Org-mode version 6.30trans (release_6.30d.19.g1db9); Last character in file not folded correctly

[Andreas Burtzlaff]

On Mon, 07 Sep 2009 17:59:14 +0200
David Maus <maus.david@gmail.com> wrote:

> 
> According to Carsten this misbehaviour is not Orgmode's fault, but
> Outline-Mode's
> 
> http://www.mail-archive.com/emacs-orgmode@gnu.org/msg16542.html
> 
> and should be reported as a bug in Emacs23 (what I do use, too).
> 
> *But*: I didn't file a bugreport for Emacs because I cannot reproduce
> this misbehavior outside Orgmode. It's indeed (hide-subtree) that
> causes the last char beneath a headline be displayed after the
> three-dots-thingy but (hide-subtree) behaves fine when used in 'pure'
> outline-mode.

It was indeed org-modes rewrite of outline-end-of-subtree that
triggered the misbehaviour.

Here's the patch:

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/org.el b/lisp/org.el
index 74d7f78..c75f1b9 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -16880,7 +16880,7 @@ If there is no such heading, return nil."
   (if (eq major-mode 'org-mode)
       (progn
        (org-end-of-subtree nil t)
-       (backward-char 1))
+       (if (not (eobp)) (backward-char 1)))
     ad-do-it))
 
 (defun org-forward-same-level (arg &optional invisible-ok)
--8<---------------cut here---------------end--------------->8---

Andreas

Re: [PATCH] Org-mode version 6.30trans (release_6.30d.19.g1db9); Last character in file not folded correctly

[Bastien]

Applied, thanks.

Andreas Burtzlaff <andy13@gmx.net> writes:

> It was indeed org-modes rewrite of outline-end-of-subtree that
> triggered the misbehaviour.
>
> Here's the patch:
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 74d7f78..c75f1b9 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -16880,7 +16880,7 @@ If there is no such heading, return nil."
>    (if (eq major-mode 'org-mode)
>        (progn
>         (org-end-of-subtree nil t)
> -       (backward-char 1))
> +       (if (not (eobp)) (backward-char 1)))
>      ad-do-it))
>  
>  (defun org-forward-same-level (arg &optional invisible-ok)
>
> Andreas
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>

-- 
 Bastien