From: Ulrich Mueller <ulm@gentoo.org>
To: 19921@debbugs.gnu.org
Subject: bug#19921: [PATCH] browse-url-firefox: Remove MS-Windows special case.
Date: Sat, 7 Mar 2015 12:16:23 +0100 [thread overview]
Message-ID: <21754.56839.582479.848900@a1i15.kph.uni-mainz.de> (raw)
In-Reply-To: <20150222.170113.1017436961048435194.ryo_on@yk.rim.or.jp>
Firefox on MS-Windows supports both the -new-tab and -new-window
options, so the special case is no longer necessary there. I have
tested this with Firefox 11.0 under Windows XP and Firefox 36.0.1
under MS-Windows 8.1.
See patch below. It should be pushed to the emacs-24 branch, I guess?
From 3e3f9ade6aa13fbeb93ee2eee117ef8e04aec5d2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <ulm@gentoo.org>
Date: Sat, 7 Mar 2015 11:47:56 +0100
Subject: [PATCH] browse-url-firefox: Remove MS-Windows special case.
* lisp/net/browse-url.el (browse-url-firefox): Remove MS-Windows
special case.
---
lisp/ChangeLog | 5 +++++
lisp/net/browse-url.el | 17 +++++------------
2 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 0e4e463..95ab6cc 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2015-03-07 Ulrich Müller <ulm@gentoo.org>
+
+ * net/browse-url.el (browse-url-firefox): Remove MS-Windows
+ special case.
+
2015-03-07 Eli Zaretskii <eliz@gnu.org>
* dired.el (dired-delete-file): Doc fix. (Bug#20021)
diff --git a/lisp/net/browse-url.el b/lisp/net/browse-url.el
index 4819cdc..d82d447 100644
--- a/lisp/net/browse-url.el
+++ b/lisp/net/browse-url.el
@@ -1117,11 +1117,7 @@ whenever a document would otherwise be loaded in a new window, it
is loaded in a new tab in an existing window instead.
Non-interactively, this uses the optional second argument NEW-WINDOW
-instead of `browse-url-new-window-flag'.
-
-On MS Windows, this ignores `browse-url-new-window-flag' and
-`browse-url-firefox-new-window-is-tab', as well as the NEW-WINDOW argument.
-It always uses a new window."
+instead of `browse-url-new-window-flag'."
(interactive (browse-url-interactive-arg "URL: "))
(setq url (browse-url-encode-url url))
(let* ((process-environment (browse-url-process-environment)))
@@ -1130,13 +1126,10 @@ It always uses a new window."
browse-url-firefox-program
(append
browse-url-firefox-arguments
- ;; FIXME someone should check if this limitation
- ;; still applies.
- (unless (memq system-type '(windows-nt ms-dos))
- (if (browse-url-maybe-new-window new-window)
- (if browse-url-firefox-new-window-is-tab
- '("-new-tab")
- '("-new-window"))))
+ (if (browse-url-maybe-new-window new-window)
+ (if browse-url-firefox-new-window-is-tab
+ '("-new-tab")
+ '("-new-window")))
(list url)))))
;;;###autoload
--
2.3.1
next prev parent reply other threads:[~2015-03-07 11:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-22 8:01 bug#19921: Support URL open for upcomming Mozilla Firefox 36 Ryo ONODERA
2015-02-24 23:05 ` Glenn Morris
2015-03-02 8:49 ` Peter Münster
2015-03-02 17:01 ` Glenn Morris
2015-02-27 8:12 ` bug#19921: SIGHUP related subtlety remains Teika Kazura
2015-03-07 11:16 ` Ulrich Mueller [this message]
2015-03-07 12:16 ` bug#19921: [PATCH] browse-url-firefox: Remove MS-Windows special case Eli Zaretskii
2015-03-07 12:50 ` Ulrich Mueller
2015-03-07 13:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21754.56839.582479.848900@a1i15.kph.uni-mainz.de \
--to=ulm@gentoo.org \
--cc=19921@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.