* Minor Patch: Respect browse-url-new-window-flag
@ 2014-12-01 3:08 T. V. Raman
2014-12-01 4:04 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: T. V. Raman @ 2014-12-01 3:08 UTC (permalink / raw)
To: emacs-devel
Here is a simple patch to eww.el to respect option
browse-url-new-window-flag
git diff master -- eww.el
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 2059b5e..4613b4c 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -680,7 +680,7 @@ the like."
;;;###autoload
(defun eww-browse-url (url &optional new-window)
- (cond (new-window
+ (cond ((or browse-url-new-window-flagnew-window)
(let ((new-buffer "*eww*")
(num 0))
(while (get-buffer new-buffer)
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: Minor Patch: Respect browse-url-new-window-flag
2014-12-01 3:08 Minor Patch: Respect browse-url-new-window-flag T. V. Raman
@ 2014-12-01 4:04 ` Lars Magne Ingebrigtsen
2014-12-01 17:41 ` T.V Raman
0 siblings, 1 reply; 3+ messages in thread
From: Lars Magne Ingebrigtsen @ 2014-12-01 4:04 UTC (permalink / raw)
To: T. V. Raman; +Cc: tv.raman.tv, emacs-devel
"T. V. Raman" <raman@google.com> writes:
> Here is a simple patch to eww.el to respect option
> browse-url-new-window-flag
> git diff master -- eww.el
> diff --git a/lisp/net/eww.el b/lisp/net/eww.el
> index 2059b5e..4613b4c 100644
> --- a/lisp/net/eww.el
> +++ b/lisp/net/eww.el
> @@ -680,7 +680,7 @@ the like."
>
> ;;;###autoload
> (defun eww-browse-url (url &optional new-window)
> - (cond (new-window
> + (cond ((or browse-url-new-window-flagnew-window)
I don't think that's appropriate. browse-url says whether to open a new
window when you're opening an URL outside of a browser, not what the
browser should do once you've opened it.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Minor Patch: Respect browse-url-new-window-flag
2014-12-01 4:04 ` Lars Magne Ingebrigtsen
@ 2014-12-01 17:41 ` T.V Raman
0 siblings, 0 replies; 3+ messages in thread
From: T.V Raman @ 2014-12-01 17:41 UTC (permalink / raw)
To: larsi; +Cc: tv.raman.tv, emacs-devel, raman
That's an "interesting" read.
I'm probably more the exception than the rule in that I browse
the Web more in Emacs than outside it.
For my particular use case, I'll go ahead and solve the problem
via an advice.
Lars Magne Ingebrigtsen writes:
> "T. V. Raman" <raman@google.com> writes:
>
> > Here is a simple patch to eww.el to respect option
> > browse-url-new-window-flag
> > git diff master -- eww.el
> > diff --git a/lisp/net/eww.el b/lisp/net/eww.el
> > index 2059b5e..4613b4c 100644
> > --- a/lisp/net/eww.el
> > +++ b/lisp/net/eww.el
> > @@ -680,7 +680,7 @@ the like."
> >
> > ;;;###autoload
> > (defun eww-browse-url (url &optional new-window)
> > - (cond (new-window
> > + (cond ((or browse-url-new-window-flagnew-window)
>
> I don't think that's appropriate. browse-url says whether to open a new
> window when you're opening an URL outside of a browser, not what the
> browser should do once you've opened it.
>
> --
> (domestic pets only, the antidote for overdose, milk.)
> bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-01 17:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-01 3:08 Minor Patch: Respect browse-url-new-window-flag T. V. Raman
2014-12-01 4:04 ` Lars Magne Ingebrigtsen
2014-12-01 17:41 ` T.V Raman
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.