From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "T. V. Raman" Newsgroups: gmane.emacs.devel Subject: Trunk: eww: loses title Date: Thu, 13 Nov 2014 20:01:22 -0800 Message-ID: <21605.32402.766573.451646@gargle.gargle.HOWL> Reply-To: tv.raman.tv@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1415937721 5337 80.91.229.3 (14 Nov 2014 04:02:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 14 Nov 2014 04:02:01 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 14 05:01:52 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xp851-0007jV-Hp for ged-emacs-devel@m.gmane.org; Fri, 14 Nov 2014 05:01:51 +0100 Original-Received: from localhost ([::1]:34801 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xp851-00041q-86 for ged-emacs-devel@m.gmane.org; Thu, 13 Nov 2014 23:01:51 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xp84p-00041i-VF for emacs-devel@gnu.org; Thu, 13 Nov 2014 23:01:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xp84g-0008Hy-Ux for emacs-devel@gnu.org; Thu, 13 Nov 2014 23:01:39 -0500 Original-Received: from mail-pd0-x236.google.com ([2607:f8b0:400e:c02::236]:58415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xp84g-0008Hs-LH for emacs-devel@gnu.org; Thu, 13 Nov 2014 23:01:30 -0500 Original-Received: by mail-pd0-f182.google.com with SMTP id g10so758976pdj.27 for ; Thu, 13 Nov 2014 20:01:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:mime-version:content-type:content-transfer-encoding:message-id :date:to:subject:reply-to; bh=aVTjos2MyAeY4RMdT6cdi0gIKXMJOEd2IUS3Nx0Z8Bc=; b=dGMh2Z7w05dHRMzu83r+IkelDQmp4nKAjB4hiUj0cX90xlZ8YsM8yHSKgIX2BdY+bS m/Aq/76YVMKMUuutwYMaLHjaFieTrGvINfHsquNrknbDRd97fAZ2Ej7im8ee+Tb2PoPc Ai9culbyG3xDrBhnVA6nCFxg3tYaC8n2tORt7hr9qhgbAESA9ZtefSVhnWpDPT0+dMKr 7dcWLslEwz63ppJjqDuBjVeQw0MFtKdvyeDluiwgdv2ZoshE46nfCHsuIqQ3Adi8jpw1 UTuhW4BO5eOowQvYugG8uY77yGfGYoJbkbFYkC1ZMFLcQpRSrNLGHoNLBQMC8/aah2tq a8Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:subject:reply-to; bh=aVTjos2MyAeY4RMdT6cdi0gIKXMJOEd2IUS3Nx0Z8Bc=; b=gP0q5frFlVDmH2uvue7UMzK05q5rsLprtwtz+h0HjKRS2JBlgeIhaWObWFYY1932o4 IAj3ifYBo/ikmH5ldg3KKFIxTwVOYDd7csaewHKLOdfwt0K3G1361qIqFaH6uBROMo+Z tLX+KuIdDSx/bFKA5TaPM/Mvjoj1JZQBSLwDR2Uhsns9tcpeZCCy7dKD1pk9E7f+Fz7p w3cfkSjALKhzhFc/K7nZzbdoSmxf/SwyGxP+aH6YrVlsxPp1VcNcrLRNkpxoulQyJtSd 6B5bwJzCowzPaSQh9z2ESUW2DKHNAZNA4jpUgHc5arJG0m4Wi2FNuHUXVVSD+9gPXeeV 1Osw== X-Gm-Message-State: ALoCoQnryEKokbhurtGi5lmkhdxLfMHkQQURlc9qdVsepJvSTUvYG8mTsI/DoYGRJ6RQiYQedTpE X-Received: by 10.68.215.67 with SMTP id og3mr7053065pbc.117.1415937689482; Thu, 13 Nov 2014 20:01:29 -0800 (PST) Original-Received: from labrador.google.com ([98.248.57.195]) by mx.google.com with ESMTPSA id x10sm26210625pdr.11.2014.11.13.20.01.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Nov 2014 20:01:28 -0800 (PST) X-Google-Original-From: "T. V. Raman" X-Mailer: VM 8.1.1 under 25.0.50.1 (i686-pc-linux-gnu) x-attribution: tvr X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c02::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:177027 Archived-At: eww-render in trunk appears to incorrectly set title to url. Here's the function, with the suspect line commented out: With it commented out title does get set correctly. (defun eww-render (status url &optional point buffer) (let ((redirect (plist-get status :redirect))) (when redirect (setq url redirect))) (let* ((headers (eww-parse-headers)) (content-type (mail-header-parse-content-type (or (cdr (assoc "content-type" headers)) "text/plain"))) (charset (intern (downcase (or (cdr (assq 'charset (cdr content-type))) (eww-detect-charset (equal (car content-type) "text/html")) "utf8")))) (data-buffer (current-buffer))) (unwind-protect (progn (plist-put eww-data :title "") (cond ((and eww-use-external-browser-for-content-type (string-match-p eww-use-external-browser-for-content-type (car content-type))) (eww-browse-with-external-browser url)) ((equal (car content-type) "text/html") (eww-display-html charset url nil point buffer)) ((equal (car content-type) "application/pdf") (eww-display-pdf)) ((string-match-p "\\`image/" (car content-type)) (eww-display-image buffer) (eww-update-header-line-format)) (t (eww-display-raw buffer) (eww-update-header-line-format))) ; this line looks suspect. ;(plist-put eww-data :title url) (setq eww-history-position 0) (run-hooks 'eww-after-render-hook)) (kill-buffer data-buffer))))