Re: Advice Required

["Gian Uberto Lauri" <saint@eng.it>]

Stefan Monnier writes:
 > > Wonderful.  This does not require an external device and the error
 > > message in the minibuffer that you get when you run the command from
 > > within emacs is negligible.
 > 
 > I don't know what error message you're referring to.

No catch for tag: exit, 1

;; I have (trow 'exit 1) in the hook

 > > (defun ediff-after (foobar)
 > >   (interactive)
 > >   (error "pingpipe"))
 > > (advice-add 'ediff-quit  :after #'ediff-after)
 > 
 > > but when I tried this a second time it did not work, complaining about
 > > wrong number of arguments. What did I wrong?
 > 
 > I don't know.  Can you show us the backtrace?

Debugger stack:

Debugger entered--Lisp error: (wrong-number-of-arguments #[(reverse-default-keep-variants) "\306\x18\307\b!\206\f\0\310\311	\")\210p\312 \313\x1a^[\x1c\314\315\316\r\203.\0\317\r!\203.\0\320\317\r!!\203.\0\321\202/\0\322\"!\203B\0\323\322!\210\fq\210\324\x0e\x17!\202M\0\325\v!\210\326\v!\210\323\322!+\207" [meta-buf-p this-command minibuffer-auto-raise ctl-frm ctl-buf ediff-meta-buffer nil ediff-in-control-buffer-p error "%S: This command runs in Ediff Control Buffer only!" selected-frame t y-or-n-p format "Quit this Ediff session%s? " get-buffer buffer-name " & show containing session group" "" message ediff-really-quit select-frame raise-frame reverse-default-keep-variants] 6 ("/usr/local/share/emacs/24.4/lisp/vc/ediff-util.elc" . 64550) "P"] 0)
  #[(reverse-default-keep-variants) "\306\x18\307\b!\206\f\0\310\311	\")\210p\312 \313\x1a^[\x1c\314\315\316\r\203.\0\317\r!\203.\0\320\317\r!!\203.\0\321\202/\0\322\"!\203B\0\323\322!\210\fq\210\324\x0e\x17!\202M\0\325\v!\210\326\v!\210\323\322!+\207" [meta-buf-p this-command minibuffer-auto-raise ctl-frm ctl-buf ediff-meta-buffer nil ediff-in-control-buffer-p error "%S: This command runs in Ediff Control Buffer only!" selected-frame t y-or-n-p format "Quit this Ediff session%s? " get-buffer buffer-name " & show containing session group" "" message ediff-really-quit select-frame raise-frame reverse-default-keep-variants] 6 ("/usr/local/share/emacs/24.4/lisp/vc/ediff-util.elc" . 64550) "P"]()
  apply(#[(reverse-default-keep-variants) "\306\x18\307\b!\206\f\0\310\311	\")\210p\312 \313\x1a^[\x1c\314\315\316\r\203.\0\317\r!\203.\0\320\317\r!!\203.\0\321\202/\0\322\"!\203B\0\323\322!\210\fq\210\324\x0e\x17!\202M\0\325\v!\210\326\v!\210\323\322!+\207" [meta-buf-p this-command minibuffer-auto-raise ctl-frm ctl-buf ediff-meta-buffer nil ediff-in-control-buffer-p error "%S: This command runs in Ediff Control Buffer only!" selected-frame t y-or-n-p format "Quit this Ediff session%s? " get-buffer buffer-name " & show containing session group" "" message ediff-really-quit select-frame raise-frame reverse-default-keep-variants] 6 ("/usr/local/share/emacs/24.4/lisp/vc/ediff-util.elc" . 64550) "P"] nil)
  ediff-quit()
  call-interactively(ediff-quit nil nil)
  command-execute(ediff-quit)

Error message

Wrong number of arguments: #[(reverse-default-keep-variants) "Æ\x18Ç\b!†\f\0ÈÉ	\")ˆpÊ Ë\x1a^[\x1cÌÍÎ\rƒ.\0Ï\r!ƒ.\0ÐÏ\r!!ƒ.\0Ñ‚/\0Ò\"!ƒB\0ÓÒ!ˆ\fqˆÔ\x0e\x17!‚M\0Õ\v!ˆÖ\v!ˆÓÒ!+‡" [meta-buf-p this-command minibuffer-auto-raise ctl-frm ctl-buf ediff-meta-buffer nil ediff-in-control-buffer-p error "%S: This command runs in Ediff Control Buffer only!" ...] 6 ("/usr/local/share/emacs/24.4/lisp/vc/ediff-util.elc" . 64550) "P"], 0
Mark set

Removing the advices restores the correct behaviour.

-- 
 /\           ___                                    Ubuntu: ancient
/___/\_|_|\_|__|___Gian Uberto Lauri_____               African word
  //--\| | \|  |   Integralista GNUslamico            meaning "I can
\/                 coltivatore diretto di software       not install
     già sistemista a tempo (altrui) perso...                Debian"

Warning: gnome-config-daemon considered more dangerous than GOTO