From: Nick Dokos <nicholas.dokos@hp.com>
To: carsten.dominik@gmail.com
Cc: mh-e-users@lists.sourceforge.net, emacs-orgmode@gnu.org
Subject: Bug fix: org-mhe links don't work with mairix
Date: Wed, 14 May 2008 23:31:29 -0400 [thread overview]
Message-ID: <21579.1210822289@gamaville.dokosmarshall.org> (raw)
Hi Carsten,
Pete Phillips had run into a problem back in November 2007 with mhe
links to emails not working (he was using mairix as the mh search
method). I just sent a patch to Bill Wohler about the mh-e part (and
copied both the mh-e list and the org list: the problem is described in
more detail there). Here is the org-mode patch.
I've tested the patch both with the default "pick" search in mh-e and
with "mairix" search. Pete Phillips also did some testing (I believe
with mairix) - thanks Pete!
I would feel better if there had been some swish++/namazu/etc testing as
well, but it's unlikely that I'll find the time in the foreseeable
future. In particular, I'm not sure where the angle brackets are needed:
it's clear they are needed for the pick search and I've found out that
they are *not* needed for mairix search, but if swish++ needs them, that
would complicate things. The patch assumes that they are not needed for
any search method, other than pick. If somebody on the list could try it
and report success/failure, I, for one, would appreciate it very much.
If it looks OK to you, could you please apply it?
Thanks very much,
Nick
--- a/lisp/org-mhe.el
+++ b/lisp/org-mhe.el
@@ -194,16 +194,16 @@ folders."
(mh-find-path)
(if (not article)
(mh-visit-folder (mh-normalize-folder-name folder))
- (setq article (org-add-angle-brackets article))
(mh-search-choose)
(if (equal mh-searcher 'pick)
(progn
+ (setq article (org-add-angle-brackets article))
(mh-search folder (list "--message-id" article))
(when (and org-mhe-search-all-folders
(not (org-mhe-get-message-real-folder)))
(kill-this-buffer)
(mh-search "+" (list "--message-id" article))))
- (mh-search "+" article))
+ (mh-search "+" (funcall mh-search-regexp-builder (list (cons 'message-id article)))))
(if (org-mhe-get-message-real-folder)
(mh-show-msg 1)
(kill-this-buffer)
next reply other threads:[~2008-05-15 3:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 3:31 Nick Dokos [this message]
2008-05-16 14:27 ` Bug fix: org-mhe links don't work with mairix Carsten Dominik
2008-05-17 15:15 ` Thomas Baumann
2008-05-17 20:23 ` Nick Dokos
2008-05-17 21:17 ` Bill Wohler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21579.1210822289@gamaville.dokosmarshall.org \
--to=nicholas.dokos@hp.com \
--cc=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mh-e-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.