From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#58839: [Patch] Re: bug#58839: 29.0.50; project-kill-buffer fails when Eglot is running Date: Fri, 28 Oct 2022 21:40:58 +0300 Message-ID: <213f3549-de4e-25a7-5e27-d13893e557bc@yandex.ru> References: <87sfj8umwb.fsf@posteo.net> <87edur3lil.fsf@posteo.net> <87a65f3j40.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2919"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Cc: Manuel Uberti , 58839@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 28 20:42:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooUJ9-0000cC-Kg for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Oct 2022 20:42:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooUIv-0004Gi-15; Fri, 28 Oct 2022 14:42:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooUIt-0004GV-7Y for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 14:42:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ooUIs-0005Wu-TZ for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 14:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ooUIs-0000zk-Fa for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 14:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Oct 2022 18:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58839 X-GNU-PR-Package: emacs Original-Received: via spool by 58839-submit@debbugs.gnu.org id=B58839.16669824743766 (code B ref 58839); Fri, 28 Oct 2022 18:42:02 +0000 Original-Received: (at 58839) by debbugs.gnu.org; 28 Oct 2022 18:41:14 +0000 Original-Received: from localhost ([127.0.0.1]:34278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooUI4-0000ye-3E for submit@debbugs.gnu.org; Fri, 28 Oct 2022 14:41:14 -0400 Original-Received: from mail-wr1-f47.google.com ([209.85.221.47]:44727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooUHy-0000xy-Nl for 58839@debbugs.gnu.org; Fri, 28 Oct 2022 14:41:10 -0400 Original-Received: by mail-wr1-f47.google.com with SMTP id v1so7701010wrt.11 for <58839@debbugs.gnu.org>; Fri, 28 Oct 2022 11:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=ljY+AsPqvYxkR7JuJNSPTaTitINx+vL34JWr9iTBxiE=; b=TiyyvASyt9GJQxtGNpho1gHkttzBTIXg9DfyguQzXUL3hCtD2H5OJ9nayUdNYCXEIS 0N+J0Ywg/l2U0+055yqpkmwcMevVOxU+jMk0118aq8ysoAIzGxWT0ZztNI6m7T+JyGH9 aTSFVZ73UPw11r/ziYnY4xkAcJLzAxKCGWYey7vL1TgiYkiwfXX5epkGbC1Ug3kGcat6 Zbq45JBAMrNvrKwt+okaye0O5mIViqrHU12Ns7lNAkViytyHYsg0BLhJWK0qV5+dwXhk POh1bHGjtBHxpAgAAHtN/RY8HXV0JJCk2b4jk5WNePxturwaEBvtPP3kIZbBf6Q3VbPY L6+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ljY+AsPqvYxkR7JuJNSPTaTitINx+vL34JWr9iTBxiE=; b=0GK6XpopSG4A4twjkPTlh98ydd+2Ia+kHtI9+Ah6MrqaSKFMmN10/kebl8IkzeJKSO vuqD8Ic6IBbIlR+CyqwNE1VbJs7d/cBsDz2NCQPoyqkjDMh9WTJklLDNh62D3PzWhx8V zosrma5k8tkqhOSoWy9kxWJZLZitcH79Uv2bRRiepCycKVWDM1YBd6qnZwzGh21SxaRp yfyV4XkwdG8w4cdbkmPkl2lIkhqs7p6OlDPpsm9s8SSthl7H0dRR8iyvEMU9mjv3+fHa QzhIP6yZrYnbHjgmrT7b4a8aJP1asUYNVpmWAa6EWw+7X7F9wVACTtNNyV/6YvU5Gmi9 OzXQ== X-Gm-Message-State: ACrzQf2h62IUB2LgyGyHnnJRfF4nYtndKl4zC7iKxs24N2R43wNzKG7G tIDoqLiFdVLY11W2Y5D63Vs= X-Google-Smtp-Source: AMsMyM4mXGPwOUW4AO2m3RJVj88LZYIj5y5IL/L7rdyeG3h6FNmJoWvn/pY6gJUSZSaXeOsC4IDHdQ== X-Received: by 2002:adf:f883:0:b0:236:a6a3:d6ac with SMTP id u3-20020adff883000000b00236a6a3d6acmr448698wrp.538.1666982460731; Fri, 28 Oct 2022 11:41:00 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id t14-20020a5d690e000000b00225307f43fbsm4034921wru.44.2022.10.28.11.40.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Oct 2022 11:41:00 -0700 (PDT) Content-Language: en-US In-Reply-To: <87a65f3j40.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246447 Archived-At: On 28.10.2022 21:20, Philip Kaludercic wrote: > Dmitry Gutov writes: > >> On 28.10.2022 20:28, Philip Kaludercic wrote: >>> I still don't agree that this is the right interpretation of the issue >>> or solution, but wouldn't it be better to add this to >>> `project-kill-buffer-conditions'? >> I don't mind a new variable specifically, but >> kill-buffer-query-functions seems to serve this purpose just fine. >> >> And no extra "coupling between two packages" will be added. > How would you imagine it being used in this case? (defun eglot-before-kill-special () (eglot-shutdown) t) ;; somewhere inside that special buffer's setup: (add-hook 'kill-buffer-query-functions #'eglot-before-kill-special nil t) Or use kill-buffer-hook, no need to watch the return value then. In either case, it will also cover the scenario of the user killing the background buffer some other way.