Messages from autogen

Messages from autogen

[Angelo Graziosi]

I don't remember having noticed this before but in today build from master I see this, now, from autogen.sh:

$ ./autogen.sh
Checking whether you have the necessary tools...
(Read INSTALL.REPO for more details on building Emacs)
Checking for autoconf (need at least version 2.65) ... ok
Your system has the required tools.
Running 'autoreconf -fi -I m4' ...
./autogen.sh: riga 275: git: comando non trovato
./autogen.sh: riga 275: git: comando non trovato
./autogen.sh: riga 275: git: comando non trovato
./autogen.sh: riga 275: git: comando non trovato
./autogen.sh: riga 275: git: comando non trovato
./autogen.sh: riga 275: git: comando non trovato
You can now run './configure'.

(comando non trovato == command not found)

Those messages seems harmless because 'configure' is created and seems to work.

In any case I don't see the reason to have a git package installed. To build I use this package:

http://git.savannah.gnu.org/cgit/emacs.git/snapshot/emacs-master.tar.gz

which should be just a clean source snapshot and it should not have the need of git...

In programming, one should not have more than strictly needed!

Angelo

Re: Messages from autogen

[John Wiegley]

>>>>> "AG" == Angelo Graziosi <angelo.g0@libero.it> writes:

AG> In any case I don't see the reason to have a git package installed. To
AG> build I use this package:

At the very least, the autogen script should check whether the 'git' command
is available before trying to use it.  It isn't necessary.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Re: Messages from autogen

[Eli Zaretskii]

> Date: Tue, 5 Sep 2017 12:44:09 +0200 (CEST)
> From: Angelo Graziosi <angelo.g0@libero.it>
> 
> I don't remember having noticed this before but in today build from master I see this, now, from autogen.sh:
> 
> $ ./autogen.sh
> Checking whether you have the necessary tools...
> (Read INSTALL.REPO for more details on building Emacs)
> Checking for autoconf (need at least version 2.65) ... ok
> Your system has the required tools.
> Running 'autoreconf -fi -I m4' ...
> ./autogen.sh: riga 275: git: comando non trovato
> ./autogen.sh: riga 275: git: comando non trovato
> ./autogen.sh: riga 275: git: comando non trovato
> ./autogen.sh: riga 275: git: comando non trovato
> ./autogen.sh: riga 275: git: comando non trovato
> ./autogen.sh: riga 275: git: comando non trovato
> You can now run './configure'.
> 
> (comando non trovato == command not found)

It's a feature:

  http://lists.gnu.org/archive/html/emacs-devel/2017-08/msg00056.html

Re: Messages from autogen

[Angelo Graziosi]

> Il 5 settembre 2017 alle 16.55 Eli Zaretskii <eliz@gnu.org> ha scritto:
> 
> 
> > Date: Tue, 5 Sep 2017 12:44:09 +0200 (CEST)
> > From: Angelo Graziosi <angelo.g0@libero.it>
> > 
> > I don't remember having noticed this before but in today build from master I see this, now, from autogen.sh:
> > 
> > $ ./autogen.sh
> > Checking whether you have the necessary tools...
> > (Read INSTALL.REPO for more details on building Emacs)
> > Checking for autoconf (need at least version 2.65) ... ok
> > Your system has the required tools.
> > Running 'autoreconf -fi -I m4' ...
> > ./autogen.sh: riga 275: git: comando non trovato
> > ./autogen.sh: riga 275: git: comando non trovato
> > ./autogen.sh: riga 275: git: comando non trovato
> > ./autogen.sh: riga 275: git: comando non trovato
> > ./autogen.sh: riga 275: git: comando non trovato
> > ./autogen.sh: riga 275: git: comando non trovato
> > You can now run './configure'.
> > 
> > (comando non trovato == command not found)
> 
> It's a feature:
> 
>   http://lists.gnu.org/archive/html/emacs-devel/2017-08/msg00056.html

With all due respect, I *can* build and use Emacs master without 'git' installed! So that messages are wrong. As stated by John W., the script should test if 'git' exists before to use it..

Re: Messages from autogen

[Eli Zaretskii]

> Date: Tue, 5 Sep 2017 17:26:27 +0200 (CEST)
> From: Angelo Graziosi <angelo.g0@libero.it>
> Cc: emacs-devel@gnu.org
> 
> > It's a feature:
> > 
> >   http://lists.gnu.org/archive/html/emacs-devel/2017-08/msg00056.html
> 
> With all due respect, I *can* build and use Emacs master without 'git' installed! So that messages are wrong. As stated by John W., the script should test if 'git' exists before to use it..

Don't kill the messenger!  I just pointed you (and others) to the
description of the change by its author, in the hope that this will
facilitate finding a solution.

Re: Messages from autogen

[John Wiegley]

>>>>> "EZ" == Eli Zaretskii <eliz@gnu.org> writes:

EZ> Don't kill the messenger! I just pointed you (and others) to the
EZ> description of the change by its author, in the hope that this will
EZ> facilitate finding a solution.

I reach down and apply a defibrillator to the messenger, bringing him back to
life. Close call.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Re: Messages from autogen

[Eli Zaretskii]

> From: John Wiegley <jwiegley@gmail.com>
> Cc: Angelo Graziosi <angelo.g0@libero.it>,  emacs-devel@gnu.org
> Date: Tue, 05 Sep 2017 17:24:06 +0100
> 
> >>>>> "EZ" == Eli Zaretskii <eliz@gnu.org> writes:
> 
> EZ> Don't kill the messenger! I just pointed you (and others) to the
> EZ> description of the change by its author, in the hope that this will
> EZ> facilitate finding a solution.
> 
> I reach down and apply a defibrillator to the messenger, bringing him back to
> life. Close call.

Thanks, I'm breathing again.

Btw, how come Angelo had the .git directory in that tree?  Was it
included in the snapshot prepared by savannah?  If so, that might be
the bug to fix.

Re: Messages from autogen

[Angelo Graziosi]

> Il 6 settembre 2017 alle 18.15 Eli Zaretskii <eliz@gnu.org> ha scritto:
> 
> 
> > From: John Wiegley <jwiegley@gmail.com>
> > Cc: Angelo Graziosi <angelo.g0@libero.it>,  emacs-devel@gnu.org
> > Date: Tue, 05 Sep 2017 17:24:06 +0100
> > 
> > >>>>> "EZ" == Eli Zaretskii <eliz@gnu.org> writes:
> > 
> > EZ> Don't kill the messenger! I just pointed you (and others) to the
> > EZ> description of the change by its author, in the hope that this will
> > EZ> facilitate finding a solution.
> > 
> > I reach down and apply a defibrillator to the messenger, bringing him back to
> > life. Close call.
> 
> Thanks, I'm breathing again.
> 
> Btw, how come Angelo had the .git directory in that tree?  Was it

but I haven't a .git directory!

The snapshot (http://git.savannah.gnu.org/cgit/emacs.git/snapshot/emacs-master.tar.gz), when unpacked, only contains these .git* files (find emacs-master -name ".git*"):

.gitattributes
.gitignore
.gitlab-ci.yml

and even removing them, autogen.sh prints those messages...

> included in the snapshot prepared by savannah?  If so, that might be
> the bug to fix.

hmm.. as stated above, I doubt..

Re: Messages from autogen

[Paul Eggert]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

Angelo Graziosi wrote:
> but I haven't a .git directory!

Yes, in that case the intent was to skip the 'git' stuff by default. I never 
test in an environment that lacks 'git' so I didn't run into the problem when 
hacking on autoconf.sh.

I installed the attached, which should fix the problem. Please give it a try 
(from the previous paragraph one can easily see that I have not tested that the 
patch actually fixes the problem :-).

[-- Attachment #2: 0001-autogen.sh-omit-bogus-chatter-if-no-.git.patch --]
[-- Type: text/x-patch, Size: 1482 bytes --]

From 1836e5616699d553eb73b66d1c77135cf8a8e1e9 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Thu, 7 Sep 2017 00:10:05 -0700
Subject: [PATCH] autogen.sh: omit bogus chatter if no .git

Problem reported by Angelo Graziosi in:
http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00045.html
* autogen.sh (git_config): Do not execut 'git' if $do_git fails.
---
 autogen.sh | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/autogen.sh b/autogen.sh
index 0d00d56..b3c5f48 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -269,23 +269,23 @@ fi
 
 git_config ()
 {
+    $do_git || return
+
     name=$1
     value=$2
 
     ovalue=`git config --get "$name"` && test "$ovalue" = "$value" || {
-	if $do_git; then
-	    if $git_was_ok; then
-		echo 'Configuring local git repository...'
-		case $cp_options in
-		  --backup=*)
-		    config=$git_common_dir/config
-		    cp $cp_options --force -- "$config" "$config" || exit;;
-		esac
-	    fi
-	    echo "git config $name '$value'"
-	    git config "$name" "$value" || exit
-	fi
-	git_was_ok=false
+       if $git_was_ok; then
+	   echo 'Configuring local git repository...'
+	   case $cp_options in
+	       --backup=*)
+		   config=$git_common_dir/config
+		   cp $cp_options --force -- "$config" "$config" || exit;;
+	   esac
+       fi
+       echo "git config $name '$value'"
+       git config "$name" "$value" || exit
+       git_was_ok=false
     }
 }
 
-- 
2.7.4

Re: Messages from autogen

[Angelo Graziosi]

> Il 7 settembre 2017 alle 9.17 Paul Eggert <eggert@cs.ucla.edu> ha scritto:
> 
> 
> Angelo Graziosi wrote:
> > but I haven't a .git directory!
> 
> Yes, in that case the intent was to skip the 'git' stuff by default. I never 
> test in an environment that lacks 'git' so I didn't run into the problem when 
> hacking on autoconf.sh.
> 
> I installed the attached, which should fix the problem. Please give it a try 

Yes, it seems to work.. thanks.

  Angelo


> (from the previous paragraph one can easily see that I have not tested that the 
> patch actually fixes the problem :-).