From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#63867: 29.0.91; typescript-ts-mode does not highlight function signature overloads Date: Sat, 3 Jun 2023 15:01:28 +0300 Message-ID: <213224c6-5d92-f16c-b542-a827935917b3@gutov.dev> References: <83y1l098sy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3416"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Cc: 63867-done@debbugs.gnu.org To: Eli Zaretskii , Jimmy Yuen Ho Wong , Jostein Kjonigsen , Theodor Thornhill , Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 03 14:02:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5Pxg-0000e1-1W for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Jun 2023 14:02:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5PxM-0007S9-8V; Sat, 03 Jun 2023 08:02:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5PxK-0007R9-Jw for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 08:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5PxK-000648-AT for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 08:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q5PxK-0008Pl-6C for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 08:02:02 -0400 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Jun 2023 12:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 63867 X-GNU-PR-Package: emacs Mail-Followup-To: 63867@debbugs.gnu.org, dmitry@gutov.dev, wyuenho@gmail.com Original-Received: via spool by 63867-done@debbugs.gnu.org id=D63867.168579371232323 (code D ref 63867); Sat, 03 Jun 2023 12:02:01 +0000 Original-Received: (at 63867-done) by debbugs.gnu.org; 3 Jun 2023 12:01:52 +0000 Original-Received: from localhost ([127.0.0.1]:41736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5Pwz-0008P7-Tc for submit@debbugs.gnu.org; Sat, 03 Jun 2023 08:01:52 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:56609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5Pww-0008Oj-Ow for 63867-done@debbugs.gnu.org; Sat, 03 Jun 2023 08:01:40 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 8E6D05C006E; Sat, 3 Jun 2023 08:01:33 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 03 Jun 2023 08:01:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1685793693; x=1685880093; bh=sJ9s2II1ByRlupkoBUfFUIdDdKjFco2vEWO 1JoQ5U6Y=; b=OPL3aG3RHfuF6D5Gps6O/5Gf8kKAjUzjYXqxHf+ZErC/xYIzUxd ljNk+ptISAX8JuMuS3f44q1LvdCnPmRKWtFj43o1yPgL+B+eJXcsql1USYKGLv9C CSwcyq3k3PsHTHkXKxjw/d7moML9Dl5Mjb6pinIYox9MCABYxU5ydCFZnGpgH/zA zrQ4p8xnSdNQQlfO4X+j055puefLR+/qW+3FZI93QnIb6yLzZKLqhFb8OamehpUv VqyU8GUmMgHJqKFWrUIjpYhLAPKe+o7Btd49GJeWH0D5SFTK3IA/BKScFbrK15P5 +aeC6ICq27M8GuBEMid22rsfvfZnTltJlnw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1685793693; x=1685880093; bh=sJ9s2II1ByRlupkoBUfFUIdDdKjFco2vEWO 1JoQ5U6Y=; b=eRWtneA+PZFtlBrV9VZpza/+OmqWMnsx6yfonwsjZnkmymrsxP4 yeYOm18eKDQOIZ3l9uqCG9U3UJSYb4ScOPiX9wmxUNk8vKHdDjEkHbEQQqMVTT+D Mc6Gk0O4r0JfHy+BxXyriSNfNk1b5tGM0ytkFJQbmNWZZJisUFWPTlxtpOdCYnaw XbwRE5JntpNuYas+QFC8GiQEDmL5v/Y1WN7+93ICFKc5icq/MLetgW8m+hIcohKs MsJHvEjSoA2fruVu7MrOcyAt3nQRx8o1PUVm4/mpRuA0aalqdrT0bsa71EIY/kYf 77CwypD5tMLXR5CBKtXqkGZalmQ9KMe6GpA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeelhedggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 3 Jun 2023 08:01:31 -0400 (EDT) Content-Language: en-US In-Reply-To: <83y1l098sy.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262824 Archived-At: On 03/06/2023 12:47, Eli Zaretskii wrote: >> From: Jimmy Yuen Ho Wong >> Date: Sat, 03 Jun 2023 10:37:07 +0100 >> >> >> Reproduction: >> >> 1. C-x C-f test.ts >> 2. Insert: >> >> ```typescript >> function fn():void; >> function fn(arg1?:number, arg2?:string):void { >> } >> ``` >> >> 3. Observe the fn in the overload signature isn't highlighted as a >> function name >> >> Expectation: >> >> Function signature overloads should highlight the function names. > Thanks. > > Guys, could you please look into fixing this? I've pushed a fix to emacs-29, rev 583ba1db7ee.