From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Stephan Stahl" Newsgroups: gmane.emacs.devel Subject: Re: M-x compile should tell its status (a little bit better).. Date: Mon, 12 Jul 2004 18:16:18 +0200 (CEST) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <20892.217.194.34.123.1089648978.squirrel@wwws.franken.de> References: <24608.217.194.34.123.1082528157.squirrel@wwws.franken.de> <40895A13.4020300@yahoo.com><87oepiqsb9.fsf@eos.franken.de> <408E8DBB.9050409@yahoo.com> <87hdsfl3mx.fsf@eos.franken.de> <61133.217.194.34.123.1089623439.squirrel@wwws.franken.de> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 X-Trace: sea.gmane.org 1089649192 28624 80.91.224.253 (12 Jul 2004 16:19:52 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 12 Jul 2004 16:19:52 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Jul 12 18:19:42 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Bk3Wo-0005wi-00 for ; Mon, 12 Jul 2004 18:19:42 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1Bk3Wn-000636-00 for ; Mon, 12 Jul 2004 18:19:41 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bk3Z7-0003AZ-Mn for emacs-devel@quimby.gnus.org; Mon, 12 Jul 2004 12:22:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Bk3Z5-0003AU-1P for emacs-devel@gnu.org; Mon, 12 Jul 2004 12:22:03 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Bk3Z2-0003A5-U4 for emacs-devel@gnu.org; Mon, 12 Jul 2004 12:22:02 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bk3Z2-0003A0-Q7 for emacs-devel@gnu.org; Mon, 12 Jul 2004 12:22:00 -0400 Original-Received: from [193.175.24.27] (helo=ilsa.franken.de) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1Bk3WD-0006an-O2; Mon, 12 Jul 2004 12:19:06 -0400 Original-Received: from wwws.franken.de (mail-n.franken.de [193.175.24.27]) by ilsa.franken.de (Postfix) with SMTP id 8596F245F5; Mon, 12 Jul 2004 18:16:18 +0200 (CEST) Original-Received: from 217.194.34.123 (SquirrelMail authenticated user eos) by wwws.franken.de with HTTP; Mon, 12 Jul 2004 18:16:18 +0200 (CEST) In-Reply-To: <61133.217.194.34.123.1089623439.squirrel@wwws.franken.de> Original-To: rms@gnu.org User-Agent: SquirrelMail/1.4.0 X-Priority: 3 Importance: Normal X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25620 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25620 Hi Richard. (I've CC'ed emacs-devel again because of this possible bug..) I said: > Here is a new patch. With the funtion you suggested it is much simpler. > diff -c buff-menu.el.\~1.66.\~ buff-menu.el > *** buff-menu.el.\~1.66.\~ Mon Jul 12 11:01:15 2004 > --- buff-menu.el Mon Jul 12 11:08:58 2004 > *************** > *** 613,619 **** > " " > (Buffer-menu-make-sort-button "Mode" 4) mode-end > (Buffer-menu-make-sort-button "File" 5) "\n")) > ! list desired-point name file) > (when Buffer-menu-use-header-line > (let ((pos 0)) > ;; Turn spaces in the header into stretch specs so they work > --- 613,619 ---- > " " > (Buffer-menu-make-sort-button "Mode" 4) mode-end > (Buffer-menu-make-sort-button "File" 5) "\n")) > ! list desired-point name mode file) > (when Buffer-menu-use-header-line > (let ((pos 0)) > ;; Turn spaces in the header into stretch specs so they work > *************** > *** 639,644 **** > --- 639,647 ---- > (lambda (buffer) > (with-current-buffer buffer > (setq name (buffer-name) > + mode (concat mode-name > + (if mode-line-process > + (format-mode-line mode-line-process))) > file (buffer-file-name)) > (cond > ;; Don't mention internal buffers. > *************** > *** 665,671 **** > ?% ? ) > ;; Identify modified buffers. > (if (buffer-modified-p) ?* ? )) > ! name (buffer-size) mode-name file))))) > (buffer-list)))) > (dolist (buffer > (if Buffer-menu-sort-column > --- 668,674 ---- > ?% ? ) > ;; Identify modified buffers. > (if (buffer-modified-p) ?* ? )) > ! name (buffer-size) mode file))))) > (buffer-list)))) > (dolist (buffer > (if Buffer-menu-sort-column It does however not work correctly.. I suspect format-mode-line to be guilty but have not yet looked at the c code.. format-mode-line returns different things depending on the buffer it was called from. With this example the bug can be seen to. emacs -q --no-site-init M-x shell M-; (with-current-buffer (get-buffer "*shell*") (concat mode-name (if mode-line-process (format-mode-line mode-line-process)))) => "Shell:run" C-x C-b (you should be in *scratch* now) M-; (with-current-buffer (get-buffer "*shell*") (concat mode-name (if mode-line-process (format-mode-line mode-line-process)))) => "Shell:no process" Maybe someone can help me with this?? Stephan -- Stephan Stahl