From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: kifer@cs.sunysb.edu (Michael Kifer) Newsgroups: gmane.emacs.devel Subject: Re: Ediff regression Date: Thu, 14 Jun 2007 13:43:03 -0400 Message-ID: <20835.1181842983@cs.sunysb.edu> References: NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1181842994 23368 80.91.229.12 (14 Jun 2007 17:43:14 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 14 Jun 2007 17:43:14 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 14 19:43:13 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HytLi-0000aE-FC for ged-emacs-devel@m.gmane.org; Thu, 14 Jun 2007 19:43:10 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HytLh-0002nX-TN for ged-emacs-devel@m.gmane.org; Thu, 14 Jun 2007 13:43:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HytLe-0002nK-Vy for emacs-devel@gnu.org; Thu, 14 Jun 2007 13:43:07 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HytLb-0002mv-GZ for emacs-devel@gnu.org; Thu, 14 Jun 2007 13:43:05 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HytLb-0002mq-CU for emacs-devel@gnu.org; Thu, 14 Jun 2007 13:43:03 -0400 Original-Received: from sbcs.cs.sunysb.edu ([130.245.1.15]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HytLb-0000bb-0i for emacs-devel@gnu.org; Thu, 14 Jun 2007 13:43:03 -0400 Original-Received: from localhost (compserv1 [130.245.1.44]) by sbcs.cs.sunysb.edu (8.13.6/8.12.11) with ESMTP id l5EHh00t001294; Thu, 14 Jun 2007 13:43:01 -0400 (EDT) Original-Received: from [127.0.0.1]:10025 (localhost [127.0.0.1]) by localhost (Postfix) with ESMTP id E799574057; Thu, 14 Jun 2007 13:43:03 -0400 (EDT) In-Reply-To: Message from Stefan Monnier of "Thu, 14 Jun 2007 10:40:03 EDT." X-Mailer: MH-E 8.0.3; nmh 1.1; GNU Emacs 22.1.50 X-detected-kernel: Solaris 10 (1203?) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:72884 Archived-At: > > Sorry, I did not touch diff-mode.el intentionally. I see that the log > > points the finger in my direction, but I do not know how it happened. :-( > > The expression to which you changed diff-font-lock-keywords is similar to > > one in ediff, but I do not know if it is what you wanted in > > diff-mode.el. It seems ok, but if you are not sure then it is better to > > revert to version 1.100. Sorry for the mixup. > > You changed "\\S-" into "[^\t]" which was obviously meant to be "[^ \t]". > So I fixed the obvious. I don't have much preference between the two, so > I left "[^ \t]" there. Maybe if you could say why you preferred "[^ \t]" > over "\\S-" in ediff, I can make up a good reason to do the same change in > diff-mode.el ;-)? It was [^ \t] in ediff from the beginning. I changed it to [^\t] in ediff because I wanted to take care of files that have spaces in their names. But this was wrong and I reverted the change back to [^ \t]. I am not sure how that same change got into diff-mode.el. Maybe I did something mechanically and did not notice. --michael