From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: project.el: git submodules? Date: Fri, 15 May 2020 22:17:11 +0300 Message-ID: <20770c02-39b2-5041-f7e8-9bed0dee9b55@yandex.ru> References: <875zd1ni5i.fsf@md5i.com> <55769244-c84c-dff0-4427-9ff688f81af5@yandex.ru> <87v9l0nar5.fsf@md5i.com> <95a8c285-125f-afda-b1bc-d1c0452e5c31@yandex.ru> <1bc2052e-b26b-1f3d-f78c-a22112861f27@yandex.ru> <7b247aac-28bd-94c1-2546-524edde9b781@yandex.ru> <42510ba9-1235-7180-af36-2d9de24835b4@yandex.ru> <21e149fc-dba5-47f0-ea7f-60a16ea32819@yandex.ru> <91b1284a-08d0-e57c-e6e3-c9a0a8e66e8b@yandex.ru> <6101fe38-2e28-83a1-0cad-a2d5bcd2df16@yandex.ru> <878shtlk7b.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="91896"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 Cc: Michael Welsh Duggan , Gary Oberbrunner , Stefan Monnier , Michael Welsh Duggan , "emacs-devel@gnu.org" To: =?UTF-8?Q?K=c3=a9vin_Le_Gouguec?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 15 21:18:53 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jZfr9-000NiL-A9 for ged-emacs-devel@m.gmane-mx.org; Fri, 15 May 2020 21:18:51 +0200 Original-Received: from localhost ([::1]:42230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZfr8-0004q2-Bq for ged-emacs-devel@m.gmane-mx.org; Fri, 15 May 2020 15:18:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZfpd-0004DY-VY for emacs-devel@gnu.org; Fri, 15 May 2020 15:17:20 -0400 Original-Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:38960) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZfpc-0004vB-15 for emacs-devel@gnu.org; Fri, 15 May 2020 15:17:16 -0400 Original-Received: by mail-wm1-x32e.google.com with SMTP id w64so3774324wmg.4 for ; Fri, 15 May 2020 12:17:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=18W9QD94uPzepu4Y/dyQYlmwxiiEy4+vpkEzrBeRMbg=; b=mb5OyNA7f7mhIUkRfal+gyvx7sga1j+aeoFOp24rsDFsVPtagUEv6bq2bxXfGiekJg yc1ByhLPQREzcDdKLr8bKhsSRHrDCacB41m7lGNJINQYiuxSUQ0Oggug5fJ0DHQ80iWl klllqvEfRZcVmX59nFu5XFB5vq0bSZJBh+1E+WMh5FEqTnU0sKWovd3jqygkbxekhqHs 2KEhzNznhmKPe9jRN3VINMYrrJPmIgPBjvYES3DjnvkHfNSR9UGrMzFCBFvF+OBmqGks Q+Th9KXR6uLiF5+NWndd+ZlaAibibFEWoMYJs8yGx4dxPzJ1FgwHNhu2N1ytINkkGC2j rMsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=18W9QD94uPzepu4Y/dyQYlmwxiiEy4+vpkEzrBeRMbg=; b=cyrCO1fuRYcIfnyBuIJHLfGacr6cn4GvomFLTGfleFFfI3U9issEwaTAagbjfc7Ofw Jlwtain8CaJUAAE1uwh4vSC2qgrmJSusyb4NxYA0LRGd9MoENCLxbvXUwhwlToAHVElS UIUOXNutQ4fmj4jLv2dV5J9qV6Hb3tTeuSyOACHQ0gUTqOykiLaMCGlme4BxPXUmg4Yj ZQaoBznMSUrcRAL1OQrGxsQ+YWPq5NIXjkfII2y9wgAEaVm6ehMzxbWq8PfqCr7eHV30 ZxxomCahoFXHqs+j+a7WoN5VKJEAJlQ8ty9mj3iqrtbRluZTdmFiQ7IjIqPD5Kg04hbG BE+g== X-Gm-Message-State: AOAM532OlKL26l3vE0VngPo+ARjybrMqJTCKTmauHSBx58/4qfuFTp66 z9nt136blM8kNM6DgRDGxIhSBKWK X-Google-Smtp-Source: ABdhPJyNtMSTq+QjBwChkUYe3PBam4sencF7/aDTEbk85ujnlvxpFUnqy79yAge2ZQD1u4GShVecGA== X-Received: by 2002:a1c:7d93:: with SMTP id y141mr5675449wmc.34.1589570234159; Fri, 15 May 2020 12:17:14 -0700 (PDT) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id n9sm5318614wru.90.2020.05.15.12.17.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2020 12:17:13 -0700 (PDT) In-Reply-To: <878shtlk7b.fsf@gmail.com> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=raaahh@gmail.com; helo=mail-wm1-x32e.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:250418 Archived-At: Hi Kevin! On 15.05.2020 10:40, Kévin Le Gouguec wrote: > I've tried commit 779bc886: > > ✓ within "nested" projects (e.g. when $HOME is under version control, > and visiting the Emacs repo under ~/src/emacs), project-find-file uses > the innermost project (~/src/emacs) as root, > > ✓ at the root of a Git worktree (e.g. when ~/src/emacs-26.3 is a > worktree of ~/src/emacs, and visiting ~/src/emacs-26.3), > project-find-file uses the worktree (~/src/emacs-26.3) as root, > > ❌ in a subfolder of a Git worktree (e.g. in ~/src/emacs-26.3/src), > project-find-file signals: > >> project-try-vc: Opening input file: No such file or directory, /home/$USER/src/emacs-26.3/src/.git > > ✓ at the root of a Git submodule (e.g. when ~/projects/foo/bar is a > submodule of ~/projects/foo, and visiting ~/projects/foo/bar), > project-find-file uses the parent module (~/projects/foo) as root, > > ❌ in a subfolder of a Git submodule (e.g. in > ~/projects/foo/bar/baz), project-find-file signals: > >> project-try-vc: Opening input file: No such file or directory, /home/$USER/projects/foo/bar/baz/.git Thank you for exhaustive testing. The failing cases should be fixed now. > I hope I got that right. Thank you for working on this; I'd love for > project-find-file to finally work in worktrees :) I was not aware they didn't. :-( Apparently I've been using the old, "fake" version of worktrees.