From: Dmitry Gutov <dgutov@yandex.ru>
To: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Cc: Michael Welsh Duggan <mwd@md5i.com>,
Gary Oberbrunner <garyo@oberbrunner.com>,
Stefan Monnier <monnier@iro.umontreal.ca>,
Michael Welsh Duggan <mwd@cert.org>,
"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: project.el: git submodules?
Date: Fri, 15 May 2020 22:17:11 +0300 [thread overview]
Message-ID: <20770c02-39b2-5041-f7e8-9bed0dee9b55@yandex.ru> (raw)
In-Reply-To: <878shtlk7b.fsf@gmail.com>
Hi Kevin!
On 15.05.2020 10:40, Kévin Le Gouguec wrote:
> I've tried commit 779bc886:
>
> ✓ within "nested" projects (e.g. when $HOME is under version control,
> and visiting the Emacs repo under ~/src/emacs), project-find-file uses
> the innermost project (~/src/emacs) as root,
>
> ✓ at the root of a Git worktree (e.g. when ~/src/emacs-26.3 is a
> worktree of ~/src/emacs, and visiting ~/src/emacs-26.3),
> project-find-file uses the worktree (~/src/emacs-26.3) as root,
>
> ❌ in a subfolder of a Git worktree (e.g. in ~/src/emacs-26.3/src),
> project-find-file signals:
>
>> project-try-vc: Opening input file: No such file or directory, /home/$USER/src/emacs-26.3/src/.git
>
> ✓ at the root of a Git submodule (e.g. when ~/projects/foo/bar is a
> submodule of ~/projects/foo, and visiting ~/projects/foo/bar),
> project-find-file uses the parent module (~/projects/foo) as root,
>
> ❌ in a subfolder of a Git submodule (e.g. in
> ~/projects/foo/bar/baz), project-find-file signals:
>
>> project-try-vc: Opening input file: No such file or directory, /home/$USER/projects/foo/bar/baz/.git
Thank you for exhaustive testing. The failing cases should be fixed now.
> I hope I got that right. Thank you for working on this; I'd love for
> project-find-file to finally work in worktrees :)
I was not aware they didn't. :-( Apparently I've been using the old,
"fake" version of worktrees.
next prev parent reply other threads:[~2020-05-15 19:17 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 15:31 project.el: git submodules? Gary Oberbrunner
2020-05-12 15:53 ` Dmitry Gutov
2020-05-12 18:05 ` Michael Welsh Duggan
2020-05-12 18:27 ` Dmitry Gutov
2020-05-12 19:36 ` Stefan Monnier
2020-05-12 19:39 ` Dmitry Gutov
2020-05-12 20:45 ` Michael Welsh Duggan
2020-05-12 20:53 ` Dmitry Gutov
2020-05-12 21:04 ` Stefan Monnier
2020-05-12 21:06 ` Dmitry Gutov
2020-05-12 21:09 ` Stefan Monnier
2020-05-14 0:32 ` Dmitry Gutov
2020-05-14 2:55 ` Stefan Monnier
2020-05-14 15:04 ` Dmitry Gutov
2020-05-14 17:57 ` Stefan Monnier
2020-05-14 19:29 ` Dmitry Gutov
2020-05-14 20:01 ` Stefan Monnier
2020-05-14 20:13 ` Dmitry Gutov
2020-05-14 21:17 ` Dmitry Gutov
2020-05-14 21:38 ` Michael Welsh Duggan
2020-05-15 1:21 ` Dmitry Gutov
2020-05-15 5:11 ` Dmitry Gutov
2020-05-15 7:40 ` Kévin Le Gouguec
2020-05-15 19:17 ` Dmitry Gutov [this message]
2020-05-12 20:53 ` Michael Welsh Duggan
2020-05-12 20:51 ` Michael Welsh Duggan
2020-05-12 20:58 ` John Yates
2020-05-13 7:19 ` Andreas Schwab
2020-05-12 18:33 ` Gary Oberbrunner
2020-05-12 19:28 ` Dmitry Gutov
2020-05-12 19:34 ` Gary Oberbrunner
2020-05-12 19:41 ` Dmitry Gutov
2020-05-12 19:44 ` Doug Davis
2020-05-12 19:50 ` Gary Oberbrunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20770c02-39b2-5041-f7e8-9bed0dee9b55@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=garyo@oberbrunner.com \
--cc=kevin.legouguec@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=mwd@cert.org \
--cc=mwd@md5i.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.