From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mikael Pettersson Newsgroups: gmane.emacs.bugs Subject: bug#13332: [PATCH] unbreak Emacs on Linux/M68K Date: Tue, 1 Jan 2013 22:51:12 +0100 Message-ID: <20707.23120.274311.883850@pilspetsen.it.uu.se> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1357086477 11367 80.91.229.3 (2 Jan 2013 00:27:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 2 Jan 2013 00:27:57 +0000 (UTC) Cc: Mikael Pettersson To: 13332@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 02 01:28:14 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TqCBj-0005sz-1g for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Jan 2013 01:28:07 +0100 Original-Received: from localhost ([::1]:53854 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqCBU-0008Ij-2g for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Jan 2013 19:27:52 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:60063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqCBP-0008IO-2r for bug-gnu-emacs@gnu.org; Tue, 01 Jan 2013 19:27:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TqCBM-0004XU-40 for bug-gnu-emacs@gnu.org; Tue, 01 Jan 2013 19:27:47 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqCBM-0004XP-06 for bug-gnu-emacs@gnu.org; Tue, 01 Jan 2013 19:27:44 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TqCCb-0006U3-PL for bug-gnu-emacs@gnu.org; Tue, 01 Jan 2013 19:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mikael Pettersson Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Jan 2013 00:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13332 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.135708654024914 (code B ref -1); Wed, 02 Jan 2013 00:29:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Jan 2013 00:29:00 +0000 Original-Received: from localhost ([127.0.0.1]:39466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TqCCZ-0006Tm-Lt for submit@debbugs.gnu.org; Tue, 01 Jan 2013 19:29:00 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:55469) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tq9lw-0002Yg-QX for submit@debbugs.gnu.org; Tue, 01 Jan 2013 16:53:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tq9ke-00057T-MN for submit@debbugs.gnu.org; Tue, 01 Jan 2013 16:52:03 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:52794) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tq9ke-00057P-Io for submit@debbugs.gnu.org; Tue, 01 Jan 2013 16:52:00 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:38594) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tq9kc-0001i8-32 for bug-gnu-emacs@gnu.org; Tue, 01 Jan 2013 16:52:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tq9kZ-000571-6F for bug-gnu-emacs@gnu.org; Tue, 01 Jan 2013 16:51:58 -0500 Original-Received: from smtp1.uu.se ([130.238.7.54]:41537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tq9kY-00056q-Rq for bug-gnu-emacs@gnu.org; Tue, 01 Jan 2013 16:51:55 -0500 X-Virus-Scanned: amavisd-new at uu.se Original-Received: from pilspetsen.it.uu.se (pilspetsen.it.uu.se [130.238.18.39]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by bornea.its.uu.se (Postfix) with ESMTPS id C9ADA88896; Tue, 1 Jan 2013 22:50:30 +0100 (CET) Original-Received: (from mikpe@localhost) by pilspetsen.it.uu.se (8.14.5+Sun/8.14.5) id r01LpCZ0012403; Tue, 1 Jan 2013 22:51:12 +0100 (MET) X-Authentication-Warning: pilspetsen.it.uu.se: mikpe set sender to mikpe@it.uu.se using -f X-Mailer: VM 7.17 under Emacs 20.7.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Mailman-Approved-At: Tue, 01 Jan 2013 19:28:58 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:69280 Archived-At: Attempting to bootstrap Emacs 23.x or 24.x on Linux/M68K fails with a SEGV as soon as temacs is run. Inspecting the core dump shows: Core was generated by `/home/mikpe/emacs-24.2/build-nox/src/temacs --batch --load loadu'. Program terminated with signal 11, Segmentation fault. #0 0x800d5444 in mark_object (arg=1174437910) at /home/mikpe/emacs-24.2/src/alloc.c:5720 5720 if (CONS_MARKED_P (ptr)) (gdb) bt #0 0x800d5444 in mark_object (arg=1174437910) at /home/mikpe/emacs-24.2/src/alloc.c:5720 #1 0x800d55ba in mark_object (arg=-2143958762) at /home/mikpe/emacs-24.2/src/alloc.c:5731 #2 0x800d5c3a in mark_vectorlike (ptr=0x8035b120) at /home/mikpe/emacs-24.2/src/alloc.c:5420 #3 0x800d5d62 in Fgarbage_collect () at /home/mikpe/emacs-24.2/src/alloc.c:5128 #4 0x800eb7be in Ffuncall (nargs=3, args=0xefcdfad4) at /home/mikpe/emacs-24.2/src/eval.c:2938 #5 0x800ebc46 in call2 (fn=0, arg1=0, arg2=-2143972138) at /home/mikpe/emacs-24.2/src/eval.c:2785 #6 0x800ebf82 in Fsignal (error_symbol=0, data=-2143972138) at /home/mikpe/emacs-24.2/src/eval.c:1710 #7 0x800ec412 in xsignal (error_symbol=0, data=-2143972138) at /home/mikpe/emacs-24.2/src/eval.c:1785 #8 0x800ecdc8 in xsignal1 (error_symbol=0, arg=-2143955495) at /home/mikpe/emacs-24.2/src/eval.c:1800 #9 0x800ece32 in verror (m=0x8015f90d "Bad data in guts of obarray", ap=0xefce0b24) at /home/mikpe/emacs-24.2/src/eval.c:1998 #10 0x800ece44 in error (m=0x8015f90d "Bad data in guts of obarray") at /home/mikpe/emacs-24.2/src/eval.c:2010 #11 0x80108eec in oblookup (obarray=, ptr=0x80156383 "char-table-extra-slots", size=22, size_byte=22) at /home/mikpe/emacs-24.2/src/lread.c:3912 #12 0x8010c578 in intern_c_string (str=0x80156383 "char-table-extra-slots") at /home/mikpe/emacs-24.2/src/lread.c:3728 #13 0x8005ce76 in init_category_once () at /home/mikpe/emacs-24.2/src/category.c:461 #14 0x80006558 in main (argc=, argv=0xefce0ef4) at /home/mikpe/emacs-24.2/src/emacs.c:1265 (gdb) q This turns out to be caused by the well-known issue of data alignment on Linux/M68K: the ABI only aligns 32-bit (and larger) primitive types to 16-bit boundaries, which doesn't provide enough known-zero bits in object pointers for Emacs' tagging scheme, causing major confusion and breakage at runtime. This patch introduces two new integer types in src/m/m68k.h that are exactly like int and unsigned int, except they are explicitly aligned to 32-bit boundaries; gcc's attribute aligned is used for this purpose. It then defines EMACS_INT and EMACS_UINT to these types to override the default choices in src/lisp.h. With this patch in place bootstrap succeeds and the final emacs executable works fine. Tested with Emacs-24.2 on Linux/M68K. /Mikael Pettersson [I consider this 6-line patch (not counting the comment) to be trivial so I hope it will be acceptable even without a formal copyright assignment.] src/ChangeLog: 2013-01-01 Mikael Pettersson * m/m68k.h [GNU_LINUX] (m68k_aligned_int_t, m68k_aligned_uint_t): New typedefs. (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define. --- emacs-24.2/src/m/m68k.h.~1~ 2012-08-23 07:33:42.000000000 +0200 +++ emacs-24.2/src/m/m68k.h 2013-01-01 14:26:10.000000000 +0100 @@ -28,5 +28,19 @@ along with GNU Emacs. If not, see