From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vincenzo Pupillo Newsgroups: gmane.emacs.bugs Subject: bug#71771: 31.0.50; [PATCH] php-ts-mode: jsdoc support in javascript Date: Thu, 27 Jun 2024 21:44:59 +0200 Message-ID: <2053843.Jadu78ljVU@fedora> References: <9865475.eNJFYEL58v@3-191.divsi.unimi.it> <86cyo267n1.fsf@gnu.org> <2140364.9o76ZdvQCi@fedora> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart2764419.QOukoFCf94" Content-Transfer-Encoding: 7Bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39890"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71771@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 27 23:01:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMwEv-000AAw-5w for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Jun 2024 23:01:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMwEn-0008S1-IG; Thu, 27 Jun 2024 17:01:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMwEl-0008Om-Iv for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 17:01:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMwEk-00087i-W7 for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 17:00:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sMwEn-0004Uu-SX for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 17:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Vincenzo Pupillo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2024 21:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71771 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71771-submit@debbugs.gnu.org id=B71771.171952201617228 (code B ref 71771); Thu, 27 Jun 2024 21:01:01 +0000 Original-Received: (at 71771) by debbugs.gnu.org; 27 Jun 2024 21:00:16 +0000 Original-Received: from localhost ([127.0.0.1]:43508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMwE3-0004Tn-NC for submit@debbugs.gnu.org; Thu, 27 Jun 2024 17:00:16 -0400 Original-Received: from mail-wm1-f42.google.com ([209.85.128.42]:51308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMwE1-0004SQ-5e for 71771@debbugs.gnu.org; Thu, 27 Jun 2024 17:00:14 -0400 Original-Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4217c7eb6b4so68596815e9.2 for <71771@debbugs.gnu.org>; Thu, 27 Jun 2024 14:00:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719521942; x=1720126742; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KJ4sUisc0Hwn9ugSJyiMPwryFyPIGwboVQSGkg59o4I=; b=P6+V5+Z9QWrA/nvtseiel3HtBh1Y+Vi7fbyy+9Ui+0rcSzVS/ahmrpdh2nW+PM0p5W d+2iLdWJLPslQkEdEaqF9Veck+f994pNYiO1sdNFlxTID2UfasUBXKmbOjsei715Vyrn GHpNk0TPco9+LsJs1qhbn1FBlvveO9s/A86slKlrTs8HBbljwBjXKn7yXqrZO2IoTJ6L GNVZ4YnH61L+LnKLW0HodUknQn+rF30lZgw0zke5Vkth7DHfcRV/w7EN9bA92Xkh0ref BMWSrnDUOCeJNwJuOeYmS59jOIDpfvjNQRxQkPPuEIw5me8I3WddrqrrFnQnbfVqZa0V grTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719521942; x=1720126742; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KJ4sUisc0Hwn9ugSJyiMPwryFyPIGwboVQSGkg59o4I=; b=IKP6EOkmt+HFZvv01rY7eRYvQ2vkeHOSqO8mvk9lvsiq6lipZ2ZpR/h7ZiDiTxsGJo uC6bQMSVUjSfcrV9oBbDg2YY0j/eFfxoes1xwZvavddSRsYp9eP56zNk08RvBm+TyDha gdC0bOWdV9VySdCz43rpxfdKWfQ97jkceyF17+GMJhpebStau2UJOox9JsdT/x5xZfyZ YCYkJXJiiXD0xjGb525xnfH6auKvK4QSgLrO1nbrIWfDZ/pwSYyjo7fH/j5daTTMybKw x1SBAV5uquCbFwpZeAbvFX1nJ/ifY0ROkw2JvzY6zDLbyMjp4aRBijUOzg8DRflxpeoN 1SKA== X-Gm-Message-State: AOJu0Yy6vYP9qnQjbPlGJoGlXx4kISSj2paIH0+VUd4bBmWeEMA1K8ZV wv7PJ+L1b9ORSZEystmRzlpK/oeOk/loPxsgK40cEicWeXcjBhx8gw5nWvzR X-Google-Smtp-Source: AGHT+IEWpK63YPD1zrFsUKH6LGxO/BRRcd6giaH+0Ru9NrO5b2UaQcI0JQoiHlcSmHhN9+sxZUlQpw== X-Received: by 2002:a17:907:c008:b0:a72:7bf4:6954 with SMTP id a640c23a62f3a-a727bf46a45mr696848566b.10.1719517501155; Thu, 27 Jun 2024 12:45:01 -0700 (PDT) Original-Received: from fedora.localnet (2-230-139-124.ip202.fastwebnet.it. [2.230.139.124]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72aaf628d6sm6149566b.60.2024.06.27.12.45.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 12:45:00 -0700 (PDT) In-Reply-To: <2140364.9o76ZdvQCi@fedora> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288037 Archived-At: This is a multi-part message in MIME format. --nextPart2764419.QOukoFCf94 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In data gioved=C3=AC 27 giugno 2024 12:29:40 CEST, Vincenzo Pupillo ha scri= tto: > In data gioved=C3=AC 27 giugno 2024 11:45:54 CEST, Eli Zaretskii ha scrit= to: > > > From: Vincenzo Pupillo > > > Date: Tue, 25 Jun 2024 11:52:20 +0200 > > >=20 > > > this patch add support for embedding jsdoc into inline javascript > > > element. > >=20 > > Thanks, but is this for the master branch or for the emacs-30 release > > branch? Where was php-ts-mode broken? >=20 > Hi Eli, > this is for the master branch. > jsdoc is not available in emacs-30. > Thanks. > V. php-ts-mode was broken because the js--treesit-font-lock-settings variable = now=20 contains rules for jsdoc, a parser that php-ts-mode did not use. I fixed the patch because, as I wrote for bug 71776, the jsdoc parser is=20 local, just like the phpdoc parser. The screenshot I attach is the result of this patch and the two from bug=20 71776. Thanks. Vincenzo --nextPart2764419.QOukoFCf94 Content-Disposition: attachment; filename="0001-Add-jsdoc-support-to-php-ts-mode-in-script-element.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="x-UTF_8J"; name="0001-Add-jsdoc-support-to-php-ts-mode-in-script-element.patch" >From 03eca8bd6cb19871e6ac86fb2559088a9a0fd8a9 Mon Sep 17 00:00:00 2001 From: Vincenzo Pupillo Date: Tue, 25 Jun 2024 11:29:54 +0200 Subject: [PATCH] Add jsdoc support to php-ts-mode in