From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Date: Fri, 22 Nov 2019 20:51:10 +0200 Message-ID: <20441040-20fd-d5ba-0c9d-4c6132b37a33@yandex.ru> References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <29e2e877-6dc3-b03b-7463-01cff35e05d1@yandex.ru> <87pnhkern2.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="15582"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 22 19:59:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iYE98-0003sJ-01 for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Nov 2019 19:59:10 +0100 Original-Received: from localhost ([::1]:54422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iYE95-0004O8-1X for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Nov 2019 13:59:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43208) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iYE2H-0006HF-8l for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 13:52:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iYE2G-0001ST-7e for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 13:52:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46675) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iYE2G-0001SO-3U for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 13:52:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iYE2E-0000ir-3x for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 13:52:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Nov 2019 18:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38044 X-GNU-PR-Package: emacs Original-Received: via spool by 38044-submit@debbugs.gnu.org id=B38044.15744486962745 (code B ref 38044); Fri, 22 Nov 2019 18:52:02 +0000 Original-Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 18:51:36 +0000 Original-Received: from localhost ([127.0.0.1]:55496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYE1n-0000iC-Mz for submit@debbugs.gnu.org; Fri, 22 Nov 2019 13:51:35 -0500 Original-Received: from mail-wm1-f42.google.com ([209.85.128.42]:54642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYE1h-0000hs-A7 for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 13:51:31 -0500 Original-Received: by mail-wm1-f42.google.com with SMTP id x26so8248230wmk.4 for <38044@debbugs.gnu.org>; Fri, 22 Nov 2019 10:51:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8fHQuCDIZEcirdkZJA0SGJ29CIgH7JOidY7syoPOwZ4=; b=SBkaccPep+ko5hkx9BGF4sON3HTKU/Ox1z4dVy1AXd+JgaXkzhqZtaXtR0mveaGqki LWFoa3K8k5OvJMCMcUQsXHXwLaniuKh5aHiFasw1HnuVPLLwUXAzUlvnCv+8IlaoD180 Z+Ysr/qZVL3zPorxTAbTAKLrdvLWBtzpONetrt0XThrPndkOXFLm4EWgCDDwUVBOgE+M DvOxJOl8C5e+KjPYfrmBLMZsbb3a+9ZVhSi9bCWMPwjLIPS4EQfJ7eGOasntrpcVJ75G WjLhWl7qS88aVd5XByPN7T3GOK4mMWhUuf4DY/1T3seTrKOmY7JK9ikBiko4SbVqnBSa ia7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8fHQuCDIZEcirdkZJA0SGJ29CIgH7JOidY7syoPOwZ4=; b=PvZv/DFtWBl+ZO0ojQS7dDfQb58eAxRmvBWMZHoRDCiq1B6FdEClBtqGvSjv2JN9t4 zGo1ZkFIg2wKThtoHpe96n7H47kmDtzVUQzzDDZXUkCwSQ7t15mzPkeeXZZI22hHh2RV pHeJzQl+jDJLcMZL3OpYo2rSKbPWfWnVcDnkBuXUjwqPF/bcyABlELZoY0Zxn3GhOMXd sfofCBMkRJGqR8T+e9PtN4BkFqxWTbWFxNuXu5F9o/+rIEYSU2Cv+VI59pF4J9F8kCmZ Pd/DVhz15sgC/d7dUofZN9Pp78alO4BBypNjPQQBQq4MY9bmOWl/xQ7YK4Tqe7Nbx1uc fcpg== X-Gm-Message-State: APjAAAVkIK6ZhcD/G0Oopj5YY6LlpkfoPV+bK6al0EHSWKlWZRedDmJr bPGVNoLxeyKvkwUzusQKYXY= X-Google-Smtp-Source: APXvYqzkGoNUNoBsZp9z5R8talVmIhYnZ4P4FFaXhNheGCv+Me0NQPVnGMIV5yn4I1FLKUi25C0kVA== X-Received: by 2002:a1c:9ccd:: with SMTP id f196mr18129628wme.152.1574448683275; Fri, 22 Nov 2019 10:51:23 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id f19sm9650083wrf.23.2019.11.22.10.51.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Nov 2019 10:51:22 -0800 (PST) In-Reply-To: <87pnhkern2.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172254 Archived-At: On 22.11.2019 1:08, Juri Linkov wrote: >> The approach LGTM. I'd have used "describe" or "show", but it's not >> important. > > The name vc-print-revision was modeled after vc-print-log, > vc-print-root-log, vc-print-branch-log that are not the best names > but at least consistent for their prefix. Yeah, OK. >>> (setq default-directory rootdir) >> >> This probably needs a saving (let ((default-directory default-directory)) >> ...) above it. > > This is intentional because on testing I discovered that RET > on the diff part of the buffer can't visit source files > when default-directory is not root. I'm saying your code modifies the value of default-directory in the original buffer as well. Hence the need for a (let ((...)) before that. Just like vc-print-root-log does it. BTW, vc-print-branch-log skips this step, so maybe it also exhibits the bug you mentioned. If so, I wonder if we should move the logic changing default-directory inside vc-print-log-internal.