From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60961: 29.0.60; Compiling emacs-29 without treesitter outputs warnings Date: Fri, 20 Jan 2023 23:30:41 +0100 Message-ID: <2025C712-7091-4971-B254-51844C0FA609@thornhill.no> References: <878rhx1os6.fsf@gmail.com> <831qnpnx9g.fsf@gnu.org> <87o7qtuxgh.fsf@thornhill.no> <83tu0lmgv6.fsf@gnu.org> <87h6wll10q.fsf@thornhill.no> <83r0vpme0t.fsf@gnu.org> <8A47E6B6-BE4F-44F4-9BC5-55B6051CDCD4@thornhill.no> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21589"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , rpluim@gmail.com, 60961@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 20 23:31:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIzun-0005Po-Fo for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Jan 2023 23:31:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIzua-0001bx-Ru; Fri, 20 Jan 2023 17:31:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIzuY-0001bk-Dz for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 17:31:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pIzuY-00033Y-6P for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 17:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pIzuX-0003bX-Lk for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 17:31:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Jan 2023 22:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60961 X-GNU-PR-Package: emacs Original-Received: via spool by 60961-submit@debbugs.gnu.org id=B60961.167425384713826 (code B ref 60961); Fri, 20 Jan 2023 22:31:01 +0000 Original-Received: (at 60961) by debbugs.gnu.org; 20 Jan 2023 22:30:47 +0000 Original-Received: from localhost ([127.0.0.1]:47429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIzuJ-0003aw-Ag for submit@debbugs.gnu.org; Fri, 20 Jan 2023 17:30:47 -0500 Original-Received: from out-12.mta0.migadu.com ([91.218.175.12]:45236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIzuI-0003an-0N for 60961@debbugs.gnu.org; Fri, 20 Jan 2023 17:30:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1674253844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B8yuhylkbTfDKWLRlbN3vveo8vCW8K39aTi4v6DHawY=; b=TWAtPoFKBUGUEEF+Es07Q4NQdGQ8mQCoQVSDxneu18r6TXyBYSf7MPhFHYGdq2iPamiqPB OLEMfCyX7ltN6uNlyAMYIVObynyMnP6WAM0UvJizb+tAXRG/5uoHMxrI/T4gu0oKkO4jSN OTuDa9khy9fzaOfaEc/7CE8QWQn1Xen4mfd67DoUDJhN8qC1I3XQzbRFf3gnqQmNCcqfIX vuCRG5jwxRKTIlT84nsA/Lit+9//NQQQ+oguK0OX3jlXwGaaZOm8FsXVr05JF5cnEAfyfq 2lQ7JvOJhvRLeUqTu8Gwul3vZZL3HCtA2Sw/FDgcgUzlW3lCD7DAzGnwefuEOQ== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253812 Archived-At: On 20 January 2023 23:11:44 CET, Yuan Fu wrote: > > >> On Jan 20, 2023, at 8:07 AM, Theodor Thornhill wr= ote: >>=20 >>=20 >>=20 >> On 20 January 2023 16:17:22 CET, Eli Zaretskii wrote: >>>> From: Theodor Thornhill >>>> Cc: rpluim@gmail=2Ecom, casouri@gmail=2Ecom, 60961@debbugs=2Egnu=2Eor= g >>>> Date: Fri, 20 Jan 2023 15:43:33 +0100 >>>>=20 >>>> Eli Zaretskii writes: >>>>=20 >>>>>> So I can either just make sure that no modes require across modes, = or >>>>>> make that "lib" right now=2E What do you think? >>>>>=20 >>>>> I tend to the "lib" method=2E Mostly because several modes, includi= ng >>>>> some that are unrelated to C, want the code which was written for >>>>> C/C++, and so it is possible that there's some general feature here >>>>> waiting for us to refactor the code -- in which case perhaps the cod= e >>>>> should be in treesit=2Eel? >>>>>=20 >>>>> IOW, how come JS, Rust, and Typescript all want comment-related setu= p >>>>> that was written for C? > >Because they all have C-like syntax, so they have the same setup for inde= nting and filling block comments, for example=2E > >>>>> If this is just a coincidence, then perhaps >>>>> duplicating the code is a better idea, but if there's some underlyin= g >>>>> commonality, we should have common code in treesit=2Eel, or maybe in >>>>> some c-ts-common=2Eel? > >c-ts-common=2Eel sounds good to me=2E > >>>>=20 >>>> I can start by moving it into treesit=2Eel, then we can maybe extract >>>> something out later=2E Sounds good? I can do it tonight, unless any= of >>>> you object :) >>>=20 >>> SGTM, but let's hear from Yuan before you start working on this=2E >>>=20 >>> Thanks=2E >>=20 >> Thumbs up > >I=E2=80=99d prefer c-ts-common=2Eel over treesit=2Eel, since they only ap= ply to C-like languages=2E There is no harm putting them in a separate file= , right? I wrote some commentary in c-ts-mode, which notes all the shared f= unctions and variables=2E=20 > >Yuan > Ok, should I do it or you? :) Theo