From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Roland Winkler" Newsgroups: gmane.emacs.bugs Subject: bug#10254: 24.0.92; Local variable bibtex-dialect has no effect Date: Mon, 16 Jan 2012 16:21:52 -0600 Message-ID: <20244.41728.921399.487290@gargle.gargle.HOWL> References: <844nxakxtd.fsf@tum.de> <4EE32275.26106.E38FFC3@uwe.siart.tum.de> <2rfwfoz6w2.fsf@fencepost.gnu.org> <20242.38530.735318.867329@gargle.gargle.HOWL> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1326752596 24602 80.91.229.12 (16 Jan 2012 22:23:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 16 Jan 2012 22:23:16 +0000 (UTC) Cc: Uwe Siart , 10254@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 16 23:23:12 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RmuxL-00017N-HD for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jan 2012 23:23:11 +0100 Original-Received: from localhost ([::1]:33962 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmuxL-0008LC-0N for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jan 2012 17:23:11 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:48919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmuxI-0008Ku-D3 for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 17:23:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RmuxG-0004ji-L8 for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 17:23:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37884) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmuxG-0004je-Gw for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 17:23:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RmuyA-0002Vx-FG for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 17:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Roland Winkler" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Jan 2012 22:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10254 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10254-submit@debbugs.gnu.org id=B10254.13267525969608 (code B ref 10254); Mon, 16 Jan 2012 22:24:02 +0000 Original-Received: (at 10254) by debbugs.gnu.org; 16 Jan 2012 22:23:16 +0000 Original-Received: from localhost ([127.0.0.1]:60790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RmuxP-0002Ur-Vz for submit@debbugs.gnu.org; Mon, 16 Jan 2012 17:23:16 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]:44688) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RmuxN-0002Uk-FQ for 10254@debbugs.gnu.org; Mon, 16 Jan 2012 17:23:14 -0500 Original-Received: from 82.red-80-32-229.staticip.rima-tde.net ([80.32.229.82]:44672 helo=regnitz) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1RmuwI-0004j9-9J; Mon, 16 Jan 2012 17:22:15 -0500 In-Reply-To: X-Mailer: VM 8.2 trial under 24.0.92.1 (x86_64-unknown-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55806 Archived-At: On Mon Jan 16 2012 Stefan Monnier wrote: > > +(make-variable-buffer-local 'bibtex-dialect) > > I don't think you should force it to be buffer-local. Just leave it as > a global setting by default, and just change the code so that if the > user decides to make it local to some buffer, the rest of the code > handles it properly. This variable (and everything going with it) is new in Emacs 24. So to some extent we have to speculate about "typical usage patterns" of this variable. Yet after having thought about this a bit more I tend to agree with the OP that the need for a buffer-local binding of bibtex-dialect may occur more often. I expect that users want to set the default value of this variable in their init file. Yet when they want to set this variable interactively (via the menu bar or the command bibtex-set-dialect) I expect this to occur more often in a context similar to the one that made the OP look into a file local binding: one has got one BibTeX file that does not match the default binding of bibtex-dialect so that one needs to change the buffer local value of this variable. On the other hand I cannot think of many scenarios where one might want to change this variable interactively for all BibTeX buffers one is working with. Am I missing something? Roland PS: My patch is based on the assumption that interactively setting bibtex-dialect changes all relevant variables only buffer-locally. If one also wanted to support the possibility that the default value can be changed interactively (thus affecting all BibTeX buffers) this would require a few more lines of code. Yet as I tried to say, I am not sure this would really be useful.