From: "Roland Winkler" <winkler@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Uwe Siart <uwe.siart@tum.de>, 10254@debbugs.gnu.org
Subject: bug#10254: 24.0.92; Local variable bibtex-dialect has no effect
Date: Mon, 16 Jan 2012 16:21:52 -0600 [thread overview]
Message-ID: <20244.41728.921399.487290@gargle.gargle.HOWL> (raw)
In-Reply-To: <jwv4nvv91nk.fsf-monnier+emacs@gnu.org>
On Mon Jan 16 2012 Stefan Monnier wrote:
> > +(make-variable-buffer-local 'bibtex-dialect)
>
> I don't think you should force it to be buffer-local. Just leave it as
> a global setting by default, and just change the code so that if the
> user decides to make it local to some buffer, the rest of the code
> handles it properly.
This variable (and everything going with it) is new in Emacs 24. So
to some extent we have to speculate about "typical usage patterns"
of this variable.
Yet after having thought about this a bit more I tend to agree with
the OP that the need for a buffer-local binding of bibtex-dialect
may occur more often. I expect that users want to set the default
value of this variable in their init file. Yet when they want to set
this variable interactively (via the menu bar or the command
bibtex-set-dialect) I expect this to occur more often in a context
similar to the one that made the OP look into a file local binding:
one has got one BibTeX file that does not match the default binding
of bibtex-dialect so that one needs to change the buffer local value
of this variable.
On the other hand I cannot think of many scenarios where one might
want to change this variable interactively for all BibTeX buffers
one is working with.
Am I missing something?
Roland
PS: My patch is based on the assumption that interactively setting
bibtex-dialect changes all relevant variables only buffer-locally.
If one also wanted to support the possibility that the default value
can be changed interactively (thus affecting all BibTeX buffers)
this would require a few more lines of code. Yet as I tried to say,
I am not sure this would really be useful.
next prev parent reply other threads:[~2012-01-16 22:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 7:29 bug#10254: 24.0.92; Local variable bibtex-dialect has no effect Uwe Siart
2011-12-10 7:43 ` Glenn Morris
2011-12-10 9:12 ` Uwe Siart
2012-01-10 1:24 ` Glenn Morris
2012-01-10 18:33 ` Roland Winkler
2012-01-11 6:41 ` Uwe Siart
2012-01-11 10:46 ` Roland Winkler
2012-01-11 14:57 ` Uwe Siart
2012-01-15 9:04 ` Roland Winkler
2012-01-16 14:14 ` Stefan Monnier
2012-01-16 22:21 ` Roland Winkler [this message]
2012-01-17 5:44 ` Uwe Siart
2012-01-17 14:04 ` Stefan Monnier
2012-01-17 20:45 ` Roland Winkler
2012-01-17 21:21 ` Stefan Monnier
2012-01-28 8:17 ` Roland Winkler
2012-01-28 14:05 ` Chong Yidong
2012-01-28 18:13 ` Roland Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20244.41728.921399.487290@gargle.gargle.HOWL \
--to=winkler@gnu.org \
--cc=10254@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=uwe.siart@tum.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.