From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Jakub T. Jankiewicz" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Scheme-mode: Add support for regular expression literal Date: Thu, 28 Mar 2024 12:33:54 +0100 Message-ID: <20240328123354.17588d57@jcubic> References: <87msqpfz68.fsf@niceume.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5382"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Stefan Monnier" , emacs-devel@gnu.org, "Eli Zaretskii" To: "Toshi Umehara" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 28 14:48:48 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rpq7c-0001DJ-7U for ged-emacs-devel@m.gmane-mx.org; Thu, 28 Mar 2024 14:48:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rpq6g-0007OM-Qe; Thu, 28 Mar 2024 09:47:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpo1N-0006pc-SU for emacs-devel@gnu.org; Thu, 28 Mar 2024 07:34:14 -0400 Original-Received: from smtpa34.poczta.onet.pl ([213.180.142.34]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpo1L-0000e7-G2 for emacs-devel@gnu.org; Thu, 28 Mar 2024 07:34:13 -0400 Original-Received: from jcubic (unknown [185.129.113.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jcubic@onet.pl) by smtp.poczta.onet.pl (Onet) with ESMTPSA id 4V51db53glz1wDV; Thu, 28 Mar 2024 12:33:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onet.pl; s=2011; t=1711625638; bh=IifLi7pNonIyEW8bPmJ9UkzddfnsKR5czXreg3TbhZE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HVTABLW6t5ge65u2nqe3bjUUMkjqTMUnwzsLJJhJudETy4MzFaDY8GWaiDso+XEEG 2Oj2vSQ8syZrzLJTEGW3BzlbbPGYP3JcbABQ9774WCOIdlGVLBRbP58zKWIIc47yHe gyZ2Rp77Uq5Y1LzKW3oZ4Gqz6HFFgZvTMvAjH2y8= In-Reply-To: X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) X-ONET_PL-MDA-SEGREGATION: 0 Received-SPF: pass client-ip=213.180.142.34; envelope-from=jcubic@onet.pl; helo=smtpa34.poczta.onet.pl X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 28 Mar 2024 09:47:45 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317361 Archived-At: One note about original solution in .emacs file that I used. It doesn't correctly handle #; it works only till the end of the line (it should comment out whole S-Expression). I hope that the code that was proposed for the scheme.el was tested and handle this correctly. On Sun, 24 Mar 2024 13:33:19 +0900 "Toshi Umehara" wrote: > Thank you very much for reviewing the patch, Stefan. > > The patch is updated. > > - Subexpression 1 is now used for regular expression rule in > syntax-propertize-rules > > - Unused arguments are removed from caller and callee of > scheme-syntax-propertize-regexp > > - Changing the third argument of re-search-forward from t to 'move moves > the point to end if the search does not find closing slash, which is > ideal. > > Attached patches are separated into three. The first one changes only > regular expression part mentioned above. The second one is NEWS update. > The third one removes unused arguments also for > scheme-syntax-propertize-sexp-comment . Please use them as you want. > > Also about copyright assignment, this is the first commitment to GNU, > and I have filled out the form and have emailed it to assign@gnu.org . > > Thanks > -- Jakub T. Jankiewicz, Senior Front-End Developer https://jcubic.pl/me https://lips.js.org https://koduj.org