From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Madhu Newsgroups: gmane.emacs.devel Subject: please consider keeping defadvice around Date: Sat, 09 Sep 2023 20:35:38 +0530 (IST) Message-ID: <20230909.203538.519870170190818818.enometh@meer.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23917"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 09 17:06:28 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qezXY-0005zy-7o for ged-emacs-devel@m.gmane-mx.org; Sat, 09 Sep 2023 17:06:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qezWv-00047L-32; Sat, 09 Sep 2023 11:05:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qezWu-00047C-A4 for emacs-devel@gnu.org; Sat, 09 Sep 2023 11:05:48 -0400 Original-Received: from smtp3.ctinetworks.com ([205.166.61.187]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qezWs-0002OP-7j for emacs-devel@gnu.org; Sat, 09 Sep 2023 11:05:48 -0400 Original-Received: from smtp5.ctinetworks.com (smtp5.ctinetworks.com [205.166.61.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp3.ctinetworks.com (Postfix) with ESMTPS id 3732A306F089 for ; Sat, 9 Sep 2023 11:05:44 -0400 (EDT) Original-Received: from localhost (unknown [117.254.37.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: enometh@meer.net) by smtp5.ctinetworks.com (Postfix) with ESMTPSA id 9F00116604B for ; Sat, 9 Sep 2023 11:05:41 -0400 (EDT) X-Mailer: Mew version 6.9 on Emacs 30.0.50 X-ctinetworks-Information: Please contact the ISP for more information X-ctinetworks-MailScanner-ID: 3732A306F089.ABF70 X-ctinetworks-VirusCheck: Found to be clean X-ctinetworks-Watermark: 1695135945.35693@tFVQAqDe14RGiOszSq3oRA Received-SPF: pass client-ip=205.166.61.187; envelope-from=enometh@meer.net; helo=smtp3.ctinetworks.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310408 Archived-At: * commit 27ed565ec6163c499191b62a4cee10d99019aa38 | Author: Stefan Monnier | AuthorDate: Thu Aug 3 23:41:11 2023 -0400 | Commit: Stefan Monnier | CommitDate: Thu Aug 3 23:41:11 2023 -0400 | | * lisp/emacs-lisp/advice.el (defadvice): Mark as obsolete defadvice is a carefully designed and well documented piece of software. It provides a very useful abstraction on how to define advice and provides easy hooks to disable specific advice, unadvise and redefine advices. At the least this is essential porcelein which has to be reimplemente on top of the add-function add-advice plumbing. I can see no good reason to deprecate and remove defadvice which is valuble for both its design and beautiful documentation. Removal would only force the user to use the new sparesly-documented interfaces to produce write-only opaque unnamed-closure-based undebuggable code.