From: Konstantin Kharlamov <Hi-Angel@yandex.ru>
To: 61490@debbugs.gnu.org
Subject: bug#61490: [PATCH v2] Increase BLOCK_ALIGN from 1024 to 32768
Date: Thu, 16 Feb 2023 18:05:09 +0300 [thread overview]
Message-ID: <20230216150509.27039-1-Hi-Angel@yandex.ru> (raw)
In-Reply-To: <20230213200006.663502-1-Hi-Angel@yandex.ru>
Originally discovered by Tyler Dodge in his article "Significant Garbage
Collection Improvement For Emacs".
While testing this change on Archlinux system with Intel i5-7200U CPU,
average time of garbage collection gets reduced by ≈25%. Other users
report improvements up to 50%. While monitoring PSS of emacs with and
without customizations loaded before and after the patch, no
statistically significant differences were discovered. So overall, this
change is a win.
* src/alloc.c (BLOCK_ALIGN): increase from 1024 to 32768
---
v2:
* Richard Stallman: don't use non-ASCII in the description
* Me: mention the report by Ihor Radchenko where performance
improved by 50%
src/alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/alloc.c b/src/alloc.c
index c25e81d1dde..d278b01343d 100644
--- a/src/alloc.c
+++ b/src/alloc.c
@@ -1083,7 +1083,7 @@ lisp_free (void *block)
BLOCK_BYTES and guarantees they are aligned on a BLOCK_ALIGN boundary. */
/* Byte alignment of storage blocks. */
-#define BLOCK_ALIGN (1 << 10)
+#define BLOCK_ALIGN (1 << 15)
verify (POWER_OF_2 (BLOCK_ALIGN));
/* Use aligned_alloc if it or a simple substitute is available.
--
2.39.2
next prev parent reply other threads:[~2023-02-16 15:05 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 20:00 bug#61490: [PATCH 0/1] Increase BLOCK_ALIGN from 2¹⁰to 2¹⁵ Konstantin Kharlamov
2023-02-13 20:00 ` bug#61489: [PATCH 1/1] " Konstantin Kharlamov
[not found] ` <handler.61489.B.167631844622733.ack@debbugs.gnu.org>
2023-02-13 20:05 ` bug#61489: Acknowledgement ([PATCH 1/1] Increase BLOCK_ALIGN from 2¹⁰to 2¹⁵) Konstantin Kharlamov
2023-02-14 3:29 ` Eli Zaretskii
2023-02-14 6:45 ` Konstantin Kharlamov
2023-02-14 6:56 ` Konstantin Kharlamov
2023-02-14 8:20 ` Robert Pluim
2023-02-14 8:22 ` Konstantin Kharlamov
2023-02-14 8:29 ` Konstantin Kharlamov
2023-02-14 13:26 ` Eli Zaretskii
2023-02-15 7:03 ` bug#61489: Open a bug report with git-send-email (was: bug#61489: Acknowledgement ([PATCH 1/1] Increase BLOCK_ALIGN from 2¹⁰to 2¹⁵)) Kévin Le Gouguec
2023-02-13 22:30 ` bug#61489: [PATCH 1/1] Increase BLOCK_ALIGN from 2¹⁰to 2¹⁵ Ihor Radchenko
2023-02-16 15:07 ` bug#61489: [PATCH v2] Increase BLOCK_ALIGN from 1024 to 32768 Konstantin Kharlamov
2023-02-23 15:30 ` Konstantin Kharlamov
2023-02-23 15:49 ` Robert Pluim
2023-02-23 15:53 ` Konstantin Kharlamov
2023-02-23 15:57 ` bug#61490: " Robert Pluim
2023-02-23 16:05 ` Konstantin Kharlamov
2023-02-23 16:34 ` Robert Pluim
2023-02-23 16:41 ` bug#61489: bug#61490: " Eli Zaretskii
2023-02-24 10:50 ` Robert Pluim
2023-02-27 10:30 ` bug#61490: " Konstantin Kharlamov
2023-02-23 16:40 ` Eli Zaretskii
2023-03-04 11:26 ` Eli Zaretskii
2023-03-04 15:00 ` Eli Zaretskii
2023-03-04 15:33 ` Konstantin Kharlamov
2023-03-04 18:58 ` Konstantin Kharlamov
2023-03-04 19:53 ` Eli Zaretskii
2023-03-04 19:58 ` Konstantin Kharlamov
2023-03-05 5:47 ` Eli Zaretskii
[not found] ` <handler.61490.B.167631845222751.ack@debbugs.gnu.org>
2023-02-13 20:05 ` bug#61490: Acknowledgement ([PATCH 0/1] Increase BLOCK_ALIGN from 2¹⁰to 2¹⁵) Konstantin Kharlamov
2023-02-16 4:59 ` bug#61490: [PATCH 0/1] Increase BLOCK_ALIGN from 2¹â°to 2¹ⵠRichard Stallman
2023-02-16 6:46 ` Konstantin Kharlamov
2023-02-16 9:31 ` Gregory Heytings
2023-02-21 5:22 ` bug#61490: [PATCH 0/1] Increase BLOCK_ALIGN from 2ùâ°to 2ùâµ Richard Stallman
2023-02-16 15:05 ` Konstantin Kharlamov [this message]
2023-02-16 15:29 ` bug#61490: [PATCH v2] Increase BLOCK_ALIGN from 1024 to 32768 Robert Pluim
2023-02-16 16:48 ` Konstantin Kharlamov
2023-02-16 17:00 ` Konstantin Kharlamov
2023-02-16 17:02 ` Robert Pluim
2023-03-03 10:44 ` Konstantin Kharlamov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230216150509.27039-1-Hi-Angel@yandex.ru \
--to=hi-angel@yandex.ru \
--cc=61490@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.