all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* tree-sitter: conceptional problem solvable at Emacs' level?
@ 2023-02-09  8:09 Holger Schurig
  2023-02-09  8:17 ` Po Lu
  2023-02-09 16:25 ` Ergus
  0 siblings, 2 replies; 26+ messages in thread
From: Holger Schurig @ 2023-02-09  8:09 UTC (permalink / raw)
  To: Emacs-devel

Hi, I run branch emacs-29 since some time with great success. And now I
wanted to test out tree-sitter and c++-test-mode. Unfortunately, I
stumbled into some conceptional problems and wonder if this is actually
solvable by Emacs, or if some would need a completely new grammar.

The issue is: tree-sitter doesn't work well with C macros.

I program a lot in C++/Qt. So let's look at this (valid) C++ program:

-----------------------------------------------------------------------------
#include <QObject>

class Test : public QObject
{
        Q_OBJECT
public:
        Test() : QObject() {};
public slots:
        void someSlot() {};
};
-----------------------------------------------------------------------------

If have the libraries installed (e.g. qtbase5-dev on Debian), you can
compile this perfectly.

However, tree-sitter produces a garbage syntax tree:

- contain some bitfield node (which isn't really there)
- contains an error node (despite the code being compilable)

And as a result, BOTH the indentation and the font-locking is wrong.


Would I need to create a tree-sitter grammar in JavaScript that
understands this macro-enhanced C++?   That would be quite difficult.
Or will there be a method to add some kind of tiny-preprocessor to
c++-ts-mode, so that it can substitute "Q_OBJECT", "signals" and "slots"
with nothing before handing things over to tree-sitter?


In comparison, I could teach the old cc-mode about this macro-enriched
C++ just with

  (c-add-style "qt-gnu"
               '("gnu" (c-access-key .
                       "\\<\\(signals\\|public\\|protected\\|private\\|public
               slots\\|protected slots\\|private slots\\):")))


I guess that a lot of C and C++ programs use macros. And if there is no
simple way to aid tree-sitter in understanding this, then I fear
tree-sitter enhanced modes will often be unusable on them.



^ permalink raw reply	[flat|nested] 26+ messages in thread

end of thread, other threads:[~2023-04-16 19:21 UTC | newest]

Thread overview: 26+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-09  8:09 tree-sitter: conceptional problem solvable at Emacs' level? Holger Schurig
2023-02-09  8:17 ` Po Lu
2023-02-09  8:50   ` Eli Zaretskii
2023-02-09 10:13     ` Po Lu
2023-02-09 10:55       ` Eli Zaretskii
2023-02-10  7:33   ` Yuan Fu
2023-02-10  8:42     ` Eli Zaretskii
     [not found]       ` <CAOpc7mHX6s0B8vdDee+9FMvQejGTSL3jzgwVekS7Esg-AOf=jw@mail.gmail.com>
2023-02-10 11:48         ` Eli Zaretskii
2023-02-11  2:17           ` Po Lu
2023-02-11  6:25             ` Konstantin Kharlamov
2023-02-11  6:36               ` Konstantin Kharlamov
2023-02-11  6:51                 ` Theodor Thornhill
2023-02-11  7:11                   ` Konstantin Kharlamov
2023-02-11  7:53                     ` Konstantin Kharlamov
2023-02-11  8:22                     ` Konstantin Kharlamov
2023-02-11  8:41                       ` Theodor Thornhill
2023-02-11  9:37                         ` Konstantin Kharlamov
2023-02-11 10:25                           ` Konstantin Kharlamov
2023-02-11  8:43                     ` Eli Zaretskii
2023-04-16 19:21                   ` Konstantin Kharlamov
2023-02-11  9:34       ` Ihor Radchenko
2023-02-11 10:42         ` Eli Zaretskii
2023-02-11 13:58         ` Lynn Winebarger
2023-02-09 16:25 ` Ergus
2023-02-09 20:09   ` Dmitry Gutov
2023-02-10  7:41     ` Holger Schurig

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.