From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "e190@163.com" Newsgroups: gmane.emacs.bugs Subject: bug#60296: Re: bug#60296: The imenu is not created properly in c-ts-mode Date: Mon, 26 Dec 2022 15:58:47 +0800 Message-ID: <2022122615584707191012@163.com> References: <202212241731446537597@163.com>, , <83bkns3rf2.fsf@gnu.org>, <5C8629D4-6B5D-4478-83E2-9D4027C0F8C7@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_001_NextPart256082002326_=----" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23592"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60296 <60296@debbugs.gnu.org> To: casouri , "Eli Zaretskii" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 26 09:00:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p9iPF-0005xo-MZ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Dec 2022 09:00:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p9iP2-0004Ok-Um; Mon, 26 Dec 2022 03:00:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p9iOy-0004O7-8o for bug-gnu-emacs@gnu.org; Mon, 26 Dec 2022 03:00:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p9iOx-0001j3-GL for bug-gnu-emacs@gnu.org; Mon, 26 Dec 2022 03:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p9iOw-0003Tv-V2 for bug-gnu-emacs@gnu.org; Mon, 26 Dec 2022 03:00:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <202212241731446537597@163.com> Resent-From: "e190@163.com" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Dec 2022 08:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60296 X-GNU-PR-Package: emacs Original-Received: via spool by 60296-submit@debbugs.gnu.org id=B60296.167204154813289 (code B ref 60296); Mon, 26 Dec 2022 08:00:02 +0000 Original-Received: (at 60296) by debbugs.gnu.org; 26 Dec 2022 07:59:08 +0000 Original-Received: from localhost ([127.0.0.1]:50661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9iO4-0003SE-2I for submit@debbugs.gnu.org; Mon, 26 Dec 2022 02:59:08 -0500 Original-Received: from m12.mail.163.com ([220.181.12.217]:34784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9iNz-0003Rd-Mp for 60296@debbugs.gnu.org; Mon, 26 Dec 2022 02:59:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:Mime-Version:Message-ID: Content-Type; bh=zK0JV57umtpTthj/cSQJtcDmWscj1kWOCNr3u7HcGAM=; b=RIvnKOVhFwYVjZm4vEY3/ty/In4NMKVvT/l4/uBza1xJrsVcpc4dR4aingKIVf OZwM+AK1Cp40aYL49xc2WZ+Xk5byYHqZgPTM447diNGP9V/jvRlm9xGDEU1xeSUX QlQPMKnU+Tmvm0Y0hl4sCioncEdtddZA4rvOPKf9H+lZk= Original-Received: from DESKTOP-ASPN5E7 (unknown [118.114.239.159]) by zwqz-smtp-mta-g2-2 (Coremail) with SMTP id _____wC3GRw4VKljgi0VAA--.4283S2; Mon, 26 Dec 2022 15:58:49 +0800 (CST) X-Priority: 3 X-GUID: 69EA9178-9D25-4B8E-9640-8A6FC9275B46 X-Has-Attach: no X-Mailer: Foxmail 7.2.23.121[cn] X-CM-TRANSID: _____wC3GRw4VKljgi0VAA--.4283S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxZr4ktFWfury7WrW5Jr47Jwb_yoW5Jw1Dpa yfZF1UKa1kA3yUJan7Kr4xur4Fk3y8J3WrXF1UA342grykCryfGa1UKrZ8K3909r47uw48 Xa1IgrsrZr1rZF7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zMNtInUUUUU= X-Originating-IP: [118.114.239.159] X-CM-SenderInfo: bhrziqqrwthudrp/xtbBSRDj01aEFtzNWwABsm X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251889 Archived-At: This is a multi-part message in MIME format. ------=_001_NextPart256082002326_=---- Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 Pj4gT24gRGVjIDI0LCAyMDIyLCBhdCAxMDo1MyBQTSwgRWxpIFphcmV0c2tpaSA8ZWxpekBnbnUu b3JnPiB3cm90ZToNCj4+DQo+Pj4gQ2M6IDYwMjk2LWRvbmVAZGViYnVncy5nbnUub3JnDQo+Pj4g RnJvbTogWXVhbiBGdSA8Y2Fzb3VyaUBnbWFpbC5jb20+DQo+Pj4gRGF0ZTogU2F0LCAyNCBEZWMg MjAyMiAxOTowMDoyMSAtMDgwMA0KPj4+DQo+Pj4+IEZyb206IHNuaXBlciA8ZTE5MEAxNjMuY29t Pg0KPj4+PiBUbzogYnVnLWdudS1lbWFjc0BnbnUub3JnDQo+Pj4+IFN1YmplY3Q6IDI5LjAuNjA7 IFRoZSBpbWVudSBpcyBub3QgY3JlYXRlZCBwcm9wZXJseSBpbiBjLXRzLW1vZGUuDQo+Pj4+DQo+ Pj4+IGBgYCBjDQo+Pj4+IGNoYXIgKnRlc3QoaW50IHNpemUpew0KPj4+PiByZXR1cm4gTlVMTDsN Cj4+Pj4gfQ0KPj4+PiBgYGANCj4+Pj4gSWYgYy10cy1tb2RlIGlzIGVuYWJsZWQgaW4gYSBjIGZp bGUsIHRoZSBpbWVudSBjcmVhdGVkIHdpbGwgYmUgW2AgdGVzdChpbnQgc2l6ZSlgXSBpZiB0aGUg cmV0dXJuIHR5cGUgb2YgdGhlIGZ1bmN0aW9uIGlzIGENCj4+Pj4gcG9pbnRlci4NCj4+Pj4gVGhl IGV4cGVjdGVkIGRpc3BsYXkgc2hvdWxkIGp1c3QgYmUgdGhlIGZ1bmN0aW9uIG5hbWUgW2AgdGVz dCBgXSwgd2l0aCBubyBzdWJzZXF1ZW50IGFyZ3VtZW50cw0KPj4+DQo+Pj4gVGhhbmtzLCB0aGlz IHNob3VsZCBiZSBmaXhlZCBub3cuDQo+Pg0KPj4gVGhpcyBjaGFuZ2UgbGVhZHMgdG8NCj4+DQo+ PiAgSW4gYy10cy1tb2RlLS1mb250aWZ5LWRlY2xhcmF0b3I6DQo+PiAgcHJvZ21vZGVzL2MtdHMt bW9kZS5lbDo0MDU6Njk6IFdhcm5pbmc6IFVudXNlZCBsZXhpY2FsIGFyZ3VtZW50IGBhcmdzJw0K Pj4NCj4+IEFuZCAiJnJlc3QgYXJncyIgaXMgaW5kZWVkIHVudXNlZCB0aGVyZSwgQUZBSUNULg0K IA0KPk15IGJhZC4gSeKAmXZlIGZpeGVkIHRoYXQgYnkgY2hhbmdpbmcgYXJncyB0byBfLg0KSGks IFl1YW46DQoNCkkgdGVzdGVkIGl0IGluIHRoZSBsYXRlc3QgdmVyc2lvbiBhbmQgZm91bmQgc2V2 ZXJhbCBtb3JlIGlzc3Vlcy4NCmBgYCBjDQppbnQgbWFpbihpbnQgYXJnYywgY2hhciAqYXJndltd KQ0Kew0KLi4uLi4NCiAgIHN0cnVjdCBuYW1lX3QgbmFtZSA9IChzdHJ1Y3QgbmFtZV90KW5hbWU7 DQogICBuYW1lLmEgPSBzaXplb2Yoc3RydWN0IG5hbWVfdCk7DQouLi4uLg0KfQ0KYGBgDQpJZiBG b3JjZWQgY29udmVyc2lvbiBvciBgIHNpemVvZihzdHJ1Y3QgbmFtZV90KSBgIG9jY3VycyBpbiBh IGZ1bmN0aW9uLCBpdCB3aWxsIG9jY3VyIGluIHRoZSBTdHJ1Y3QgZW50cnkgb2YgaW1lbnUuDQoN Cg0KYGBgIGMNCmludCBmdW5jXzEoaW50IHYpOyAvLyA8LS0gZnVuY3Rpb24gZGVjbGFyYXRpb24N CmludCBtYWluKGludCBhcmdjLCBjaGFyICphcmd2W10pDQp7DQp9DQpgYGANCklmIHRoZXJlIGlz IGEgZnVuY3Rpb24gZGVjbGFyYXRpb24gaW4gdGhlIGMgZmlsZSwgaXQgd2lsbCBhbHNvIGFwcGVh ciBpbiBpbWVudSdzIFZhcmlhYmxlIGVudHJ5Lg0KDQoNCg0KZTE5MEAxNjMuY29tDQogDQpGcm9t OiBZdWFuIEZ1DQpEYXRlOiAyMDIyLTEyLTI1IDE2OjMxDQpUbzogRWxpIFphcmV0c2tpaQ0KQ0M6 IDYwMjk2OyBlMTkwDQpTdWJqZWN0OiBSZTogYnVnIzYwMjk2OiBUaGUgaW1lbnUgaXMgbm90IGNy ZWF0ZWQgcHJvcGVybHkgaW4gYy10cy1tb2RlDQogDQogDQo+IE9uIERlYyAyNCwgMjAyMiwgYXQg MTA6NTMgUE0sIEVsaSBaYXJldHNraWkgPGVsaXpAZ251Lm9yZz4gd3JvdGU6DQo+IA0KPj4gQ2M6 IDYwMjk2LWRvbmVAZGViYnVncy5nbnUub3JnDQo+PiBGcm9tOiBZdWFuIEZ1IDxjYXNvdXJpQGdt YWlsLmNvbT4NCj4+IERhdGU6IFNhdCwgMjQgRGVjIDIwMjIgMTk6MDA6MjEgLTA4MDANCj4+IA0K Pj4+IEZyb206IHNuaXBlciA8ZTE5MEAxNjMuY29tPg0KPj4+IFRvOiBidWctZ251LWVtYWNzQGdu dS5vcmcNCj4+PiBTdWJqZWN0OiAyOS4wLjYwOyBUaGUgaW1lbnUgaXMgbm90IGNyZWF0ZWQgcHJv cGVybHkgaW4gYy10cy1tb2RlLg0KPj4+IA0KPj4+IGBgYCBjDQo+Pj4gY2hhciAqdGVzdChpbnQg c2l6ZSl7DQo+Pj4gcmV0dXJuIE5VTEw7DQo+Pj4gfQ0KPj4+IGBgYA0KPj4+IElmIGMtdHMtbW9k ZSBpcyBlbmFibGVkIGluIGEgYyBmaWxlLCB0aGUgaW1lbnUgY3JlYXRlZCB3aWxsIGJlIFtgIHRl c3QoaW50IHNpemUpYF0gaWYgdGhlIHJldHVybiB0eXBlIG9mIHRoZSBmdW5jdGlvbiBpcyBhDQo+ Pj4gcG9pbnRlci4NCj4+PiBUaGUgZXhwZWN0ZWQgZGlzcGxheSBzaG91bGQganVzdCBiZSB0aGUg ZnVuY3Rpb24gbmFtZSBbYCB0ZXN0IGBdLCB3aXRoIG5vIHN1YnNlcXVlbnQgYXJndW1lbnRzDQo+ PiANCj4+IFRoYW5rcywgdGhpcyBzaG91bGQgYmUgZml4ZWQgbm93Lg0KPiANCj4gVGhpcyBjaGFu Z2UgbGVhZHMgdG8NCj4gDQo+ICBJbiBjLXRzLW1vZGUtLWZvbnRpZnktZGVjbGFyYXRvcjoNCj4g IHByb2dtb2Rlcy9jLXRzLW1vZGUuZWw6NDA1OjY5OiBXYXJuaW5nOiBVbnVzZWQgbGV4aWNhbCBh cmd1bWVudCBgYXJncycNCj4gDQo+IEFuZCAiJnJlc3QgYXJncyIgaXMgaW5kZWVkIHVudXNlZCB0 aGVyZSwgQUZBSUNULg0KIA0KTXkgYmFkLiBJ4oCZdmUgZml4ZWQgdGhhdCBieSBjaGFuZ2luZyBh cmdzIHRvIF8uDQogDQpZdWFuDQo= ------=_001_NextPart256082002326_=---- Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable = =0A
>> On Dec 24, 2022, at 1= 0:53 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>>
>>> Cc: 60296-done@debbugs.gnu.org
>>> F= rom: Yuan Fu <casouri@gmail.com>
>>> Date: Sat, 2= 4 Dec 2022 19:00:21 -0800
>>>
>>>>= ; From: sniper <e190@163.com>
>>>> To: bug-gnu= -emacs@gnu.org
>>>> Subject: 29.0.60; The imenu is n= ot created properly in c-ts-mode.
>>>>
>= ;>>> ``` c
>>>> char *test(int size){
=
>>>> return NULL;
>>>> }
= >>>> ```
>>>> If c-ts-mode is enabled in= a c file, the imenu created will be [` test(int size)`] if the return typ= e of the function is a
>>>> pointer.
>&= gt;>> The expected display should just be the function name [` test = `], with no subsequent arguments
>>>
>>= > Thanks, this should be fixed now.
>>
>&g= t; This change leads to
>>
>>  In c-t= s-mode--fontify-declarator:
>>  progmodes/c-ts-mode.e= l:405:69: Warning: Unused lexical argument `args'
>>
=
>> And "&rest args" is indeed unused there, AFAICT.
 
>My bad. I=E2=80=99ve fixed that by changing args t= o _.
Hi, Yuan:

I tested it in the latest versi= on and found several more issues.
``` c
int main(int = argc, char *argv[])
{
.....
   struct name_t name =3D (st= ruct name_t)name;
  &= nbsp;name.a =3D sizeof(struct name_t);
.....
}=
=0A
```
If Forced conversion or ` sizeof(struct = name_t) ` occurs in a function, it will occur in the Struct entry of i= menu.


``` c
int func_1(int v); // <-- = function declaration
int main(int argc, char *argv[])
{
}
```
If there is a function declaration in the c file, i= t will also appear in imenu's Variable entry.

=0A
e190@163.co= m
=0A
 
<= div style=3D"border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm = 0cm 0cm">
From: Yuan Fu
Date: 2022-12-25 16:31
To: Eli Zaretskii<= /div>
Subject:&nbs= p;Re: bug#60296: The imenu is not created properly in c-ts-mode
 
=0A
 
=0A
> On Dec 24, 2= 022, at 10:53 PM, Eli Zaretskii <eliz@gnu.org> wrote:
=0A
&= gt;
=0A
>> Cc: 60296-done@debbugs.gnu.org
=0A
>= ;> From: Yuan Fu <casouri@gmail.com>
=0A
>> Date: = Sat, 24 Dec 2022 19:00:21 -0800
=0A
>>
=0A
>&g= t;> From: sniper <e190@163.com>
=0A
>>> To: bug= -gnu-emacs@gnu.org
=0A
>>> Subject: 29.0.60; The imenu i= s not created properly in c-ts-mode.
=0A
>>>
=0A>>> ``` c
=0A
>>> char *test(int size){=0A
>>> return NULL;
=0A
>>> }
=0A>>> ```
=0A
>>> If c-ts-mode is enabled in a = c file, the imenu created will be [` test(int size)`] if the return type o= f the function is a
=0A
>>> pointer.
=0A
>&g= t;> The expected display should just be the function name [` test `], w= ith no subsequent arguments
=0A
>>
=0A
>> T= hanks, this should be fixed now.
=0A
>
=0A
> This= change leads to
=0A
>
=0A
>  In c-ts-mode--= fontify-declarator:
=0A
>  progmodes/c-ts-mode.el:405:69:= Warning: Unused lexical argument `args'
=0A
>
=0A
&= gt; And "&rest args" is indeed unused there, AFAICT.
=0A
&nbs= p;
=0A
My bad. I=E2=80=99ve fixed that by changing args to _.=0A
 
=0A
Yuan
=0A
=0A ------=_001_NextPart256082002326_=------