From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?=C5=81ukasz?= Stelmach Newsgroups: gmane.emacs.bugs Subject: bug#59458: [PATCH] Fix tracing for advanced scoring Date: Mon, 21 Nov 2022 22:30:55 +0100 Message-ID: <20221121213055.2387178-1-stlman@poczta.fm> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36407"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?UTF-8?Q?=C5=81ukasz?= Stelmach To: 59458@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 21 22:32:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxEOj-0009H0-EJ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Nov 2022 22:32:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxEOa-0000VB-IC; Mon, 21 Nov 2022 16:32:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxEOY-0000Ux-KN for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 16:32:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxEOY-00011k-AN for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 16:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxEOX-0007Qy-Qs for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 16:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=C5=81ukasz?= Stelmach Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Nov 2022 21:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59458 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166906629228538 (code B ref -1); Mon, 21 Nov 2022 21:32:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Nov 2022 21:31:32 +0000 Original-Received: from localhost ([127.0.0.1]:49013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxEO4-0007QD-FZ for submit@debbugs.gnu.org; Mon, 21 Nov 2022 16:31:32 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:39226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxEO2-0007Q5-7C for submit@debbugs.gnu.org; Mon, 21 Nov 2022 16:31:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxEO1-0000Tc-VR for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 16:31:30 -0500 Original-Received: from smtpo50.interia.pl ([217.74.67.50]) by eggs.gnu.org with esmtps (TLS1.2:RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxENz-0000xG-3d for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 16:31:29 -0500 Original-Received: from localhost (89-64-89-35.dynamic.chello.pl [89.64.89.35]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by www.poczta.fm (INTERIA.PL) with ESMTPSA; Mon, 21 Nov 2022 22:31:18 +0100 (CET) X-Mailer: git-send-email 2.30.2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=interia.pl; s=biztos; t=1669066280; bh=mUENPalVoUdYAl0MIPTQZeXEl4PSEqoIRADWgux7gIg=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=qf5t/1V3Ch4mhhvokDcb7e8DMJE21eY7LYur4+40DsNoSRjrxYHicXPDXlWs050r+ HNNQ8s0hXbeYgwRBsWDFvvzP7K5vysyVz3t34ACRoNjwtqZGHCa5hkjts9PIs/GJ22 GfISY3ltac1hQPy29k9Ecvgw9VE/S6j5qHkakxpo= Received-SPF: pass client-ip=217.74.67.50; envelope-from=stlman@poczta.fm; helo=smtpo50.interia.pl X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248576 Archived-At: * lisp/gnus/gnus-logic.el (gnus-score-advanced): Move the tracing code outside of if so it's executed for both branches. --- lisp/gnus/gnus-logic.el | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lisp/gnus/gnus-logic.el b/lisp/gnus/gnus-logic.el index c1b559ba6f4..346d8a28910 100644 --- a/lisp/gnus/gnus-logic.el +++ b/lisp/gnus/gnus-logic.el @@ -71,11 +71,11 @@ (+ (cdr score) new-score)) (push (cons (mail-header-number gnus-advanced-headers) new-score) - gnus-newsgroup-scored) - (when trace - (push (cons "A file" rule) - ;; Must be synced with `gnus-score-edit-file-at-point'. - gnus-score-trace))))))) + gnus-newsgroup-scored)) + (when trace + (push (cons "A file" rule) + ;; Must be synced with `gnus-score-edit-file-at-point'. + gnus-score-trace)))))) (defun gnus-advanced-score-rule (rule) "Apply RULE to `gnus-advanced-headers'." -- 2.30.2