From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Noah Friedman Newsgroups: gmane.emacs.bugs Subject: bug#56459: 29.0.50; Edebug disables Eldoc Date: Sun, 31 Jul 2022 18:59:49 -0700 (PDT) Message-ID: <20220731185949.978182.FMU217810@trabanten-schwein.prv.splode.com> References: <87zghieol4.fsf@gmail.com> <871qurzzyv.fsf@gnus.org> <83pmibzx0k.fsf@gnu.org> Reply-To: Noah Friedman Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13945"; mail-complaints-to="usenet@ciao.gmane.io" Cc: max.brieiev@gmail.com, larsi@gnus.org, 56459@debbugs.gnu.org To: eliz@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 01 04:01:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIKk4-0003Wt-No for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Aug 2022 04:01:13 +0200 Original-Received: from localhost ([::1]:45758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oIKk3-0006kF-GW for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Jul 2022 22:01:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIKju-0006k7-Ks for bug-gnu-emacs@gnu.org; Sun, 31 Jul 2022 22:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49139) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oIKju-0004Eg-Ak for bug-gnu-emacs@gnu.org; Sun, 31 Jul 2022 22:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oIKju-0004Ln-1X for bug-gnu-emacs@gnu.org; Sun, 31 Jul 2022 22:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noah Friedman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Aug 2022 02:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56459 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 56459-submit@debbugs.gnu.org id=B56459.165931920516559 (code B ref 56459); Mon, 01 Aug 2022 02:01:02 +0000 Original-Received: (at 56459) by debbugs.gnu.org; 1 Aug 2022 02:00:05 +0000 Original-Received: from localhost ([127.0.0.1]:38888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIKiz-0004J1-3N for submit@debbugs.gnu.org; Sun, 31 Jul 2022 22:00:05 -0400 Original-Received: from bacon-event-horizon.splode.com ([74.207.245.10]:41950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIKit-0004Hy-JK for 56459@debbugs.gnu.org; Sun, 31 Jul 2022 22:00:03 -0400 Original-Received: from trabanten-schwein.prv.splode.com (97-113-90-179.tukw.qwest.net [97.113.90.179]) (authenticated bits=0) by bacon-event-horizon.splode.com (8.17.1/8.17.1) with ESMTPSA id 2711xoCj290647 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 31 Jul 2022 18:59:56 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=splode.com; s=splode-20130101; t=1659319197; bh=+2Z5yPcJC6Hko5aFJsu1zAH5qkxNAMyn6WkU5gpD0n8=; h=From:To:Cc:Subject:Reply-To:In-Reply-To:References:Date:From; b=la8m/odnNsL2tAxNEMpjl5LTtRBqd4kliYP4jmkGDF2luAQqfmJ34lTXFTC+vSbfm gaRyqiJqdCyIjQfA7pcgGk1762AiNTu8Es8kO/TAtGfoscNGruSrUDqFBDVvPNPina QzzcDWJAS8G05UkfSZDJ47rrAf1MkMhaOt0d+7A4= In-Reply-To: <83pmibzx0k.fsf@gnu.org> (22-07-11 14:52:59+0300 eliz@gnu.org) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (bacon-event-horizon.splode.com [74.207.245.10]); Sun, 31 Jul 2022 18:59:57 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238383 Archived-At: Sorry I didn't see this message sooner. I seem to recall that the eldoc messages (which would show up as you're stepping through the debugger because point moves interactively) would obsure the evaluation results that edebug prints for each sexp. They both use the echo area and they're both in the same recursive-edit level but the echo area isn't currently active, so I'm not sure why `message' would append below any existing message rather than replacing it. If that's still the case, and I had to do it again I'd still prefer the edebug messages over the eldoc ones when both are active at once. In <83pmibzx0k.fsf@gnu.org> 2022-07-11 14:52:59+0300, Eli Zaretskii writes: >> Cc: 56459@debbugs.gnu.org >> From: Lars Ingebrigtsen >> Date: Mon, 11 Jul 2022 12:49:12 +0200 >> >> Max Brieiev writes: >> >> > 5. Observe that while you are typing any expression, eldoc does not >> > display any hints in the echo area. (Same issue exists in any other >> > elisp buffer with eldoc mode enabled, while Edebug is active.) >> >> This is due to this code: >> >> ;; Check various conditions about the current environment that might make >> ;; it undesirable to print eldoc messages right this instant. >> (defun eldoc-display-message-no-interference-p () >> "Return nil if displaying a message would cause interference." >> (not (or executing-kbd-macro >> (bound-and-true-p edebug-active) >> >> This was added by: >> >> commit 03a9c6d06a177fd9026779bcb952f906a7743690 >> Author: Noah Friedman >> AuthorDate: Mon Jul 24 00:38:34 2000 +0000 >> >> (eldoc-display-message-no-interference-p): Don't interfere with edebug. >> >> But it doesn't say in what way it interferes with edebug -- and removing >> that line, I don't really see any interference? But eldoc messages >> things slightly different now than two decades ago... >> >> Anybody know what this code is trying to do? > >AFAIK nowadays 'message' displays echo-area messages in a way that >doesn't interfere with existing messages (it displays them in brackets >at the end of the existing text), so I think the original problem >should no longer exist. > >Noah, can you verify that your original problem cannot be reproduced >if we remove the condition in eldoc-display-message-no-interference-p >that you added?