From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Werner LEMBERG Newsgroups: gmane.comp.lib.gnulib.bugs,gmane.emacs.devel Subject: Re: Emacs 28.1 doesn't compile on Mac OS 10.7.5 Date: Sun, 17 Apr 2022 11:09:34 +0000 (UTC) Message-ID: <20220417.130934.1262194427827407777.wl@gnu.org> References: <67901569-bf14-b973-9de2-0f5d68aafe96@cs.ucla.edu> <79eee929-3cbe-8a5c-8ef2-06517572d83a@cs.ucla.edu> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1315"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dports@macports.org, noloader@gmail.com, bug-gnulib@gnu.org, mattiase@acm.org, emacs-devel@gnu.org, fgunbin@fastmail.fm To: eggert@cs.ucla.edu Original-X-From: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane-mx.org@gnu.org Sun Apr 17 13:09:48 2022 Return-path: Envelope-to: gnu-bug-gnulib@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ng2mq-0000Be-My for gnu-bug-gnulib@m.gmane-mx.org; Sun, 17 Apr 2022 13:09:48 +0200 Original-Received: from localhost ([::1]:42880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ng2mo-0006yc-Uu for gnu-bug-gnulib@m.gmane-mx.org; Sun, 17 Apr 2022 07:09:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ng2mm-0006yR-DJ for bug-gnulib@gnu.org; Sun, 17 Apr 2022 07:09:44 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:33603) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ng2ml-0001dw-03 for bug-gnulib@gnu.org; Sun, 17 Apr 2022 07:09:44 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 30BE2240109 for ; Sun, 17 Apr 2022 13:09:40 +0200 (CEST) Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Kh6ll65lCz6tmH; Sun, 17 Apr 2022 13:09:39 +0200 (CEST) In-Reply-To: <79eee929-3cbe-8a5c-8ef2-06517572d83a@cs.ucla.edu> Received-SPF: pass client-ip=185.67.36.66; envelope-from=werner.lemberg@posteo.de; helo=mout02.posteo.de X-Spam_score_int: -39 X-Spam_score: -4.0 X-Spam_bar: ---- X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnulib" Xref: news.gmane.io gmane.comp.lib.gnulib.bugs:45789 gmane.emacs.devel:288547 Archived-At: >> maybe you should define a couple of macros like >> GNULIB_LLVM_CLANG_VER and GNULIB_APPLE_CLANG_VER > > I hope we don't need to do that. This is software archaeology (Mac > OS X 10.7.5 is so old that neither the Subject: line nor my patch > got its name right, and nobody mentioned the mistake :-) and these > macros would clutter the code for little benefit. Most > Clang-specific code nowadays shouldn't use Clang version numbers; it > should use __has_builtin etc. BTW, since MacPorts provides newer clang versions, it's fully OK with me if that old clang version gets rejected, in case this would yield a better solution. Werner