all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ergus <spacibba@aol.com>
To: Ulrich Mueller <ulm@gentoo.org>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: [PATCH] Re: etags name collision.
Date: Mon, 11 Apr 2022 21:53:50 +0200	[thread overview]
Message-ID: <20220411195350.7jhugti3e3vng6yx@Ergus> (raw)
In-Reply-To: <ua6crxvd3@gentoo.org>

On Mon, Apr 11, 2022 at 09:39:36PM +0200, Ulrich Mueller wrote:
>>>>>> On Mon, 11 Apr 2022, Ergus  wrote:
>
>> Now?
>
>> diff --git a/configure.ac b/configure.ac
>> index 185e4d0862..ace80aed56 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -267,6 +267,19 @@ AC_DEFUN
>>  fi
>>  AC_SUBST([with_mailutils])
>
>> +AC_ARG_WITH([ctags],
>> +  [AS_HELP_STRING([--with-ctags],
>> +     [rely on System ctags; this is the default if Universal ctags or
>> +      Exuberant ctags is installed])],
>> +  [],
>> +  [with_ctags=$with_features
>> +   if test "$with_ctags" = yes; then
>> +     (ctags --version | grep "GNU Emacs") 2>/dev/null || with_ctags=no
>
>Shouldn't this use the actual name under which Emacs will install ctags?
>That is, respect AC_ARG_PROGRAM?
>
Not needed, if it uses a different name there is no collision, so the
test is not needed.

>In its current form, it would break installation of the Gentoo package
>(or require us adding an explicit --without-ctags).
>
The option --with-ctags means rely on System ctags. I don't think you
need anything new.

>> +   fi])
>> +if test "$with_ctags" = no; then
>> +  with_ctags=
>> +fi
>
>I still think that any test for an installed binary is a bad idea, from
>a distro point of view. Note that distros typically build packages in an
>environment that is different from the one of the final target system.
>
Here I agree



  reply	other threads:[~2022-04-11 19:53 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220411124736.3qijvtearh6wlen7.ref@Ergus>
2022-04-11 12:47 ` etags name collision Ergus
2022-04-11 13:18   ` Eli Zaretskii
2022-04-11 13:38     ` Dmitry Gutov
2022-04-11 13:52       ` Ergus
2022-04-11 14:11         ` Eli Zaretskii
2022-04-11 14:25           ` Ergus
2022-04-12  7:16             ` Alfred M. Szmidt
2022-04-12  8:30               ` Andreas Schwab
2022-04-12 10:48               ` Ergus
2022-04-12 10:51                 ` Po Lu
2022-04-12 11:03                   ` Ergus
2022-04-12 11:13                   ` Dmitry Gutov
2022-04-12 11:28                     ` Po Lu
2022-04-12 13:45                       ` Alfred M. Szmidt
2022-04-12 14:29                         ` Dmitry Gutov
2022-04-12 15:36                           ` Óscar Fuentes
2022-04-12 17:13                           ` Ergus
2022-04-12 13:45                   ` Alfred M. Szmidt
2022-04-12 13:45                 ` Alfred M. Szmidt
2022-04-12 16:40                   ` Ergus
2022-04-12 17:21                     ` Alfred M. Szmidt
2022-04-12 17:48                       ` Ergus
2022-04-12 19:50                         ` Alfred M. Szmidt
2022-04-12 20:49                           ` Dmitry Gutov
2022-04-13  5:45                             ` Alfred M. Szmidt
2022-04-12 17:53                       ` Stefan Monnier
2022-04-11 13:59       ` Andreas Schwab
2022-04-11 14:07       ` Eli Zaretskii
2022-04-11 13:47     ` Ergus
2022-04-11 14:09       ` Eli Zaretskii
2022-04-11 14:18         ` Ergus
2022-04-11 15:46         ` [PATCH] " Ergus
2022-04-11 15:51           ` Eli Zaretskii
2022-04-11 16:19             ` Ergus
2022-04-11 16:40               ` Eli Zaretskii
2022-04-11 19:19                 ` Ergus
2022-04-11 19:39                   ` Ulrich Mueller
2022-04-11 19:53                     ` Ergus [this message]
2022-04-11 21:04                       ` Ulrich Mueller
2022-04-11 22:20                         ` Ergus
2022-04-12  7:21                           ` Alfred M. Szmidt
2022-04-12  7:34                             ` Ulrich Mueller
2022-04-12 10:53                             ` Ergus
2022-04-12  2:28                       ` Eli Zaretskii
2022-04-12  2:43                         ` Po Lu
2022-04-12  5:03                         ` Ulrich Mueller
2022-04-12 11:13                           ` Ergus
2022-04-12 11:48                             ` Eli Zaretskii
2022-04-12 11:56                               ` Eli Zaretskii
2022-04-12 12:50                             ` Ulrich Mueller
2022-04-12  7:16                         ` Alfred M. Szmidt
2022-04-12 12:15                   ` Eli Zaretskii
2022-04-11 16:46         ` Stefan Monnier
2022-04-11 17:01           ` Eli Zaretskii
2022-04-11 17:41             ` Stefan Monnier
2022-04-11 18:15               ` Eli Zaretskii
2022-04-11 19:11                 ` Ulrich Mueller
2022-04-12  7:42                 ` Thierry Volpiatto
2022-04-11 18:15               ` Ergus
2022-04-11 23:09               ` Ergus
2022-04-11 14:10     ` Andreas Schwab
2022-04-11 13:56   ` Kaushal Modi
2022-04-11 14:16     ` Óscar Fuentes
2022-04-12  3:19   ` Richard Stallman
2022-04-12  7:16     ` Alfred M. Szmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220411195350.7jhugti3e3vng6yx@Ergus \
    --to=spacibba@aol.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=ulm@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.