Re: Select completions from the minibuffer

[Ergus <spacibba@aol.com>]

On Tue, Mar 22, 2022 at 04:49:59PM +0200, Eli Zaretskii wrote:
>> Date: Tue, 22 Mar 2022 15:18:15 +0100
>> From: Ergus <spacibba@aol.com>
>> Cc: Juri Linkov <juri@linkov.net>, larsi@gnus.org, emacs-devel@gnu.org
>>
>> >  +@code{t} the completions are hidden when some unique completion is
>> >  +executed.
>> >
>> >What do you mean by "unique completion is executed"?  Both the
>> >"unique" and the "executed" parts need clarification.
>> >
>> unique means that, there is a single candidate o prefix so the <tab>
>> "added" some letter. example: com<tab>pi<tab> -> compil
>>
>> The first tab shows completions but the second hides it... it is a bit
>> confusing compared to any other completion engine (bash, zsh,
>> fish)... that's why I started this changes...
>
>So we could simply say
>
>  when Emacs is able to complete some characters
>
>is that right?
>
I think so,

>> > If @code{completion-auto-help} is set to @code{always}, the
>> >  +completion commands are always shown after a completion attempt, or
>> >
>> >"Commands"? didn't you mean "candidates" or "alternatives"?  (The same
>> >problem exists in the doc string of this variable, btw.)
>> >
>> Maybe candidates is better,
>
>If it's just "better", then please explain what you mean by
>"commands".  The text I quoted above says "the completion commands are
>always shown".  What are those "commands" that are shown after a
>completion attempt?
>
We are just in violent agreement here I thing.. I am saying that as you
suggested "candidates" is a better word, more precise.

>> >  If the value is @code{visible}, Emacs displays completion the
>> >  completion alternatives when it is unable to complete for the first
>> >  time; thereafter the completion list buffer remains visible and is
>> >  updated as you type.
>> >
>> >Is this accurate and correct?
>> >
>> "and is updated as you type."
>>
>> I am not sure that last part is accurate. updates need <tab> to update
>> in all cases. "as you type" suggests more an icomplete-like behavior I
>> thinks.
>
>Ok, so "the completion list buffer remains visible for all the
>subsequent completion attempts".  Better?
>
yes,

>> >  +current completion candidate will be highlighted with that face.  The
>> >  +default value is @code{completions-highlight}.  When the value is
>> >  +@code{nil}, no highlighting is performed.  This feature sets the text
>> >  +property @code{cursor-face}.
>> >
>> >This should explain what is "the current completion candidate".  It
>> >isn't trivial: trying the current defaults with completion commands, I
>> >sometimes see a candidate highlighted, and sometimes don't.  I
>> >couldn't figure out why.
>> >
>>
>> when it is not highlighting? So far the only way to not have a candidate
>> highlighted is when there is not candidate effectively selected (like
>> when completions are just updated (with no completion-auto-select) and
>> the cursor is before the help line; I that case there is not "current
>> candidate"); a return in that moment won't execute anything because
>> there is nothing to select, so "current completion candidate" means
>> that... Maybe you have a better way to explain it?
>
>Wouldn't it make sense to move point to the first candidate, so that
>some candidate is always highlighted?
>
That may change the current behavior in a more intrusive way and I
didn't want to affect current behavior.

What you suggest is something I already considered:

completion-auto-select t makes 3 things I think should have been spitted
into 2:

1) it selects *Completions*
2) Select completions window
3) Go to the first candidate.

These options may be probably independent because the user may want to:

1) show completion and highlight (or put cursor) in the first candidate
but without selecting the *Completions* Window

2) Select completions window without putting cursor in the first
candidate.

I thought on this because in zsh the usual approach for this is:

First tab: attempts to complete common and shows completions
Second tab: go to completions and select first candidate.

Following tabs: move to next candidate

Right now the combination to get this behavior is not possible, but at
least we are closer than before and we give a more familiar interaction
with more options...

>Btw, when a candidate is highlighted, it is always the first one in
>the list, which kinda makes me wonder why this highlighting is useful,
>if it always shows the candidate in a fixed location on display?
>
I don't understand what you mean... The highlight is just the same that
used to happen before when the point selected a candidate, then arrow
navigation selects a candidate... We just added a more visible hint; not
just the pointer...

>> Please if you have the time change it... Otherwise I will do in some
>> days.
>
>Will do.