From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Select completions from the minibuffer Date: Thu, 17 Mar 2022 19:47:01 +0100 Message-ID: <20220317184701.ani7k3clp3impqwn@Ergus> References: <874k454n84.fsf@gnus.org> <86ilslmvql.fsf@mail.linkov.net> <87v8wl35wg.fsf@gnus.org> <86k0d06dik.fsf@mail.linkov.net> <87ee3714li.fsf@gnus.org> <86r1773sb4.fsf@mail.linkov.net> <87pmmquew4.fsf@gnus.org> <86ee357wob.fsf@mail.linkov.net> <20220314090826.gyc42227jpvh4efa@Ergus> <86zglsiazs.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38798"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 17 19:49:39 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUvBr-0009vu-66 for ged-emacs-devel@m.gmane-mx.org; Thu, 17 Mar 2022 19:49:39 +0100 Original-Received: from localhost ([::1]:37354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nUvBp-0007Lf-UD for ged-emacs-devel@m.gmane-mx.org; Thu, 17 Mar 2022 14:49:37 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUvA7-0005Fl-FI for emacs-devel@gnu.org; Thu, 17 Mar 2022 14:47:53 -0400 Original-Received: from sonic312-21.consmr.mail.bf2.yahoo.com ([74.6.128.83]:42647) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nUvA5-00015m-4Y for emacs-devel@gnu.org; Thu, 17 Mar 2022 14:47:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1647542867; bh=LrEPgzAU/5ogPi9u+BqFwNVf1l9EGuIfqFRlSq0M0F4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=hRk0sdInrQBK4hwfe6kizXlKt9Q/BoFsrHYnBnf4pIZk9FTkm8fyLCSxZe9QQOYFV5YjnHitV94KqMkdnt173xH2rll+V8nyO4bDDZHkb2FTIyRjYCAbb+R8og1p/biXTGEWYt64gT3uG5kpZUmWM05KNOXYLWpCs6HumEXxlTXFNK/M9O0sLem2mHRYVr/v0RjJ+1zDYmaOSxum5k107bq00mc1N/c9lUmgDx47B0q+uJvxQ5n8KSgmE9d4AsL6WDcFHwbma1BHw4bGumLqT9nUf8S1+GJTrzwN6rp/wSHjbeTjX851sozHpyaUDpqjCCImCo3uH5HL5X+3+iruhw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647542867; bh=Xo0Y/IQK7nTjFiH6CSZOZHTK7IGJdM6wkcwoMMcHMoa=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=iZX/HjyQgscCGycUCbdG9/JReJkiVtVqo/bs2dpmELo77W8PQdc6vkoP/VFVKxAbwu0UWETGq1AEC91xKvAYDvEg4DzKtjYVgKFp431QnijSBWkeh8UJehfm3H4NELSta+6gH5blTK/FnYZXuR9YrKLdfKyeNAOBj8NiPCkFIbY1Wf3Plf9Mfk+/N3M1OAu+1JFAIxgtwizO5yefGiSmTNDk1IDWBg5NOYNporBkALEnMDOsLftTDeanKaRJk518zMiZCIri8R07cxTEw1NKNs08rFoYd8zvxnAbLWtwGiVfaD5vFiyziLsnEA7IjXhReyytT56iDHxpeM+UAVnbxw== X-YMail-OSG: Z2WRkV0VM1k_H27aNVvcK9gLFMNvJUZEsfdZlzS1o5zYknjxBakAsIwb4mficpj 8e4dVZus6PwKDtWg6oekkhWBV7mqZ3tiHCIetOJvAhx.N1q7DoIalhFp1QAWyXDZxixKpQzYF6YG CD3Ybrk7l6gVr5wTsdFMUABu7zc5frLDhlrLexAD41LwZnA_uyEYGT6Z79YGiMQ_p010vQ1KL5VP GVXgGgY9g6FWEFJec5uVV8F7qDf5zvDpOTUQYU6hrlxvMRLxyfr9U7.2MTNUilfzrLYLDsjeVhYQ 0GqsfDwKcgIhFXaoSaVLwiYHJZVX2XCuLqcKEwKlX3Z9wRD1.Ui.IZ9Z7v4Ykmfx0SiruLh_PkzK nYTu8DBjPGEKubG_pdStijjhrH8LaLwtSxMfjKycv.9poxiIlLSA.0CJz1iqwSN1WcNG7BXSF_z3 8iNFXt1Dwjq4gxzxuqpzXtlbXPTWOEMWJh.asNi7aWMwYvNYmSWRLqjzNOJqod_UF.eomh7JPJjE Omk26txA74R21HrKua9zMkc25B8zGWlMWArckXYtxG9qvS9mAfBW2pgjBLFz348YVD7yr_l2x2ui tivSmVjp_7pFBE3mMRj_tHyFjUd6jdkCleAJv9K7E6e1z6is9V6_vzYAQzeNunzrgXci505v7cOc O888iOX0Y15s.Ol.itN1ZmOtnRVBq3Ej51G8JVMK2hOcLE1O9keeY9OTCKxWl36yxPAwEGJpRK3v oYXBhSH67s5qQRAB.m_uyO0lU7ge_gtQ.WLv5R94N3YPmir3r_1DHrQ4zdqwsOoUYvBiwWjwIDnB VH7oyOSMpYkujn.f8H.6PPgiuS4VX3PwzlOHpzFcbJ X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.bf2.yahoo.com with HTTP; Thu, 17 Mar 2022 18:47:47 +0000 Original-Received: by kubenode506.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 037a496e1a553b6d361227f1f4c539ef; Thu, 17 Mar 2022 18:47:41 +0000 (UTC) Content-Disposition: inline In-Reply-To: <86zglsiazs.fsf@mail.linkov.net> X-Mailer: WebService/1.1.19929 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Received-SPF: pass client-ip=74.6.128.83; envelope-from=spacibba@aol.com; helo=sonic312-21.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287258 Archived-At: On Mon, Mar 14, 2022 at 09:34:17PM +0200, Juri Linkov wrote: >> Now there is a variable completions-highlight-face. When nil highlight >> is disabled, otherwise it must be a the face to use, by default >> completions-highlight. >> >> I had the mode before because I needed some initialization, but with the >> cursor-face feature that is not needed and the code got simpler. > >Thanks, highlighting works correctly when the current buffer is *Completions*. >But cursor-face is not highlighted in *Completions* when the current buffer >is the minibuffer. Such highlighting is necessary when completions >are navigated from the minibuffer. > Please check the change and try to set cursor-face-highlight-nonselected-window unconditionally in *Completions* to t when using your mode. If you could improve the initialization in order to use cursor-in-non-selected-windows unless the user sets another value manually it may be nicer (because in the general scenario the user could set cursor-in-non-selected-windows latter so this variable may have an outdated value) otherwise consider if this may be simply t or nil by default. But at the moment it works fine for the current use cases. Best, Ergus