Re: Question about completion behavior

[Ergus <spacibba@aol.com>]

[-- Attachment #1: Type: text/plain, Size: 1626 bytes --]

Hi again Eli:

Look at the attached patch, it may need some small improve to solve the
case 4. but so far it gives a consistent behavior with any value of
completion-auto-help (and it is actually simpler than the current code)

Alternatively we may add another custom, something like:

completions-on-complete-action which may have 3 possible values:

'always to update
'hide for the current behavior
nil to do nothing (not hide the completions but keep them visible)

WDYT? (personally I prefer the simpler... but I know... it's emacs)
Ergus

On Wed, Mar 09, 2022 at 11:11:59AM +0100, Ergus wrote:
>On Wed, Mar 09, 2022 at 05:37:37AM +0200, Eli Zaretskii wrote:
>
>Hi Eli:
>
>Thanks for replying. What do you mean by "at a complete"?
>
>there are several conditions to handle:
>
>These are the current more or less the conditions we have now:
>
>1. no unique        (shows or update completions)
>2. unique common    (complete-common and hides completion)
>3. unique candidate (complete and hides completion)
>4. unique common but completion is a valid entry (complete-common and hides completion)
>
>Is the 4 to what you refer?
>
>For example when we have:
>
>magit
>magit-commit
>magit-push
>....
>
>and we do: magi<tab>
>
>the completion goes up to magit (adds the t) but it is a valid
>candidate.
>
>What I propose is:
>
>1. no unique        (shows or update completions)
>2. unique common    (complete-common and UPDATE completions)
>3. unique candidate (complete and hides completion)
>4. unique common but completion is a valid entry (complete-common and hides completion)
>
>Is this behavior fine??
>
>Best,
>Ergus
>

[-- Attachment #2: completion.patch --]
[-- Type: text/plain, Size: 1973 bytes --]

diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index a06986fdb7..fbb72f3d32 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -1342,24 +1342,22 @@ completion--do-completion
               (setq completed t exact t)
               (completion--cache-all-sorted-completions beg end comps)
               (minibuffer-force-complete beg end))
-             (completed
-              ;; We could also decide to refresh the completions,
-              ;; if they're displayed (and assuming there are
-              ;; completions left).
-              (minibuffer-hide-completions)
-              (if exact
-                  ;; If completion did not put point at end of field,
-                  ;; it's a sign that completion is not finished.
-                  (completion--done completion
-                                    (if (< comp-pos (length completion))
-                                        'exact 'unknown))))
              ;; Show the completion table, if requested.
              ((not exact)
 	      (if (pcase completion-auto-help
                     ('lazy (eq this-command last-command))
                     (_ completion-auto-help))
                   (minibuffer-completion-help beg end)
+                (minibuffer-hide-completions)
                 (completion--message "Next char not unique")))
+             (completed
+              ;; We could also decide to refresh the completions,
+              ;; if they're displayed (and assuming there are
+              ;; completions left).
+              (minibuffer-hide-completions)
+              (completion--done completion
+                                (if (< comp-pos (length completion))
+                                    'exact 'unknown)))
              ;; If the last exact completion and this one were the same, it
              ;; means we've already given a "Complete, but not unique" message
              ;; and the user's hit TAB again, so now we give him help.