all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ergus <spacibba@aol.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: Question about completion behavior
Date: Wed, 9 Mar 2022 11:11:59 +0100	[thread overview]
Message-ID: <20220309101159.4k3uma2ztvldlqiz@Ergus> (raw)
In-Reply-To: <831qzbg5j2.fsf@gnu.org>

On Wed, Mar 09, 2022 at 05:37:37AM +0200, Eli Zaretskii wrote:
>> From: Stefan Monnier <monnier@iro.umontreal.ca>
>> Cc: emacs-devel@gnu.org
>> Date: Tue, 08 Mar 2022 22:05:52 -0500
>>
>> >>> Was all this behavior intended or how do you propose to solve this?
>> >>I think this can be changed.
>> >>Patches welcome.
>> > I am struggling how to preserve the old behavior indeed, because what I
>> > find a bit confusing is actually the default behavior.
>>
>> I think we should first consider *not* preserving the behavior.
>> I.e. as suggested by the comment, rather than hide the completions, we
>> should update them (if they're displayed).
>
>But please don't keep updating the completions buffer if TAB arrives
>at a complete (but not necessarily unique) candidate.  That would be
>an annoyance.
>

Hi Eli:

Thanks for replying. What do you mean by "at a complete"? 

there are several conditions to handle:

These are the current more or less the conditions we have now:

1. no unique        (shows or update completions)
2. unique common    (complete-common and hides completion)
3. unique candidate (complete and hides completion)
4. unique common but completion is a valid entry (complete-common and hides completion)

Is the 4 to what you refer?

For example when we have:

magit
magit-commit
magit-push
....

and we do: magi<tab>

the completion goes up to magit (adds the t) but it is a valid
candidate.

What I propose is:

1. no unique        (shows or update completions)
2. unique common    (complete-common and UPDATE completions)
3. unique candidate (complete and hides completion)
4. unique common but completion is a valid entry (complete-common and hides completion)

Is this behavior fine??

Best,
Ergus



  reply	other threads:[~2022-03-09 10:11 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220309001013.gxyh2uasbuxiz6ww.ref@Ergus>
2022-03-09  0:10 ` Question about completion behavior Ergus
2022-03-09  0:22   ` Stefan Monnier
2022-03-09  1:46     ` Ergus
2022-03-09  3:05       ` Stefan Monnier
2022-03-09  3:37         ` Eli Zaretskii
2022-03-09 10:11           ` Ergus [this message]
2022-03-09 11:46             ` Ergus
2022-03-09 13:16               ` Eli Zaretskii
2022-03-09 13:46                 ` Po Lu
2022-03-09 17:32                   ` Stefan Monnier
2022-03-09 17:41                     ` Ergus
2022-03-10  0:42                     ` Po Lu
2022-03-10 10:21                       ` Ergus
2022-03-10 11:15                         ` Po Lu
2022-03-10 14:03                           ` Ergus
2022-03-10 18:50                             ` Juri Linkov
2022-03-10 22:35                               ` Ergus
2022-03-12 18:31                                 ` Juri Linkov
2022-03-13 14:58                                   ` Ergus
2022-03-12  0:17                               ` Ergus
2022-03-12 18:34                                 ` Juri Linkov
2022-03-13 11:21                                   ` Ergus
2022-03-13 17:44                                     ` Juri Linkov
2022-03-13 18:50                                       ` Ergus
2022-03-13 18:57                                         ` Eli Zaretskii
2022-03-13 19:49                                           ` Ergus
2022-03-13 20:48                                       ` [External] : " Drew Adams
2022-03-13 21:15                                         ` Ergus
2022-03-13 23:14                                           ` Drew Adams
2022-03-13 23:38                                             ` Ergus
2022-03-14  2:23                                               ` Drew Adams
2022-03-12 20:25                             ` Drew Adams
2022-03-09 14:30                 ` Ergus
2022-03-09 16:14                   ` [PATCH] " Ergus
2022-03-09 16:56                   ` Eli Zaretskii
2022-03-09 13:10             ` Eli Zaretskii
2022-03-09 14:22               ` Ergus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220309101159.4k3uma2ztvldlqiz@Ergus \
    --to=spacibba@aol.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.