From: Ross Vandegrift <ross@kallisti.us>
To: martin rudalics <rudalics@gmx.at>
Cc: 53298@debbugs.gnu.org
Subject: bug#53298: 29.0.50; GTK3 frame stops updating
Date: Sun, 16 Jan 2022 12:44:10 -0800 [thread overview]
Message-ID: <20220116204410.e2vjlz3g4clrxg7q@stgulik> (raw)
In-Reply-To: <08309eaf-2abb-080e-9c55-573b330e7765@gmx.at>
On Sun, Jan 16, 2022 at 12:06:12PM +0100, martin rudalics wrote:
> Thanks for the report. I suppose this is the problem described in
> Bug#49955 28.0.50; Emacs got quasi freeze. For some reasons, Masaru
> Nomiya reported that bug as fixed but we never got a conclusive answer.
>
> Also the problem he reported here
>
> https://www.mail-archive.com/enlightenment-users@lists.sourceforge.net/msg26981.html
>
> apparently had no conclusive outcome either.
>
> Can you try commenting in the two lines
>
> /** SET_FRAME_VISIBLE (f, 1); **/
> /** SET_FRAME_ICONIFIED (f, false); **/
>
> in xterm.c and tell whether that solves the problem. If so, we could
> add an option to set these in accordance with the window manager used.
No, that didn't help. Reverting 483c5e953c as suggested in #49955 does though.
I mucked with the revert a bit, the issue is skipping the the FocusIn handling
on GTK.
The minimal working revert is below. Not sure if this is safe for the other
issue through.
Ross
diff --git a/src/xterm.c b/src/xterm.c
index 5798ea3eeb..752b6562bb 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -9574,16 +9574,10 @@ handle_one_xevent (struct x_display_info *dpyinfo,
goto OTHER;
case FocusIn:
-#ifndef USE_GTK
/* Some WMs (e.g. Mutter in Gnome Shell), don't unmap
minimized/iconified windows; thus, for those WMs we won't get
a MapNotify when unminimizing/deconifying. Check here if we
- are deiconizing a window (Bug42655).
-
- But don't do that on GTK since it may cause a plain invisible
- frame get reported as iconified, compare
- https://lists.gnu.org/archive/html/emacs-devel/2017-02/msg00133.html.
- That is fixed above but bites us here again. */
+ are deconizing a window (Bug42655). */
f = any;
if (f && FRAME_ICONIFIED_P (f))
{
@@ -9593,7 +9587,6 @@ handle_one_xevent (struct x_display_info *dpyinfo,
inev.ie.kind = DEICONIFY_EVENT;
XSETFRAME (inev.ie.frame_or_window, f);
}
-#endif /* USE_GTK */
x_detect_focus_change (dpyinfo, any, event, &inev.ie);
goto OTHER;
next prev parent reply other threads:[~2022-01-16 20:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-16 6:43 bug#53298: 29.0.50; GTK3 frame stops updating Ross Vandegrift
2022-01-16 11:06 ` martin rudalics
2022-01-16 20:44 ` Ross Vandegrift [this message]
2022-01-17 9:39 ` martin rudalics
2022-01-17 23:23 ` Ross Vandegrift
2022-01-18 7:29 ` martin rudalics
2022-01-18 18:03 ` Eli Zaretskii
2022-01-20 9:49 ` martin rudalics
2022-02-19 12:57 ` bug#53299: GTK3 frames stop updating Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220116204410.e2vjlz3g4clrxg7q@stgulik \
--to=ross@kallisti.us \
--cc=53298@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.