all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Yuuki Harano <masm+github@masm11.me>
To: fejfighter@gmail.com
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] PGTK patches
Date: Sun, 14 Nov 2021 22:42:33 +0900 (JST)	[thread overview]
Message-ID: <20211114.224233.1516816056723068839.masm@luna.pink.masm11.me> (raw)
In-Reply-To: <CALohuRDosMzAf0DB_N8ZbNSE0t9R0eusGvyZjmthjjL6KiM6=w@mail.gmail.com>

Thanks.

On Sun, 14 Nov 2021 23:34:51 +1100,
	Fejfighter <fejfighter@gmail.com> wrote:
> -  if (!FRAME_GTK_OUTER_WIDGET (f))
> +  if (!FRAME_GTK_OUTER_WIDGET (f)) {
> +    if (FRAME_WIDGET(f))
> +	gtk_widget_set_can_focus(FRAME_WIDGET(f), g_no_accept_focus);
>      return;
> +  }

Please fix coding style.
- position of braces
- insert a space between function/macro name and open-paren.

> +	      gtk_widget_grab_focus(FRAME_GTK_WIDGET(f));
> +	      if (FRAME_GTK_OUTER_WIDGET(f))
> +		gtk_window_present(GTK_WINDOW(FRAME_GTK_OUTER_WIDGET(f)));

Here, too.

-- 
Yuuki Harano



  reply	other threads:[~2021-11-14 13:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-14 12:34 [PATCH] PGTK patches Fejfighter
2021-11-14 13:42 ` Yuuki Harano [this message]
2021-11-15  5:25 ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211114.224233.1516816056723068839.masm@luna.pink.masm11.me \
    --to=masm+github@masm11.me \
    --cc=emacs-devel@gnu.org \
    --cc=fejfighter@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.