From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Performance issue in project.el Date: Mon, 28 Jun 2021 14:44:11 +0200 Message-ID: <20210628124411.fpasjjx3duzuzelu@Ergus> References: <20210627212123.xciejcjxrv2rxsra.ref@Ergus> <20210627212123.xciejcjxrv2rxsra@Ergus> <20210628114247.tecbjwareetquj6h@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6266"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Phil Sainty Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 28 14:47:45 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lxqfw-0001Sa-NW for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Jun 2021 14:47:44 +0200 Original-Received: from localhost ([::1]:55920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxqfv-0003zK-Md for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Jun 2021 08:47:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59480) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxqd3-0008Lr-E1 for emacs-devel@gnu.org; Mon, 28 Jun 2021 08:44:45 -0400 Original-Received: from sonic310-13.consmr.mail.bf2.yahoo.com ([74.6.135.123]:41284) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lxqd0-0007IL-0a for emacs-devel@gnu.org; Mon, 28 Jun 2021 08:44:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1624884263; bh=AFZkLfmHMDU71UEusPT8MpZrZIJc1jZ0lYkO46zJ+eY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=oZdT7cvQB2YXNA92n8nLDarirsJB4r8SBEwmhLFi/k8UNAwLF6ofDNbsQu1KzBuvofTXGs93IQAvpzxd2SKcXwq1Q74XIKneexlrgVxv1zE7eyt0HyZV43ppDR8XvUXgQRzJ4J0HTATSQe952MrZHGTdjnQyP/Dz6R8tBywqZXhrkw/EvKLW1g22yDCHnoXHphBcaEOQCx4iEme3fthvC7K+Yl+wucG3kmoin2lAMwMFBzWwjkDKl5OaQD1+dgaae/R4zePwPI33u7Z28u5kk5eh6WXnrda/rArhEg0XdQKCF6OKRmgkGwCWC9Wid6ZfPWaZY5QjsrOkJg9w8hPtQg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1624884263; bh=zfBixb5LvmNsBTQKCbQFz4z4Y72XG9nb4KWobHcHOWA=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=H6sKbKeaploCWCFJuMypUPnFRo7tmWIGDrLJ5eTnU91QA9RF8opv7YHyWjGwniawfTkEfXpsnBOftuuuDWOx3Xs2Wf6toZOqSD2kXhIdZdFcSWSZzm9gDXTrAD+0AEMYUT8z8B7OeY1UhcxGIbky8bbv4kDSZXPHxIY3NM66wEgXH3/wq8S1T8qptyGaSWf5zKfh1uCfECqy1PDsS4q7Dsh3xXXKChHDpMnixqlpMNQ7+V4Y3qsVqy6c9uUCNChM38f+HVBkqhg4BdcnRy1PwNQ26YC02LFKwJ6cOwW+n4dWw0IDGpv+9GYfybexFyvMhNUL8qVBZVr8O08bQcGu7Q== X-YMail-OSG: M08WCi8VM1mNinP6_ZXSiD6BT3c_3LMFyDD9h_senRLlFdZowEm91BOz8cPOaf_ leprx6K9.3ZfJSMi.hDDlJa_csSpkoalRvS9BFeaxOi5tUPFcphYXKp6jRI5ZkPSqXGpb0qbG02N imBmTEel6ZUCxJJmTBNAHGcUvGAFWqE9JGSAewWmtfD7kS0weEgCG_D0H1vM3UU1Tj2.VzIOyTv_ IrkzKZriYUl6mVkKdi0e7UUuGpUTXWXziKzs2y3igA63ifip5PZ4aiqSEefufTUCM65J9.wWaZRG sTwI3pU7cXR6XXFkNU13iVoiF000WtFJedP67Dtirhd1PKuZad8x5aYHD96BfxVKyhW2UOtGuQoI eCehJehp4l1h_FSTKn.frA2y0BtEC5iD13u7tyZLvWB3RPGoo7Se9eaCiu40z6vTGbS8sxy3ixYD kOoX6kAY2U_Vni30lN04lTw1Kl8m520OOd_AFSdD4OnElMUxsbcW2PKO_H4UNe4pM1JA_UIIZkEn Q6tDw09IOfwvBwa60hBYKi50zS.6TTR_mgsvvkRPlrREoTJsU8jAQoDeuDCro8qBkj2bKdBOYgO6 XZCE89ru_WGQRIfVtft08xLpbgNOsP3faHCfjWCyjxkiOxQ0cN5C5cd7SNBrPGG9W08BzZV6i0xN O3LidNiQDnJNdqxTMQKazEMr7OogjhZRemrFA24zO2jRfBoOjfZVszSn7HFwQ_69KdMQQmDtsPgr MvGhHY5UYXxdSknBwCiV20QZwikzxSWlykAthG.M_pwdOVhYDu8UwdG8oBJ4x5ZF2pPKlbarGJ7H 7bov8xLHQSq00vFzXwMn9WAVryrLJiHFRdQh8Ku6fr X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.bf2.yahoo.com with HTTP; Mon, 28 Jun 2021 12:44:23 +0000 Original-Received: by kubenode527.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 4b14881f508b51f3b087e75b002a82ce; Mon, 28 Jun 2021 12:44:19 +0000 (UTC) Content-Disposition: inline In-Reply-To: X-Mailer: WebService/1.1.18469 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Received-SPF: pass client-ip=74.6.135.123; envelope-from=spacibba@aol.com; helo=sonic310-13.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271064 Archived-At: Reading the issue I see that there is already vc-file-prop-obarray. Could vc-responsible-backend use that? On Tue, Jun 29, 2021 at 12:14:57AM +1200, Phil Sainty wrote: >On 2021-06-28 23:42, Ergus wrote: >>After reading the function vc-responsible-backend I can see that it >>uses >>a mapcar to test the responsible; so all of them are always tested in >>every single call every time. > >It didn't in Emacs 27, but see bug #42966 and commit 2697123933e3 > >https://debbugs.gnu.org/cgi/bugreport.cgi?bug=42966 > >commit 2697123933e3ac7ed4e21a6d12746a98ed7fa74a >Author: Lars Ingebrigtsen >Date: Mon Oct 26 21:10:36 2020 +0100 > > Make vc-responsible-backend choose the most specific backend > > * lisp/vc/vc.el (vc-responsible-backend): Search through all the > VC backends instead of the first one, and choose the one that's > most specific (bug#42966). >