[PATCH] src/pgtkfns.c: Do not show an empty frame prematurely

[PATCH] src/pgtkfns.c: Do not show an empty frame prematurely

[Jindřich Makovička]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

Hi,

currently, PGTK Emacs shows an empty 200x200 px GTK window immediately
when x-create-frame is called, and it takes some time until the "real"
Emacs frame is shown. Changing this function to set the visibility flag
only on the child widgets of the GTK window and leaving the parent
window hidden until pgtk_make_frame_visible is called gives a much
better impression when starting Emacs.

-- 
Jindrich Makovicka

[-- Attachment #2: 0001-src-pgtkfns.c-Do-not-show-an-empty-frame-prematurely.patch --]
[-- Type: text/x-patch, Size: 1070 bytes --]

From 668bbba248de2b5eba346499b3f0a9d3de18ebc4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jind=C5=99ich=20Makovi=C4=8Dka?= <makovick@gmail.com>
Date: Sat, 29 May 2021 14:53:20 +0200
Subject: [PATCH] * src/pgtkfns.c: Do not show an empty frame prematurely

Set only the child widgets visible, leave the outer window
to pgtk_make_frame_visible .
---
 src/pgtkfns.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/pgtkfns.c b/src/pgtkfns.c
index 5f114515c9..689a104d33 100644
--- a/src/pgtkfns.c
+++ b/src/pgtkfns.c
@@ -1693,8 +1693,13 @@ #define INSTALL_CURSOR(FIELD, NAME) \
       unblock_input ();
     }
 
-  if (FRAME_GTK_OUTER_WIDGET (f))
-    gtk_widget_show_all (FRAME_GTK_OUTER_WIDGET (f));
+  if (FRAME_GTK_OUTER_WIDGET (f)) {
+    GList *w = gtk_container_get_children(GTK_CONTAINER(FRAME_GTK_OUTER_WIDGET (f)));
+    for (; w != NULL; w = w->next)
+      {
+	gtk_widget_show_all (GTK_WIDGET(w->data));
+      }
+  }
 
   gui_default_parameter (f, parms, Qno_focus_on_map, Qnil,
 			 NULL, NULL, RES_TYPE_BOOLEAN);
-- 
2.32.0.rc0

Re: [PATCH] src/pgtkfns.c: Do not show an empty frame prematurely

[Yuuki Harano]

On Sat, 29 May 2021 20:58:47 +0200,
	Jindřich Makovička <makovick@gmail.com> wrote:
> currently, PGTK Emacs shows an empty 200x200 px GTK window immediately
> when x-create-frame is called, and it takes some time until the "real"
> Emacs frame is shown.

I can't see such an empty window.
What environment are you using?

-- 
Yuuki Harano

Re: [PATCH] src/pgtkfns.c: Do not show an empty frame prematurely

[Jindřich Makovička]

On Wed, 09 Jun 2021 00:54:15 +0900 (JST)
Yuuki Harano <masm@masm11.me> wrote:

> On Sat, 29 May 2021 20:58:47 +0200,
> 	Jindřich Makovička <makovick@gmail.com> wrote:
> > currently, PGTK Emacs shows an empty 200x200 px GTK window
> > immediately when x-create-frame is called, and it takes some time
> > until the "real" Emacs frame is shown.  
> 
> I can't see such an empty window.
> What environment are you using?
> 

It's visible in MATE 1.24.1. Emacs with the legacy GTK UI does not do
this as x_make_frame_visible is the first one to call
gtk_widget_show_all().

-- 
Jindrich Makovicka

Re: [PATCH] src/pgtkfns.c: Do not show an empty frame prematurely

[Yuuki Harano]

On Sat, 12 Jun 2021 15:13:16 +0200,
	Jindřich Makovička <makovick@gmail.com> wrote:
>> I can't see such an empty window.
>> What environment are you using?
>> 
> 
> It's visible in MATE 1.24.1. Emacs with the legacy GTK UI does not do
> this as x_make_frame_visible is the first one to call
> gtk_widget_show_all().

I don't have MATE, so I couldn't confirm.

Applied, thanks.

-- 
Yuuki Harano

Re: [PATCH] src/pgtkfns.c: Do not show an empty frame prematurely

[Jindřich Makovička]

On Sun, 13 Jun 2021 18:40:04 +0900 (JST)
Yuuki Harano <masm+emacs@masm11.me> wrote:
> I don't have MATE, so I couldn't confirm.
> 
> Applied, thanks.
> 

I see the patch being reverted immediately - did it break anything?

-- 
Jindrich Makovicka

Re: [PATCH] src/pgtkfns.c: Do not show an empty frame prematurely

[martin rudalics]

 > I see the patch being reverted immediately - did it break anything?

And if it broke anything, please explain somewhere in the code what it
broke.  This should avoid that people apply this or a similar patch in
the future.

Thanks, martin

Re: [PATCH] src/pgtkfns.c: Do not show an empty frame prematurely

[Yuuki Harano]

On Mon, 14 Jun 2021 08:39:51 +0200,
	Jindřich Makovička <makovick@gmail.com> wrote:
>> Applied, thanks.
>> 
> 
> I see the patch being reverted immediately - did it break anything?

I'm sorry, I should have told you what was broken.

emacs -Q --eval "(scroll-bar-mode -1)" --eval "(menu-bar-mode -1)" --eval "(tool-bar-mode -1)" --eval "(make-frame-command)"

This command created an empty frame.
It is reported here:
  https://github.com/masm11/emacs/issues/105

I debugged a bit but I couldn't solve it, so I reverted the patch.

I'm going to debug with the patch.


On Mon, 14 Jun 2021 10:29:41 +0200,
	martin rudalics <rudalics@gmx.at> wrote:
>> I see the patch being reverted immediately - did it break anything?
> 
> And if it broke anything, please explain somewhere in the code what it
> broke.  This should avoid that people apply this or a similar patch in
> the future.

OK, I'll explain the reason in the commit message of the revert commit
next time.

-- 
Yuuki Harano

Re: [PATCH] src/pgtkfns.c: Do not show an empty frame prematurely

[Yuuki Harano]

On Mon, 14 Jun 2021 20:56:32 +0900 (JST),
	Yuuki Harano <masm+emacs@masm11.me> wrote:
> I'm going to debug with the patch.

Done.
The patch is applied, and the empty frame bug is gone.

Thanks for the patch.
-- 
Yuuki Harano