all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ergus <spacibba@aol.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: [PATCH] Display fill column indicator issue.
Date: Thu, 3 Jun 2021 09:28:17 +0200	[thread overview]
Message-ID: <20210603072817.nuff43yiaa7iy7le@Ergus> (raw)
In-Reply-To: <20210602102423.hosk6gdzi2lpu7jt@Ergus>

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

Hi Eli:

Could you check and apply this fix?

Best,
Ergus

On Wed, Jun 02, 2021 at 12:24:23PM +0200, Ergus wrote:
>Hi Eli:
>
>I have observed that recently the column indicator changed its behavior
>(maybe it did some time ago but I haven't noticed).
>
>When scrolling horizontally the indicator line is supposed to scroll too
>with the text; but right now it is always in the same "screen" column.
>
>The issue is only on terminal because in gui the line moves
>correctly. So the problem should be in xdisp.c:22390 because it should
>substract the horizontal offset of the current starting column (maybe
>it->first_visible_x or similar).
>
>Could you push this fix please? I have to recover my Savannah private
>keys and I don't have time now.
>
>Thanks in advance,
>Ergus
>

[-- Attachment #2: fix_dfci.patch --]
[-- Type: text/plain, Size: 587 bytes --]

diff --git a/src/xdisp.c b/src/xdisp.c
index 0a95aa32f9..68bcbbe5d1 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -22387,7 +22387,8 @@ extend_face_to_end_of_line (struct it *it)
                      default_face->id : face->id);
 
       /* Display fill-column indicator if needed.  */
-      const int indicator_column = fill_column_indicator_column (it, 1);
+      const int indicator_column =
+	fill_column_indicator_column (it, 1) - it->first_visible_x;
 
       /* Make sure our idea of current_x is in sync with the glyphs
 	 actually in the glyph row.  They might differ because

  reply	other threads:[~2021-06-03  7:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210602102423.hosk6gdzi2lpu7jt.ref@Ergus>
2021-06-02 10:24 ` Display fill column indicator issue Ergus
2021-06-03  7:28   ` Ergus [this message]
2021-06-03  8:07     ` [PATCH] " Eli Zaretskii
2021-06-03 14:46       ` Eli Zaretskii
2021-06-04 10:38         ` Ergus
2021-06-04 10:46           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210603072817.nuff43yiaa7iy7le@Ergus \
    --to=spacibba@aol.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.