From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuuki Harano Newsgroups: gmane.emacs.devel Subject: Re: feature/pgtk 7085fec: Disable hyper key when super and hyper conflict Date: Sun, 30 May 2021 12:43:50 +0900 (JST) Organization: Ingage Inc. Message-ID: <20210530.124350.2108244856122769256.masm@luna.pink.masm11.me> References: <20210529145908.27858.39953@vcs0.savannah.gnu.org> <20210529145909.CF411209BF@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20522"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: monnier@iro.umontreal.ca Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 30 05:45:53 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lnCOc-00056y-VG for ged-emacs-devel@m.gmane-mx.org; Sun, 30 May 2021 05:45:51 +0200 Original-Received: from localhost ([::1]:54554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnCOc-0003i0-16 for ged-emacs-devel@m.gmane-mx.org; Sat, 29 May 2021 23:45:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnCMx-0001qW-PO for emacs-devel@gnu.org; Sat, 29 May 2021 23:44:07 -0400 Original-Received: from shiro.masm11.me ([150.95.182.25]:52100) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnCMu-0003VS-Lu for emacs-devel@gnu.org; Sat, 29 May 2021 23:44:07 -0400 Original-Received: from luna.pink.masm11.me (KD106180014086.au-net.ne.jp [106.180.14.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shiro.masm11.me (Postfix) with ESMTPSA id 4C813C01E2; Sun, 30 May 2021 12:43:57 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=masm11.me; s=202002; t=1622346237; bh=jxhVgy2cA3QPbGF6ha7UY1aPlAyVnSLyjj7l9u1BKNc=; h=Date:To:Cc:Subject:From:In-Reply-To:References; b=OqdA5qnDLDT5MOchrdNV7pEwcldRexcpc4uXIYteuLasNq9D7DTTRTc/5OeyTv7nW p9WnhoOYmmrR3JxiqjnV5FP+pq7hvTHDAEZjsMquuZlJWy+NCfd2hllmOxhoxQJMT4 IEpL7VU4BdqAS3isGMLYC0Q+wlunDOc1hFQXL7xA= In-Reply-To: X-Mailer: Mew version 6.8 on Emacs 28.0 Received-SPF: pass client-ip=150.95.182.25; envelope-from=masm@masm11.me; helo=shiro.masm11.me X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270107 Archived-At: On Sat, 29 May 2021 11:36:31 -0400, Stefan Monnier wrote: >> + /* If xmodmap says: >> + * $ xmodmap | grep mod4 >> + * mod4 Super_L (0x85), Super_R (0x86), Super_L (0xce), Hyper_L (0xcf) >> + * then, when mod4 is pressed, both of super and hyper are recognized ON. >> + * Maybe many people have such configuration, and they don't like such behavior, >> + * so I disable hyper if such configuration is detected. >> + */ >> + if (dpyinfo->hyper_mod_mask == dpyinfo->super_mod_mask) >> + dpyinfo->hyper_mod_mask = 0; > > IIUC the same problem can appear under X11. Do we have similar code in > the X11 code for that? If not, should we add it as well? On XGTK, the same problem doesn't occur even if I have the same configuration. I think XGetModifierMapping() have the similar code. -- Yuuki Harano