From: Boruch Baum <boruch_baum@gmx.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 48269@debbugs.gnu.org, fgunbin@fastmail.fm
Subject: bug#48269: 27.1: log-edit-generate-changelog-from-diff FAILURE
Date: Sun, 9 May 2021 12:55:15 -0400 [thread overview]
Message-ID: <20210509165515.6vg4g3tobx2sok6f@E15-2016.optimum.net> (raw)
In-Reply-To: <83im3vcbej.fsf@gnu.org>
On 2021-05-07 09:20, Eli Zaretskii wrote:
> > Date: Thu, 6 May 2021 22:47:17 -0400
> > From: Boruch Baum <boruch_baum@gmx.com>
>
> So the problem seems to be that the doc strings don't say the command
> should be invoked from a *vc-log* buffer, is that right?
There could be a sanity-check at the beginning of the function in the form:
(unless (eq major-mode foo)
(user-error "Not in foo buffer"))
> The user manual explains that, so next time when the doc string is
> not enough,
Umm... In this case, a mix of subjective 'not enough' and objective
non-existent. Important to make that distinction.
> may I suggest to try looking up the command/variable in the manual?
For me personally that's a great suggestion, but if that's going to be
your position for all emacs users, you're taking a major step back from
a long strong precedent of emacs documentation standards and one of the
features that makes emacs such an attractive environment to work in.
And here's the content of the log-edit.el commentary (don't blink):
That was quick.
--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0
next prev parent reply other threads:[~2021-05-09 16:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 23:23 bug#48269: 27.1: log-edit-generate-changelog-from-diff FAILURE Boruch Baum
2021-05-07 1:26 ` Filipp Gunbin
2021-05-07 2:47 ` Boruch Baum
2021-05-07 6:20 ` Eli Zaretskii
2021-05-09 16:55 ` Boruch Baum [this message]
2021-05-09 17:15 ` Eli Zaretskii
2021-05-09 18:44 ` Boruch Baum
2021-05-09 18:54 ` Eli Zaretskii
2021-05-09 22:58 ` Filipp Gunbin
2021-05-10 0:13 ` Boruch Baum
2021-05-11 13:34 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210509165515.6vg4g3tobx2sok6f@E15-2016.optimum.net \
--to=boruch_baum@gmx.com \
--cc=48269@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=fgunbin@fastmail.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.