From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Boruch Baum Newsgroups: gmane.emacs.bugs Subject: bug#48179: bookmark-fontify [PATCH] Date: Thu, 6 May 2021 06:38:35 -0400 Message-ID: <20210506103835.iyo6ff4rwuzgbpxd@E15-2016.optimum.net> References: <20210503091204.qhc2tda76wh6345w@E15-2016.optimum.net> <87im40cgxz.fsf@gnus.org> <20210503095828.66mcqkxyznb2vdja@E15-2016.optimum.net> <87v97yan85.fsf@gnus.org> <87lf8uan2m.fsf@gnus.org> <87zgxan7lx.fsf@tcd.ie> <878s4t8up2.fsf@gnus.org> <8735v1jrit.fsf@tcd.ie> <20210505170853.locsnpxoth7fukeq@E15-2016.optimum.net> <87fsz01bo7.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6211"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: NeoMutt/20180716 Cc: "Basil L. Contovounesios" , 48179@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 06 12:39:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lebPS-0001VI-AY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 12:39:10 +0200 Original-Received: from localhost ([::1]:40154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lebPR-0005Qm-Ck for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 06:39:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lebPK-0005Qf-Qp for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 06:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54001) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lebPK-0000Ip-IZ for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 06:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lebPK-0000Mg-Gr for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 06:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 10:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 48179-submit@debbugs.gnu.org id=B48179.16202975301396 (code B ref 48179); Thu, 06 May 2021 10:39:02 +0000 Original-Received: (at 48179) by debbugs.gnu.org; 6 May 2021 10:38:50 +0000 Original-Received: from localhost ([127.0.0.1]:37314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lebP8-0000MS-Jr for submit@debbugs.gnu.org; Thu, 06 May 2021 06:38:50 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:60641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lebP3-0000MM-FA for 48179@debbugs.gnu.org; Thu, 06 May 2021 06:38:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620297518; bh=5YpkryTpPOgv2Cs0er3Q8e21M7bAqNAgg6j8+Nwn2Ps=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=fAbZhmRRjwMC/9/TLXc2vJbQWxiABUzVgAQCHwPi4jbLbOCzuBk+esKeF2BUIsnca gIQTe2kiUE8J6BPZqHXuEv6Knh1r/jt8QEmHeBZCqSDN1OL+apeHzWIQP2IIEbiz6K aP6mQSjYkxj9MFjPxlFGk4ZTdfBcutOrxiUIAanU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N2V4J-1lY6j30Ca7-013sYL; Thu, 06 May 2021 12:38:38 +0200 Content-Disposition: inline In-Reply-To: <87fsz01bo7.fsf@gnus.org> X-Provags-ID: V03:K1:WRW2Q/T9LfJuBTcb+19s2ndRn53l4TQruxxAQfjy9c07SqFM+2A NQkbXjUkRwtYKHLvJRPPp8POn9xeEAMXP03RD5rAPJilyE3mnDa1LIvqpDxNTIysunZRu5X 3sRPr59hKnwQfeq0wJ21uow+kRnYTgwEENLAan3KhWrKyoTq+eYIAkCrEUFxaO8LNSvoVzg flm3tp+CK5Sbzuk4iswJg== X-UI-Out-Filterresults: notjunk:1;V03:K0:IWqiTKLgJSk=:+NsZbYsOh7xgMTBKZL2l7t z87lZWrokDGB8BKpeG8vYkdBLtMix3eEsbfnxCve6S8SIMSeZz1qhOz3JpnA4P/Hze3GsVP6M yaC3fb6rRoEa9qwiXvk+rlo7kmDzz2cCuvmOa3TVTB2KTAtS39jwEHGIOIBe92he5Dh7sLK4a 3Vl98+JXp/V3WzE5Ea8MdE0VG5KN88w3Z+ihz9gAaX+zQ0UU9FmqSeoXOQEnSMnXK8GWf0aHR wbkzu4U30UFXHmHwFUrkzP5p6wPVgE4MjYEQwQnFjlUIqP1wkP2/+7Ec7WppI17+HSwh21cIV rJv5yYF8aOFmAlkt+XwOTv302v8Pa8CCbskt9gne8V1hBseQNMs+EMUbQnm+ksIN3VaLDDM7J O1Hsw2NI3kp4Z/sxGG4ZjYbcIftqNWZRacxWmfvmfXsNjrGDPWs1dQ0T2dQ9s2hkxZfAmE4vc Q9WGIob7RX6nUstrxdva1pR/TsdHlH6jjqMfHFWUmPgdVjKh7nOTVvhBAp+RSwIc7Y7G5CD8Q qDn5idp0tZIsOQgrY0vjMiqeFc+OM1lsjf14Vx21f7qvqmkUGikYS1ZHNaefBffnaMEQeC+UM DeUImlgFfg/HPYzs+XWYQOuPxkKo+eldsP/nNRUAHLTJkLyq7eu4er0PzAe9fF1NrD5eyCL7+ TgKN7YB/p553MStBMPlrt+iqgrJDpcvbIooHtb2FiwAjmU9alNIZbhv7biQt4XZXAAGmcDqmc 3D1mu77pAnhYAnXUJWYZEBedp7+X12x8qrso6XzE3goxisE/ykzBhbTG22a8aozYB9xzGN3V X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205810 Archived-At: On 2021-05-06 10:58, Lars Ingebrigtsen wrote: > Boruch Baum writes: > > > 5) Throughout my prior patches, I had been using variable > > 'buffer-file-name' to compare against the value for the 'filename' > > key in bookmarks' alists. That is wrong, in the sense that it's onl= y > > correct for buffers visiting files. The correct comparator seems to > > be the output of function (bookmark-buffer-file-name), see there, > > which will cover all cases of all buffers. With that change, it's > > probably wrong to perform 'expand-file-name' when performing any > > comparison. > > Right. Can you submit a patch to fix that? Basil has taken the lead on this, and I'm waiting on a response from him with his integration patch before continuing. Once that happens, I'll suggest to him that patch and one or two other ideas (eg. a setting change should be respected immediately across all buffers, so it should be controlled by a toggle or -mode command; popping a bookmark should fontify the pop). =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0