From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Boruch Baum Newsgroups: gmane.emacs.bugs Subject: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] Date: Wed, 28 Apr 2021 05:33:50 -0400 Message-ID: <20210428093349.pevawwg2fvui26fz@E15-2016.optimum.net> References: <20210427190243.n5yg3gywd5wma3jl@E15-2016.optimum.net> <83lf93h6x1.fsf@gnu.org> <20210427193253.ourhlr3nxdem3e6t@E15-2016.optimum.net> <83k0ongnc7.fsf@gnu.org> <20210428030025.75hiu5zgrll2qzeq@E15-2016.optimum.net> <87fszbnd70.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26068"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: NeoMutt/20180716 Cc: 48072@debbugs.gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 28 11:35:32 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbgbU-0006hD-GC for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Apr 2021 11:35:32 +0200 Original-Received: from localhost ([::1]:53858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbgbT-0002PI-EE for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Apr 2021 05:35:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43194) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbgb0-0002FM-6T for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 05:35:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40191) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbgaz-0003iC-UT for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 05:35:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lbgaz-0003zC-PO for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 05:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Apr 2021 09:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48072-submit@debbugs.gnu.org id=B48072.161960244315233 (code B ref 48072); Wed, 28 Apr 2021 09:35:01 +0000 Original-Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 09:34:03 +0000 Original-Received: from localhost ([127.0.0.1]:51737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbga3-0003xc-2j for submit@debbugs.gnu.org; Wed, 28 Apr 2021 05:34:03 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:39339) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbga0-0003x5-Ih for 48072@debbugs.gnu.org; Wed, 28 Apr 2021 05:34:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619602433; bh=0V849C1uBfy3GRIrYrNeMUeJ5I8U2xYUwOh0TibOyQ4=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=baqpB0ZbsTbEBeA86YFCn8BfFj3o5odsCRgsPcbbWcZtFqhipzn0dn7vEmiw8vIzm 5XWXmWf1IYP5Ts+6em9k5d2dUUKRdfhiYPJ+R0QvaPBV6eBNf1Ycrz68mBtQeQHT3S wmkKhrVyu5djPgxJTcDSGDkAiHDkcJLYGjm6yq3k= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N4z6q-1lU9em45rQ-010rRa; Wed, 28 Apr 2021 11:33:53 +0200 Content-Disposition: inline In-Reply-To: <87fszbnd70.fsf@gmail.com> X-Provags-ID: V03:K1:watBV20JddvabA5UpTi1RtFysFxlMs7YgcG6D8iu0iYOJJoRH/m ps6U1xVZi5Cpkvse4dj53paZU/ad7i0yJCnN7Caud2SA9mK86oWIvEzxrd28xHzUidOMcdl oiEvgnqmpahzx2YGUuJeoIkq6qLGI/bU8bssklYOY0f4/ZRtHwcvcU+EUM6VARHJVq0ZuhW z0uUfOwyrvZH+HYNqA7BQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:B9Hq78kWJ9k=:4/37/t7MtZQp4KmlsrHXij k4Z4ozrmBJZezl9UtIn862PQR+4Q9rcYy3Xzj94hF5+PqH0lxql+vp+R42lK0I3Od9s0xkYfc AlvlpV/HYXIKDi+1WB09jIL5+o5SGTk+W9g2KCDCyJRhi5IpOrRhPOfI10rt62PV6jEXRMFTW uZ32mrQnS9tX9BXv4rdQObPHLRVBHJn4Irqfbb0p7j5WOjPBlxMGvpWR3HwG9nDGI6uPxWZBO LgQyx4ZdXVELMXF51cGmUKi+GYX0B2ojWUZPPVX+KQ/s9795sIReMg5Yq7uKCz+eVa5aZ6YIL zSkaPQyQd+x3eNDTz00JdYi8wiU4FVNFt3UevRfuBBEgRTpW9OQOoDdt+2SOcoddkr/QtXFLi WabqV2b7J/DBhVOMZ/7LdMI0HAVI354YDbV04PG30P57NdMgmWmPG8mSobIhrKqcwtkQqQeaX iWc6GpDKIjJzXhoaQ+8hX2F58dMR5KkuhpURYUrG4Qsgp0z4UquQW8V9AGWBA8TC5Yqsuw3G+ oijc5xk//mYn7F6/3RlTroxKBHRtE96NY6SMHRew3pSEANaHxfyox5wgNXSwNGOxmgkm72ltE qEv1EDvDjidcv0bZQHc4oPktY4Vat8g7auObEMi//lmyioGCoHZd+JVGAvO4NYvMDdtcJzhVb EUIKfwppwbC3Zt+l7msHcppmFzW7/09WXS19odcDW2hxgbBsZHKUaUXXh75I9Fr7IvssE7GMZ E1QQKJYQ9A/Fla7OigntlSRV85Gz0d93ppt5uvybKK6lk9vZAnlT4s2wE5Hm5nOaKb95S8hc X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205086 Archived-At: On 2021-04-28 08:19, K=E9vin Le Gouguec wrote: > Shell builtins seem to work though: Oooo. Thanks. Function shell-command-to-string is using a non-interactive shell (echo $- results in no 'i") while function shell isn't. Now I definitely need to re-think my position for the diredc package, and possibly also for this bug report. For dired{,c} use, the judgment for me is to weigh OTOH the common (my experience) case of uninstalled programs appearing in the default lists for "&" and "!", versus OTOH the rare (never in my experience) use of "&" and "!" for shell built-ins. For diredc the call is easier in favor of limiting '&' and '!' because diredc has a shell pop-up window "'" with midnight-commander type variable= s ($d1 $d2 $f1 $f2 $t1 $t2) for the current directories, files, and marked files. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0