From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Now branch isearch-vertical Date: Sat, 10 Apr 2021 21:02:33 +0200 Message-ID: <20210410190233.acqbhi3wj3v2bzaw@Ergus> References: <83wntb7eli.fsf@gnu.org> <940751cee50d69f2231d@heytings.org> <83r1jj7bhg.fsf@gnu.org> <940751cee5acf0f913df@heytings.org> <83eefj705i.fsf@gnu.org> <940751cee53181aedd72@heytings.org> <83a6q67gme.fsf@gnu.org> <5cf18ab57c8becad2999@heytings.org> <83pmz25sdr.fsf@gnu.org> <5cf18ab57ca5d2cc99ad@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34707"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 10 21:03:49 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVItZ-0008wI-MC for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Apr 2021 21:03:49 +0200 Original-Received: from localhost ([::1]:60320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVItY-0008D9-Nq for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Apr 2021 15:03:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVIsm-0007g0-0S for emacs-devel@gnu.org; Sat, 10 Apr 2021 15:03:00 -0400 Original-Received: from sonic313-14.consmr.mail.bf2.yahoo.com ([74.6.133.124]:35305) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVIsi-0002uq-5j for emacs-devel@gnu.org; Sat, 10 Apr 2021 15:02:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1618081372; bh=B/eW62s6ver1PSZyGLlwZf3LzjP089NE64RbkOMbdyc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=hAsVivC0yTfDc9/dZco3Li3Ih3PNVV5SGpk1XmelOeQSOL9n5lJ7mA4iCHv0POjR4xttT1uUVY6NMTy9YaQWq3Y55NyB/ILKW1+m0GidLuxLkqYgtZ2hY7H26Nh8ldnJ0bkVqJMU0VHrd/oZ7R5F90YOFoDzdFJbrFCe0r4w7DVRRTSIUvZ0nLL0VC4xMHOGBRLj8tDrv8uwXXGXm5jNuM7VUNHdjfF4jRnq/iGxZP93PuyX93zfasJkv1Xz7pOisZIgv4o6yZalkjiZxBtqR/Z7RTEfJ0EziRY6kzeXGHAmfjy8tAT5i7bVLgErLdEuXz1ItsaSnzHKlcbAJMxtCQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1618081372; bh=fEpsLYA8y11+55rO/kujBFFUHHfLAu4+cwr2VMuIMad=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=SWVL1LBCCmGYz/bXV2haEmHpWDgYvXQmSpP2eAGFNJdyxlEB31BBnAnuvrAcF7zyDnffqhI8HSVMG303hoCQaAGdvv9Lah8yUWJ/8k3619WTZSBbhcbGwvtPIvbdg9szPgaGOLVoi2RPgVc00jauJ8aMnyCD7w1jM0L0GSAByGyLQ7FUzfGiDhpg7cJeNaBS1z0i5+ETvBIWO9DGuaJAdzUd1FM31X9ewenZ7vqczLcthzqESmgojKNhq6Git5tdjQPdqevQYN+LAbG4qt+LEHvxI73OZdvj3E2uKdvumeeDbr/PzwfG1CsXlyxmyz4kmATDNeQ8b/ar2z2ENDuwmg== X-YMail-OSG: bjhpfuoVM1ncPnGBe9AzjHNYoJAw6V51p29ce51.USfm30GgLe8VRLw2EYQUTdh tAWbqcyqiNzkYRPXdfjrazPcAkTMCekF2VLex7U5bbWE2QNRCmK8ip81keMqE.0uzTALti4FqsZi _snBwNwmpWJKQUXTV4CTJRaDtbgc6iB9WKmxC8xlZc4_y9rr2FnCZyDFqQLpWL.v3d1F0825tK4u DYCRG6wNqndyPmrT3oHk2GYIIOlZ4MsxDfS43x_esyzxYcGLms9BQ99c4HkW8Vx1YFNr54.vbUxD Yu00NZ9rWt2dkw4yEZ0tQEf8a81JnVTZJytpRjHWHdAT5NC_03_VjNCfzxfEfjGIZo49pebFwNXb r5A271XYapbYCUNqJGThdLUva0FLZeKc_oXtp11Um6t5vP053kZr3w1r5jxhRujLswOERpXUfN5s 2au1rMFl0CMon41Q2qPhfg5N1jn229_e96KfRkIKUva.G88FbLzvvkg_8fGgLIvJP.DntPtZagf5 jcwYGVu7umY5BzEkVl11nKE2ErZZTfL4Ooo4T7aXcTRCEyvW2vttE21rVayNrAjiGrLcmRFoR6mH UD2L4vkgg4zG3s_uJd_iamRbKrdWJL4aIWZA6zhTfgF4bh1chwmVmQVDbPzNiMIKkwNOtw4RBeQe 8ja2107m0haItkq53ydpY4TqwageF7iTcMWIYYQW2N7lw_PAfhELhO_8yenC6IfwR8KQLQv2Dsb8 xYCxivcR1fFbv23AXzPFBDrYGt2BIZmOeIg_2N6SbagagUXjN6OftVhWndxsIcKeGh.qaDNIa3RZ C6t_xqJP5TrEGmelQtgUu6T1l2iyUEYaJ3fQ_Sjcsm X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.bf2.yahoo.com with HTTP; Sat, 10 Apr 2021 19:02:52 +0000 Original-Received: by kubenode531.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 7b864638dc621a1259e795babe2b975d; Sat, 10 Apr 2021 19:02:51 +0000 (UTC) Content-Disposition: inline In-Reply-To: <5cf18ab57ca5d2cc99ad@heytings.org> X-Mailer: WebService/1.1.18121 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/16) Received-SPF: pass client-ip=74.6.133.124; envelope-from=spacibba@aol.com; helo=sonic313-14.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267832 Archived-At: Hi Gregory: I see that you added a new feature branch to finally implement icomplete-vertical. Let's hope this time it will be added. If you permit me 3 suggestions: 1) Could you add some customs for the separators? This may simplify the "unless" calls you needed to add twice. But also will permit the user to configure them. IMO the best alternative is a sort of format; but at least setting the {} [] and () somehow will be very handy... maybe with a const pair. 2) I am wondering about the icomplete-code that determines the number of candidates. IIRC the candidates are determined by the windows width... so maybe that needs some check? Because with narrow windows or long candidates the list may be needlessly truncated in vertical? 3) When you corrected my branch that time ago I remember that your recommendation was to respect the user option icomplete-separator. To detect if it had a "\n". Now that most of the display issues are solved and the setup is simpler. Isn't it possible to do that with a simple (if) in icomplete-minibuffer-setup instead of adding a hook?; setting some variables and then avoid all the `unless` and `if` in the (if prospects) part? So we don't need the extra mode and the setup for the user will be simpler. Best, Ergus On Sat, Apr 10, 2021 at 10:57:33AM +0000, Gregory Heytings wrote: > >>>I attach the updated patch, in which I included your other suggestions. >> >>Thanks, this LGTM, but I wonder whether we should use \\[foo] >>instead of a literal `foo' in the doc strings, since users are >>likely to use the key sequences, not the command names. >> > >Thanks, see attached.