From: YASUOKA Masahiko <yasuoka@yasuoka.net>
To: eliz@gnu.org
Cc: 46791@debbugs.gnu.org
Subject: bug#46791: 27.1; crash at gtk_label_new()
Date: Sat, 27 Feb 2021 12:35:56 +0900 (JST) [thread overview]
Message-ID: <20210227.123556.1905602128538185076.yasuoka@yasuoka.net> (raw)
In-Reply-To: <831rd2rj3k.fsf@gnu.org>
On Fri, 26 Feb 2021 16:37:03 +0200
Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Fri, 26 Feb 2021 16:32:06 +0900 (JST)
>> From: YASUOKA Masahiko <yasuoka@yasuoka.net>
>>
>> When I'm using Mew(https://mew.org/) on emacs 27.1, emacs crashes
>> frequently. It happens when I am composing a mail message in "draft
>> mode" of Mew.
>> [...]
>> In src/gtkutil.c, update_frame_tool_bar():
>>
>> 5197 ti = xg_make_tool_item (f, w, &wbutton, label, i, horiz, text_image);
>>
>> this "label" is invalid when the crash happens. This "label"
>>
>> 5006 for (i = j = 0; i < f->n_tool_bar_items; ++i)
>> 5007 {
>> 5008 bool enabled_p = !NILP (PROP (TOOL_BAR_ITEM_ENABLED_P));
>> 5009 bool selected_p = !NILP (PROP (TOOL_BAR_ITEM_SELECTED_P));
>>
>> 5022 const char *label
>> 5023 = (EQ (style, Qimage) || (vert_only && horiz)) ? NULL
>> 5024 : STRINGP (PROP (TOOL_BAR_ITEM_LABEL))
>> 5025 ? SSDATA (PROP (TOOL_BAR_ITEM_LABEL))
>> 5026 : "";
>>
>> is set at the begining of the loop(#5006),
>>
>> 5065 specified_file = file_for_image (image);
>> 5066 if (!NILP (specified_file) && !NILP (Ffboundp (Qx_gtk_map_stock)))
>> 5067 stock = call1 (Qx_gtk_map_stock, specified_file);
>> 5068
>>
>> it sometimes become invalid just after #5067. Then it is passed to
>> gtk_label_new() through xg_make_tool_item(), the crash will happen.
>>
>> Since we can get a valid "label" pointer again by setting it in the
>> same way of the beginning of the loop, we can fix the bug by moving
>> the initialization of "label" to a place just before it is used. The
>> following diff does this:
>
> Thanks. Could you please try the slightly different patch below? It
> is IMO safer, since it doesn't depend on a 'char *' pointer into a
> Lisp string's data to remain valid after some point in the code.
Yes. I tested your patch, it seems to fix the problem.
Thanks,
next prev parent reply other threads:[~2021-02-27 3:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 7:32 bug#46791: 27.1; crash at gtk_label_new() YASUOKA Masahiko
2021-02-26 14:37 ` Eli Zaretskii
2021-02-27 3:35 ` YASUOKA Masahiko [this message]
2021-02-27 7:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210227.123556.1905602128538185076.yasuoka@yasuoka.net \
--to=yasuoka@yasuoka.net \
--cc=46791@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.