From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#44349: 28.0.50; Assertion failure on macOS when resizing frame Date: Sun, 29 Nov 2020 17:43:25 +0000 Message-ID: <20201129174325.GI26836@breton.holly.idiocy.org> References: <83eelegxq6.fsf@gnu.org> <83a6w2gwxz.fsf@gnu.org> <20201127222429.GD26836@breton.holly.idiocy.org> <835z5por4y.fsf@gnu.org> <20201128220645.GF26836@breton.holly.idiocy.org> <835z5omc6s.fsf@gnu.org> <20201129171623.GH26836@breton.holly.idiocy.org> <83k0u4krfa.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36448"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44349@debbugs.gnu.org, p.stephani2@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 29 18:47:31 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kjQnL-0009NS-VN for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Nov 2020 18:47:31 +0100 Original-Received: from localhost ([::1]:59826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjQnK-0001bx-Q2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Nov 2020 12:47:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjQjz-0008Ah-K3 for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2020 12:44:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40965) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kjQjy-0000vB-60 for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2020 12:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kjQjy-000426-3j for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2020 12:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Nov 2020 17:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44349 X-GNU-PR-Package: emacs Original-Received: via spool by 44349-submit@debbugs.gnu.org id=B44349.160667181715455 (code B ref 44349); Sun, 29 Nov 2020 17:44:02 +0000 Original-Received: (at 44349) by debbugs.gnu.org; 29 Nov 2020 17:43:37 +0000 Original-Received: from localhost ([127.0.0.1]:52509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjQjZ-00041C-HF for submit@debbugs.gnu.org; Sun, 29 Nov 2020 12:43:37 -0500 Original-Received: from wilbur.contactoffice.com ([212.3.242.68]:35394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjQjX-00040v-TH; Sun, 29 Nov 2020 12:43:36 -0500 Original-Received: from smtpauth1.co-bxl (smtpauth1.co-bxl [10.2.0.15]) by wilbur.contactoffice.com (Postfix) with ESMTP id 87961DA5; Sun, 29 Nov 2020 18:43:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1606671809; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To; l=942; bh=fTZqY1E+krVWrphpz2+7Jf/kgfKXQ8npLEtbTEtL+os=; b=Jjs+Q/5cQDNCbksJD2Y6ZxZ5/8sUW7yvWX0FkSEk1ScVH9u/lpnNIW7EPeTx1FDg niWP0eEYyrva1n3OXrRtJiVZENLwb0vyp1epDdCVbwRQ5XoEzZMfyP3dK7hc0iHrAn2 svlKC+uuD/sdSKDIJ4XMjjgD8KK9kTKoSTxi9di07gFZnjaq5Q3nJvGDSC2SoFWyfOo 8pZoq88Q+oEbWV2KHuio0oDB/Fur4uSckjB9OgO+ngWUNKHSstWj13EqbQzU3zuHuIm EWzZaDP52lvpw7NFq0sqQUlvrQEHOZZdplGkepx89/C/l6we0UzwB8BPsTAp5BYqOg/ avVUu23w/Q== Original-Received: by smtp.mailfence.com with ESMTPA ; Sun, 29 Nov 2020 18:43:27 +0100 (CET) Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 3520320269E4D8; Sun, 29 Nov 2020 17:43:25 +0000 (GMT) Mail-Followup-To: Alan Third , Eli Zaretskii , 44349@debbugs.gnu.org, p.stephani2@gmail.com Content-Disposition: inline In-Reply-To: <83k0u4krfa.fsf@gnu.org> X-ContactOffice-Account: com:241649512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194576 Archived-At: unmerge 44850 close 44349 28.1 quit On Sun, Nov 29, 2020 at 07:23:53PM +0200, Eli Zaretskii wrote: > > Date: Sun, 29 Nov 2020 17:16:23 +0000 > > From: Alan Third > > Cc: 44349@debbugs.gnu.org, p.stephani2@gmail.com > > > > > Ah, okay. In that case, I think ignoring the invalid sequence is OK, > > > but let's document that in the function's commentary. > > > > I think, having thought about it more, I'd prefer to just pass through > > the malformed input. If we want to make sure that putting format_end > > in the middle of a multibyte character doesn't break anything I think > > we'd be better fixing doprnt_non_null_end to cut the string up neatly. > > Anything that avoids a crash is fine in this case, thanks. > > > format_end isn't currently used anywhere in Emacs, so I don't know if > > it's worth fixing, but I'll add a FIXME comment. > > TIA. Done and pushed. Thanks. -- Alan Third