From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: feature/completions-highlight-modifications e3c5b99 3/6: Add completions-highlight-mode initial implementation. Date: Mon, 23 Nov 2020 12:46:20 +0100 Message-ID: <20201123114620.6htiapgjp4oykvib@Ergus> References: <20201116102729.ywubtda6cqdzc45z@Ergus> <87d00acuh3.fsf@mail.linkov.net> <20201119032519.lpa53ixezgpdppze@Ergus> <87d009kfmf.fsf@mail.linkov.net> <20201119105052.kfichqojkhfwwsiz@Ergus> <87k0ugfirt.fsf@mail.linkov.net> <20201120145248.wmbv2zgbvs7bg25i@Ergus> <871rgmwt6e.fsf@mail.linkov.net> <20201122230956.mai3i6ckqymzvyvb@Ergus> <87pn44juyg.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2172"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , Drew Adams , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 23 12:59:09 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khAUv-0000Py-N7 for ged-emacs-devel@m.gmane-mx.org; Mon, 23 Nov 2020 12:59:09 +0100 Original-Received: from localhost ([::1]:41538 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khAUu-0001bV-KQ for ged-emacs-devel@m.gmane-mx.org; Mon, 23 Nov 2020 06:59:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khAJ0-0001Q4-J9 for emacs-devel@gnu.org; Mon, 23 Nov 2020 06:46:55 -0500 Original-Received: from sonic316-13.consmr.mail.bf2.yahoo.com ([74.6.130.123]:45858) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khAIu-00044r-Lz for emacs-devel@gnu.org; Mon, 23 Nov 2020 06:46:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1606132000; bh=qYAZOEnOcJDwHCFnkZ5L/DzGXIJu2Zst/acKzzV8jRk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=jAfgB3HK8H1VVrRdqE1sN9AyybfF5OyuPjaudJTLmCl+G5CshV39PU8ICopmyBtNbRKcXcgKiiCKktFA4l0ItkfNlKyaL48/jNUGe1LzqQo0aiSTRVjH+gMbZO7RvtqOKiA7PaFp7mUxF04yMp9J6zY2+xtn8fheSqPaOb6WU5Q26ZX0k8FdAGboIwU+hwq5GrCynS7zlomsu+r/WydAnHhqPiWhICVqP18Zrcx0DR6YS/tWkrgcvtA5Z54ChZlwojTqeb2HneKJRooGpvkSZtih0H/kn9VAsy2X73YVbJEhp8lakE7gARc8q9BS+RfiWE3k6SI8dCudZlL8EehhRg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1606132000; bh=OwiworGLP57oUYFDtZsATGYCLzeIxwq5xtAyHQ+TnX0=; h=Date:From:To:Subject:From:Subject; b=S3BWgd0jzXtKOwB34lgkxMeWedZSNz75l71JsuwPULOL4yTR0FoAPkjNUe7r2wiWXsq5IJawQPeOaVzcIMDrlleWmv3fn/D/HLgdiZC0Jddu59fFfVM3DIz4X0igxavpvnt3MMzjaM1OXEOzY2IxWtHxp8FoloMFWMhfXnHd1bFHdsgm+9FW8VHyP2+XdPk1sPMoM5i8AHovezP9t9x5dtIFX2uzfiUuEcT8PpRg4MUJMqeB5Wn9wrkDa+bAR9lA4MBkZ3NFz6J3qHjQNQtZVbaTB1YXqz1xgJUDYFXklGanpzjZI6fFyrHkwa6lPQfsVzx0upyGTCJl4C9UEAIVvg== X-YMail-OSG: l9.XHG4VM1lTUN5raNYd7qzQj9OcVD81ojVBQD_rsNPLNIILkloBKKNqPLSkb2y tWohlh8VHTAk5uK__n0RVwQEWq4EajjdWy0LWNlym8LjXB9M6AgOQ0C7nzBm_GwOUjtCswUW2.xY .bv3ht_JUV_Y7EsgagNOSdqbK1dzA8n98ZkbWbfUZy.OunwPFUyyBBUbifZ4himxXAsSVx1twADL NL5Rdsps1Lg7gGsznmriEn9RUnq3cE2y7Xk85_P8Id8khyXejg7GsODFmME1RfXT7xIqWnpo9ndJ CUgQjtfy0BLde9TkIG.0dZ6V90aLcZMp_fevsG2pH56L7PufVtjPQFpvA5L3vqsu4DSE0IXv.2fr nnQ5ohHJTVj0tnYzgL1COgWbp.7y.I0lVpna1GwnPp3hVupyWkzmZiz9MIXOI4L_qh1RWSWMchkk ztvowfd8iz9VFH5QNTQiJKYBrjm8IHpxf138NPJw_D1aLmucBrGqFAZMUZ_eVDVxadAI.AHbWlF_ PxpUZ_ZTT7bkYArqJxdPUYnBHFTE43kniz9HvMnd8mLEhEHND0ccmhWrhQL90lNzr8pcl8pJqLox 24Av4Nl9kwWSiUGhKLDEb7mv_TFk4kURQ5hz2Lv8oZuROUM8dbAO7Epg5VFtfxd.ryWt0jYQM8KK o1zn4WFf0_kVesa9EFHkss2s45K0EL1_.hlNorZ2JPCTRqwmqTfPySSnclMM225usfBC9PgUHe3e aCQV2pZ_C.vBamGsRlQVTo3hz9Du1_NthLFTWKbrZHPOOenwzbi86iJyLiiNVC4jvEMlFZsPx6j. Q6QEZwM7TOX91FUvLdQrByYoR_5JPt0RbP7h4KPeTQ Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.bf2.yahoo.com with HTTP; Mon, 23 Nov 2020 11:46:40 +0000 Original-Received: by smtp407.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 2f2a60d023d24a6bd5a76709476e9d24; Mon, 23 Nov 2020 11:46:34 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87pn44juyg.fsf@mail.linkov.net> X-Mailer: WebService/1.1.17111 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.8) Received-SPF: pass client-ip=74.6.130.123; envelope-from=spacibba@aol.com; helo=sonic316-13.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259676 Archived-At: On Mon, Nov 23, 2020 at 11:14:47AM +0200, Juri Linkov wrote: >> Could you try it now please? IMO icomplete (and ido/ivy/helm/etc) are more invasive than this mode (as I conceived it initially at least) because they diverged much more from the *Completions* way to do and the philosophy. I would actually prefer to remove features from this one if there is a chance to add some of these improvements to the default completion system (after the expected war of course). Maybe making it less "zsh-ich" and just improving a bit the Completions interaction may be possible?? In case you really think that nothing of this may become default then I prefer to add this code as a package to elpa instead; to not overload the base code with potentially useless/unknown modes that nobody will find useful/discover (once a user is capable to configure their init.el they will go for icomplete/ido/fido/ivy/helm instead of this). I think very few old users use the default completions system these days and it gives a terrible first impression to new comers and make emacs feel too "vintage". That's what I want to improve. If the changes we do are conservative enough (maybe just like the first version I proposed: add tabs, arrows interaction and highlight after an extra tab) It may not bother old users while the new will find the more interactive behavior after the extra tab very handy. > >Also setting buffer-local cursor-in-echo-area to t in the completions >buffer provides a better look and feel of editing in the minibuffer >(like you disabled mode-line). Ahh I forgot to mention. In gui interface cursor-in-echo-area works fine (setting the cursor in the "right" position) but in -nw the cursor is set at the end of the line and leaves an extra space. I am not sure if this is an issue or a feature IMO it is an issue because behavior must be the same either in tui or gui. I even considered to set an overlay but maybe this is something must be properly fixed (if it is an issue of course) Best, Ergus